From patchwork Wed Feb 10 21:38:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Simon Tournier X-Patchwork-Id: 26988 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id C06F627BC27; Wed, 10 Feb 2021 21:42:48 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 4298827BC26 for ; Wed, 10 Feb 2021 21:42:48 +0000 (GMT) Received: from localhost ([::1]:46868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9xG3-0000Aj-CY for patchwork@mira.cbaines.net; Wed, 10 Feb 2021 16:42:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9xDO-0007ea-Bl for guix-patches@gnu.org; Wed, 10 Feb 2021 16:40:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45770) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9xDO-00089E-43 for guix-patches@gnu.org; Wed, 10 Feb 2021 16:40:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9xDO-0003eQ-15 for guix-patches@gnu.org; Wed, 10 Feb 2021 16:40:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46429] [PATCH 0/1] guix time-machine: fail when unrecognized option Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 Feb 2021 21:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 46429 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 46429@debbugs.gnu.org Cc: zimoun X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161299315913979 (code B ref -1); Wed, 10 Feb 2021 21:40:01 +0000 Received: (at submit) by debbugs.gnu.org; 10 Feb 2021 21:39:19 +0000 Received: from localhost ([127.0.0.1]:57316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9xCh-0003dP-2p for submit@debbugs.gnu.org; Wed, 10 Feb 2021 16:39:19 -0500 Received: from lists.gnu.org ([209.51.188.17]:46148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9xCc-0003dE-CA for submit@debbugs.gnu.org; Wed, 10 Feb 2021 16:39:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9xCc-0007KT-5K for guix-patches@gnu.org; Wed, 10 Feb 2021 16:39:14 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:35679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9xCX-0007oN-2F for guix-patches@gnu.org; Wed, 10 Feb 2021 16:39:10 -0500 Received: by mail-wm1-x330.google.com with SMTP id n10so1372212wmq.0 for ; Wed, 10 Feb 2021 13:39:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Qy9/DeigjIvqLSiTbY4IfKNDPN7woZ33sI7plQyY7Ok=; b=sPQiJYC2feLIFQMZt2Bf/9Zp8de5Qp32YzEPm2cNzYV0zs7L/UvzaNNBTU/AoWcEkJ Vg46sStDobtRaigjccEMbDYuhJh1lFtMcAu2OxTGJ+lf0avPpeRKzMqEJPA7iLUqX3pY UplvklTtwigNZaAfXoP31z4QWkpfweMFuwcr5Xu98LKP1gjhGLcMeCWhIaq8LRQ2+tBB djHjM6sFrMQDtOaXZXc2b8zq653Wa5+0jsacbueXu//4sl0GcXlwb2fCDgbuqvNwsTTl KWnhpo9tTTM5WOkQA/AogT5rj7HvL5w9jXsliP2Kgx11CUeWWUjJ/9zWnZM/7HyDUMi/ lSMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Qy9/DeigjIvqLSiTbY4IfKNDPN7woZ33sI7plQyY7Ok=; b=cg3f5q/MX9UCsF1lB2ULQd9GrT2cvAOCi7EqgG0mou06ysGWeqyV0gSTBuvqOPwYWi di9VtgOWnD/glOOcB7ftKP/+14V550/VgkgXxPZK1l/PEZ86/0g2rLCT4GJIXUKvcDun cXQi+mE1eMWkfJuvR8I861XwkkoUtDO3zX8GZq/hQ6V8j4Aennuu1HumI9totse0UFzO YRpfF/fTxaf7Y+LVrncUofaD3RzcriyNgSpyE1bW/87RjiRreeUtUmPuF48QU61x5MWS VFPeKTwsPTlQjVv5ZSiSWBwrKvfyZHvExUFaQTczfYVOqGsRatmvihnp1r/NwG4vDbcJ dOAg== X-Gm-Message-State: AOAM532gg9Vo7F0DRVYROtbYzTCcN9xqKUUDiR91FEJSMqcil1MXDzKI WUreJDl4URxqcV3kLgJ3snuyTy3nqLA= X-Google-Smtp-Source: ABdhPJy5Nw3KhZ3sGOqegbLpGX8WKlKJvUyW/fLDwyI5Io2XigR4NwQkzjD/a/ZYB+9KRv3mJ325vQ== X-Received: by 2002:a05:600c:19cc:: with SMTP id u12mr1056789wmq.26.1612993146715; Wed, 10 Feb 2021 13:39:06 -0800 (PST) Received: from localhost.localdomain ([193.48.40.110]) by smtp.gmail.com with ESMTPSA id n193sm4533552wmb.0.2021.02.10.13.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 13:39:05 -0800 (PST) From: zimoun Date: Wed, 10 Feb 2021 22:38:50 +0100 Message-Id: <20210210213850.44577-1-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi, Currently, the command line: --8<---------------cut here---------------start------------->8--- $ guix time-machine kikoo -- --version guix (GNU Guix) 8f8a1485b80de707caecf6e7e29b520cd8cf611e Copyright © 2021 les auteurs de Guix Licence GPLv3+ : GNU GPL version 3 ou ultérieure Ceci est un logiciel libre : vous êtes libre de le modifier et de le redistribuer. Il n'y a AUCUNE GARANTIE, dans les limites permises par la loi. --8<---------------cut here---------------end--------------->8--- does not fail but uses the current commit. This leads to confusing behaviour as described in , for instance: $ guix time-machine 8e7e414aa998fe8c0de8a491c91aab8b8d9c58f4 -- graph maven which had failed with: --8<---------------cut here---------------start------------->8--- "453f18db343cbad1892186b85c7eb07f364b399e"; system: "x86_64-linux"; host version: "838347207cdd96de1ad0127aaf4b2c378c7c2148"; pull-version: 1). --8<---------------cut here---------------end--------------->8--- The failure is another reason. However the backtrace is not informative about the real issue which is a misuse of the command line. This trivial patch fixes it by gracefully failing. All the best, simon zimoun (1): scripts: time-machine: Fail when unrecognized option. guix/scripts/time-machine.scm | 3 +++ 1 file changed, 3 insertions(+) base-commit: 8f8a1485b80de707caecf6e7e29b520cd8cf611e