mbox series

[bug#46139,v3,0/1] gnu: Add tpm2-tss.

Message ID 20210128132628.24609-1-lle-bout@zaclys.net
Headers show
Series gnu: Add tpm2-tss. | expand

Message

ashish.is--- via Guix-patches" via Jan. 28, 2021, 1:26 p.m. UTC 
Thanks for the review.
Final patch, if any additional nitpicks, please co-author my patch.
I run `guix lint` before submitting any patch to GNU Guix upstream now,
I used to forget few times before. It would help me if things like
putting home-page above synopsis were checked by the linter, I'm not at
ease with Scheme so if anyone knows how to add that, please do. Thanks.

Léo Le Bouter (1):
  gnu: Add tpm2-tss.

 gnu/packages/hardware.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

Comments

Nicolas Goaziou Jan. 28, 2021, 5:47 p.m. UTC | #1 
Hello,

guix-patches--- via <guix-patches@gnu.org> writes:

> Final patch, if any additional nitpicks, please co-author my patch.

Hmm... I re-ordered alphabetically the inputs and applied your patch.

> I run `guix lint` before submitting any patch to GNU Guix upstream now,
> I used to forget few times before. It would help me if things like
> putting home-page above synopsis were checked by the linter

Putting home-page after synopsis is not a show stopper and wouldn't
prevent a patch from being applied. There is no written convention about
it. It's more of an habit.

Thank you!

Regards,