| Message ID | 20210118185925.24412-1-eu@euandre.org |
|---|---|
| Headers | show |
| Series | Update fzf, include binaries and install completions | expand |
Hello, guix-patches--- via <guix-patches@gnu.org> writes: > I've tested both the package update and the extra phases added. > The Bash completions are being installed properly, but I haven't tested > the zsh ones. > > I remember seeing somewhere a discussion on aliasing this type of package, > so that the "go-github-com-junegunn-fzf" is the default imported Go module, > to be used as input for other packages, and adding a top-level "fzf" package, > which does the ad-hoc packaging code I've added, so that a user can install > the "fzf" package with Bash integration and similar features. Indeed, having to install "go-github-com-junegunn-fzf" when you are really looking for "fzf" is not very intuitive. So, "fzf" could inherit from "go-github-com-junegunn-fzf" and add all the bells and whistles. Would you want to provide a patch for that? Meanwhile, I'm going to apply the update and leave the first patch out. Regards,
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Would you want to provide a patch for that?
Sure, I'll do it in the next few days.
I've tested both the package update and the extra phases added. The Bash completions are being installed properly, but I haven't tested the zsh ones. I remember seeing somewhere a discussion on aliasing this type of package, so that the "go-github-com-junegunn-fzf" is the default imported Go module, to be used as input for other packages, and adding a top-level "fzf" package, which does the ad-hoc packaging code I've added, so that a user can install the "fzf" package with Bash integration and similar features. I couldn't find anything on the manual also, I welcome comments on this :) EuAndreh (2): gnu: go-github-com-junegunn-fzf: Copy binaries and install shell completions. gnu: go-github-com-junegunn-fzf: Update to 0.25.0. gnu/packages/terminals.scm | 35 +++++++++++++++++++++++++++++++---- 1 file changed, 31 insertions(+), 4 deletions(-)