From patchwork Fri Oct 23 09:58:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 24752 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 7DCA027BBF0; Fri, 23 Oct 2020 10:59:18 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 1EBE927BBEE for ; Fri, 23 Oct 2020 10:59:18 +0100 (BST) Received: from localhost ([::1]:57598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVtqv-0001zK-7K for patchwork@mira.cbaines.net; Fri, 23 Oct 2020 05:59:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVtqg-0001zB-PW for guix-patches@gnu.org; Fri, 23 Oct 2020 05:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43836) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kVtqg-0004mc-Fl for guix-patches@gnu.org; Fri, 23 Oct 2020 05:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kVtqg-0002T8-FC for guix-patches@gnu.org; Fri, 23 Oct 2020 05:59:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44169] [PATCH 0/3] Referring to swap with UUIDs and labels Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Oct 2020 09:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44169 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 44169@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16034471129438 (code B ref -1); Fri, 23 Oct 2020 09:59:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Oct 2020 09:58:32 +0000 Received: from localhost ([127.0.0.1]:55382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVtqC-0002SA-7M for submit@debbugs.gnu.org; Fri, 23 Oct 2020 05:58:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:46368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVtqB-0002S3-5l for submit@debbugs.gnu.org; Fri, 23 Oct 2020 05:58:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVtqA-0001xl-TN for guix-patches@gnu.org; Fri, 23 Oct 2020 05:58:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37854) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVtqA-0004av-0a; Fri, 23 Oct 2020 05:58:30 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=55054 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kVtq9-0007kx-2b; Fri, 23 Oct 2020 05:58:29 -0400 From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Fri, 23 Oct 2020 11:58:22 +0200 Message-Id: <20201023095822.20528-1-ludo@gnu.org> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi! Someone reported on IRC yesterday that the installer generates ‘swap-devices’ that explicitly list /dev nodes. These patches change that so that it uses UUIDs instead. It’s only in the unencrypted case anyway, because I think we don’t create swap partitions in the full-encrypted mode because the partition would be unencrypted (or we’d need to set up another LUKS mapping, but the installer doesn’t do that). The ‘swap’ Shepherd service can now look up swap devices by UUID/label. Note that it uses the generic ‘find-partition-by-label’ and ‘find-partition-by-uuid’ procedures, which means it could stumble upon a partition that’s not a swap partition. That’s unlikely and probably OK though: the worst that can happen is that the ‘swap’ Shepherd service will fail to start. Feedback welcome! Ludo’. Ludovic Courtès (3): file-systems: Allow swap space lookup by UUID/label. services: swap: Allow for UUIDs and file system labels. installer: Use UUIDs in the 'swap-devices' field. doc/guix.texi | 34 +++++++++++++++++++---- gnu/build/file-systems.scm | 43 ++++++++++++++++++++++++++++- gnu/installer/parted.scm | 7 ++++- gnu/services/base.scm | 55 +++++++++++++++++++++++++++++--------- 4 files changed, 120 insertions(+), 19 deletions(-)