From patchwork Tue Sep 15 14:21:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Batista?= X-Patchwork-Id: 24145 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 2A1DA27BBE8; Tue, 15 Sep 2020 15:23:09 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 7F74027BBE7 for ; Tue, 15 Sep 2020 15:23:08 +0100 (BST) Received: from localhost ([::1]:37410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIBrP-0000fX-JW for patchwork@mira.cbaines.net; Tue, 15 Sep 2020 10:23:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIBrK-0000fN-Ms for guix-patches@gnu.org; Tue, 15 Sep 2020 10:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48451) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIBrK-00016R-EC for guix-patches@gnu.org; Tue, 15 Sep 2020 10:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIBrK-0005jy-BJ for guix-patches@gnu.org; Tue, 15 Sep 2020 10:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42380] [PATCH 0/9] gnu: Add torbrowser-unbundle. Resent-From: =?utf-8?b?QW5kcsOp?= Batista Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 15 Sep 2020 14:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42380 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ludovic =?utf-8?q?Court=C3=A8s?= Cc: Efraim Flashner , 42380@debbugs.gnu.org Received: via spool by 42380-submit@debbugs.gnu.org id=B42380.160017973621991 (code B ref 42380); Tue, 15 Sep 2020 14:23:02 +0000 Received: (at 42380) by debbugs.gnu.org; 15 Sep 2020 14:22:16 +0000 Received: from localhost ([127.0.0.1]:59997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIBqa-0005id-7P for submit@debbugs.gnu.org; Tue, 15 Sep 2020 10:22:16 -0400 Received: from mx1.riseup.net ([198.252.153.129]:60086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIBqY-0005iU-AX for 42380@debbugs.gnu.org; Tue, 15 Sep 2020 10:22:14 -0400 Received: from bell.riseup.net (bell-pn.riseup.net [10.0.1.178]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4BrQR92t6lzFdvP; Tue, 15 Sep 2020 07:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1600179733; bh=3tFILz5UP9QXST2Ak7uDSs8D5+J/GNhP6HgJwBNxwQE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g/Wr1NQSy80EnTnG+zTNGAlld7LeqXZdgediRYzA42iQtnKUmN+kVH8hb8VBB4WD1 UsduowdNlq8gnCasavebAyZnx27cTHWpb9lpxgjADnQE5MfhADsFzmVBl6HAe3x3zF UtWqpZ5IoFWbH4N0uG9FAG6SjH3BzX5ldk5Jr32k= X-Riseup-User-ID: 1FE39216BE651DA6B6E89601595D1F7BBFCB2C1195562F1AC901BDA2CC2D04BF Received: from [127.0.0.1] (localhost [127.0.0.1]) by bell.riseup.net (Postfix) with ESMTPSA id 4BrQR74QnZzJrrn; Tue, 15 Sep 2020 07:22:11 -0700 (PDT) Date: Tue, 15 Sep 2020 11:21:28 -0300 From: =?utf-8?b?QW5kcsOp?= Batista Message-ID: <20200915142128.GA12025@andel> References: <20200715211547.GA17146@andel> <20200725144930.GA13751@andel> <20200803125556.GA18868@andel> <87blihhdz6.fsf@gnu.org> <20200909022429.GA24930@andel> <878sdjo1qv.fsf@gnu.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <878sdjo1qv.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Ludo, qua 09 set 2020 às 09:20:08 (1599654008), ludo@gnu.org enviou: > Hi André, > > André Batista skribis: > > > For sure. I'll give it a few more tries and cleanup the mess > > here before sending this patch series. If I don't succeed, I'm > > planning on sending it anyway so at least the libs can be > > added and maybe someone can spot what I'm missing. But maybe > > it's wise to hold Tor Browser itself since there has been an > > announcement of some large percentage of exit relays messing > > with Tor traffic[7]. > > I don’t think Guix users will radically increase traffic over Tor, so I > think we can keep going. :-) Just to be sure: it's not so much about Guix users increasing the load on Tor Network as of Guix users not having the benefits of this extension and being prey to sslstriping. Since you're giving a green light and I've encountered further deterrence down the trail, I'll be sending this patch series which also updates Tor Browser to the latest version. I've left comments on code where I see room for improvement, in case someones wants to help. For now, I'm trying to solve this issue and I think I'll start a new thread for tracking it in order to avoid clutter here as https-everywhere requires a good many new rust libs. > >> Regarding Tor Browser itself, can you think of ways to factorize code > >> with IceCat? > > > > Other than sharing the https-everywhere definition, I was > > thinking maybe we could take a diff of Tor Browser and Firefox > > and avoid downloading firefox source twice when building both > > browsers. But I need to take a more careful look. I'll give > > this question some thought. > > OK. I was expecting at least things like some of the build phases and > most/all of the inputs to be the same, but I haven’t checked. Indeed they both share many inputs and phases. I've actually started this definition from the IceCat one. I'll think on how to merge them back. Probably some inheritance is in need. > Thanks again for all the work! :) --- This patch series adds Tor Browser version 9.5.4 to Guix. Unsurprisignly, building it with '--rounds=2' seems to imply that it is deterministic.