From patchwork Thu Aug 13 12:23:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Othacehe X-Patchwork-Id: 23604 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id B023427BBE4; Thu, 13 Aug 2020 13:25:08 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 5CF7627BBE3 for ; Thu, 13 Aug 2020 13:25:08 +0100 (BST) Received: from localhost ([::1]:49390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6CI7-00015L-RF for patchwork@mira.cbaines.net; Thu, 13 Aug 2020 08:25:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6CI2-000152-4m for guix-patches@gnu.org; Thu, 13 Aug 2020 08:25:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35798) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6CI1-000306-Qo for guix-patches@gnu.org; Thu, 13 Aug 2020 08:25:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k6CI1-0006xB-N8 for guix-patches@gnu.org; Thu, 13 Aug 2020 08:25:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42849] [PATCH 0/3] installer: Run the installation inside a container. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 13 Aug 2020 12:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 42849 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 42849@debbugs.gnu.org Cc: Mathieu Othacehe X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159732144226653 (code B ref -1); Thu, 13 Aug 2020 12:25:01 +0000 Received: (at submit) by debbugs.gnu.org; 13 Aug 2020 12:24:02 +0000 Received: from localhost ([127.0.0.1]:47344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6CH3-0006vp-WE for submit@debbugs.gnu.org; Thu, 13 Aug 2020 08:24:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:51856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6CH0-0006vP-G0 for submit@debbugs.gnu.org; Thu, 13 Aug 2020 08:24:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6CH0-0000yw-B1 for guix-patches@gnu.org; Thu, 13 Aug 2020 08:23:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53201) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6CH0-0002x1-2g for guix-patches@gnu.org; Thu, 13 Aug 2020 08:23:58 -0400 Received: from [2a01:e0a:19b:d9a0:3107:b202:556:bd51] (port=47910 helo=localhost.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k6CGz-0003dO-AG; Thu, 13 Aug 2020 08:23:57 -0400 From: Mathieu Othacehe Date: Thu, 13 Aug 2020 14:23:23 +0200 Message-Id: <20200813122323.262805-1-othacehe@gnu.org> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello, When the store overlay is mounted, other processes such as kmscon, udev and guix-daemon may open files from the store, preventing the underlying install support from being umounted. See: https://lists.gnu.org/archive/html/guix-devel/2018-12/msg00161.html. To avoid this situation, mount the store overlay inside a container, and run the installation from within that container. Thanks, Mathieu Mathieu Othacehe (3): install: Factorize cow-store procedure. linux-container: Add a jail? argument. installer: Run the installation inside a container. gnu/build/install.scm | 44 +++++++++++- gnu/build/linux-container.scm | 20 +++--- gnu/installer/final.scm | 125 +++++++++++++++++----------------- gnu/installer/newt/final.scm | 7 -- gnu/services/base.scm | 60 +++++++++------- gnu/system/install.scm | 52 ++++---------- 6 files changed, 166 insertions(+), 142 deletions(-)