From patchwork Fri Jul 31 14:48:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Othacehe X-Patchwork-Id: 23472 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id F1F5C27BBE3; Fri, 31 Jul 2020 15:49:09 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id BAD5D27BBE1 for ; Fri, 31 Jul 2020 15:49:09 +0100 (BST) Received: from localhost ([::1]:54864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k1WLN-00057B-5o for patchwork@mira.cbaines.net; Fri, 31 Jul 2020 10:49:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k1WLG-00055m-6g for guix-patches@gnu.org; Fri, 31 Jul 2020 10:49:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55087) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k1WLF-00014A-SS for guix-patches@gnu.org; Fri, 31 Jul 2020 10:49:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k1WLF-0006JY-Md for guix-patches@gnu.org; Fri, 31 Jul 2020 10:49:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42634] [PATCH 0/3] Add image-type support. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 31 Jul 2020 14:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 42634 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 42634@debbugs.gnu.org Cc: Mathieu Othacehe X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159620692124237 (code B ref -1); Fri, 31 Jul 2020 14:49:01 +0000 Received: (at submit) by debbugs.gnu.org; 31 Jul 2020 14:48:41 +0000 Received: from localhost ([127.0.0.1]:38400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1WKu-0006Ir-ML for submit@debbugs.gnu.org; Fri, 31 Jul 2020 10:48:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:56312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1WKr-0006Ii-1A for submit@debbugs.gnu.org; Fri, 31 Jul 2020 10:48:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k1WKq-0004gs-Le for guix-patches@gnu.org; Fri, 31 Jul 2020 10:48:36 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:51637) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k1WKo-00012B-U9; Fri, 31 Jul 2020 10:48:36 -0400 Received: by mail-wm1-x329.google.com with SMTP id p14so8778196wmg.1; Fri, 31 Jul 2020 07:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yDcs2mNrjr3GAahU96fY0uw6/PIKrMfx0hVojQ0GlyU=; b=d7rSk/Vm58YWXo/NdwVAxdjG1SQvHVB9epbQOJy0FhY/ALZOvCY6smLpDT++yDsFdQ WoFi1UCed1shKsjdjkFQ2FBhQp3aCjB/SgtzgOAEHLsAVGKTvrVqg/OATKwjZnuFPwbF VfQScyKDNbn2oi78xiNvpqFsZghdGGvQyepmDDE5a/RpYx4Ds6FTc5HvJt7NRwp76jnh GZQm+7Ve/aIF9ELm1o1wR7TJiAZUQMTYV6dltMaroRS4aLm/EpXAIyuvSCgmF4QMr7Sr O3oKKMJdMal9FCbxTMinuc/XqrYfb8L2N965RXmLqujV/RBFblYnUos/Pkrz/EBvEuup Q56g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yDcs2mNrjr3GAahU96fY0uw6/PIKrMfx0hVojQ0GlyU=; b=qijzKlUM1B0Mzm8F98aDPJVsa8WHBf0iOd7nKyxpmoYHbTO6QurU7WPRF76Im/CrbT CLlFCr/iGnEhN5mXAqRjqQ/jiF7JPyGjdV06N0S90efQV/zBc5QckL5yeNpN0QShQFMH Z2oJ/aCYE/Qda/dXWbUBV9nH1HepQRkyaChfUJWBTfBOrg2rL8laDymAI3pbBCkgo6vd HiYmAZIWva8JPIPa+dOC8H5s2JvwcGB3LGKhTos5dp+Tjq8A4yAeZH7gNXhQ4RKeg6TX i2xpsobKNtQjr3xgBzNVraEPwEn+JmyZKNtWkH/bHO9Jb/1kXICk9jAsEU/K0tdsRxfi rvKw== X-Gm-Message-State: AOAM5317vqa8WYqOZbN7uZc9rMIj4wBE5YKfVXtBvyxJCWoLTR8gMB9I NABGEM8vVwcWDGeTD7AEu8UrfVXV X-Google-Smtp-Source: ABdhPJzbjcX+rHGYpUN57Qyi3olJiu6rm3wAV/2yvs3k/nMBZEjk7sUbWHNBpcb6VDOmd9jQQ0LX9Q== X-Received: by 2002:a1c:7d81:: with SMTP id y123mr4011984wmc.87.1596206911935; Fri, 31 Jul 2020 07:48:31 -0700 (PDT) Received: from cervin.home ([2a01:cb18:832e:5f00:c08f:7d21:ea98:a1c5]) by smtp.gmail.com with ESMTPSA id 12sm3123595wme.22.2020.07.31.07.48.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 07:48:31 -0700 (PDT) From: Mathieu Othacehe X-Google-Original-From: Mathieu Othacehe Date: Fri, 31 Jul 2020 16:48:25 +0200 Message-Id: <20200731144825.703211-1-othacehe@gnu.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=m.othacehe@gmail.com; helo=mail-wm1-x329.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello, This is the missing piece for the new image API. It has been previously discussed here[1]. I think this is close to what Ludo suggested and it addresses janneke concerns about composability. The idea is to introduce the concept of "image-type". An image type is a converter from an record to an record. I have created in this serie 4 new image type records: - raw - iso9660 - uncompressed-iso9660 - hurd-raw I also adapted the "guix system" command by removing the "file-system-type" argument and replaced it by the "image-type" argument. The default is still to create a raw disk-image, but one can now call: guix system disk-image -t iso9660 my-config.scm guix system disk-image -t uncompressed-iso9660 my-config.scm guix system disk-image -t hurd-raw my-config.scm and so on. Maybe we should also rename "disk-image" command to "image" that would be somehow more accurate. The only missing bit is the documentation update, as I prefer to wait for this change to be approved first. WDYT? Thanks, Mathieu [1]: https://lists.gnu.org/archive/html/guix-devel/2020-05/msg00417.html Mathieu Othacehe (3): image: Add image-type support. system: image: Add image-type support. scripts: system: Add support for image-type. gnu/image.scm | 29 ++++++++++++++- gnu/system/image.scm | 75 ++++++++++++++++++++++++++++++++++++-- gnu/system/images/hurd.scm | 13 +++++-- guix/scripts/system.scm | 56 +++++++++++++++++----------- 4 files changed, 145 insertions(+), 28 deletions(-)