mbox series

[bug#39329,0/2] Start guix-daemon in SysV.

Message ID 20200128155529.12071-1-dannym@scratchpost.org
Headers show
Series Start guix-daemon in SysV. | expand

Message

Danny Milosavljevic Jan. 28, 2020, 3:55 p.m. UTC 
Danny Milosavljevic (2):
  Add system start-up files for guix-daemon.
  guix-install.sh: Install sysv init script.

 .gitignore                |  1 +
 etc/guix-install.sh       | 11 +++++
 etc/init.d/guix-daemon.in | 88 +++++++++++++++++++++++++++++++++++++++
 nix/local.mk              | 16 ++++++-
 4 files changed, 114 insertions(+), 2 deletions(-)
 create mode 100644 etc/init.d/guix-daemon.in

Comments

Vincent Legoll April 13, 2020, 5:02 p.m. UTC | #1 
Hello,

shouldn't this issue be closed ?
Leo Famulari April 13, 2020, 5:46 p.m. UTC | #2 
On Mon, Apr 13, 2020 at 07:02:46PM +0200, Vincent Legoll wrote:
> Hello,
> 
> shouldn't this issue be closed ?

Yup, done!

Feel free to do this in the future by sending a message to
<NNN-done@debbugs.gnu.org>, where NNN is the bug number.
Danny Milosavljevic April 13, 2020, 6:08 p.m. UTC | #3 
Hi Vincent,

I don't know whether it actually works.

I don't feel great just closing this because of that.

I mean SysV is kinda outdated, so I wouldn't even know how to test it myself.
Would Devuan work?
Or Redhat 6/CentOS 6?

Also, it would be a lot better to just check for
/var/guix/daemon-socket/socket availability and usability--but I have no idea
how to use UNIX domain sockets with bash or with tools that would be available
everywhere.

PID files are awful.
Leo Famulari April 13, 2020, 6:21 p.m. UTC | #4 
On Mon, Apr 13, 2020 at 08:08:29PM +0200, Danny Milosavljevic wrote:
> I don't know whether it actually works.
> 
> I don't feel great just closing this because of that.

Okay, feel free to reopen if you want [0]

> I mean SysV is kinda outdated, so I wouldn't even know how to test it myself.
> Would Devuan work?
> Or Redhat 6/CentOS 6?

I'm sure we will get some bug reports if it doesn't work for them.

> Also, it would be a lot better to just check for
> /var/guix/daemon-socket/socket availability and usability--but I have no idea
> how to use UNIX domain sockets with bash or with tools that would be available
> everywhere.
> 
> PID files are awful.

Yeah... there's a reason everyone switched to systemd.

[0]
https://debbugs.gnu.org/server-control.html
Vincent Legoll April 14, 2020, 10:40 a.m. UTC | #5 
Hello,


I now have tested the patch series in #40601

also on latest devuan-sysvinit x86_64.


On 13/04/2020 20:21, Leo Famulari wrote:
> On Mon, Apr 13, 2020 at 08:08:29PM +0200, Danny Milosavljevic wrote:
>> I don't know whether it actually works.
>>
>> I don't feel great just closing this because of that.
> Okay, feel free to reopen if you want [0]
>
>> I mean SysV is kinda outdated, so I wouldn't even know how to test it myself.
>> Would Devuan work?
>> Or Redhat 6/CentOS 6?
> I'm sure we will get some bug reports if it doesn't work for them.


Here's the first one: ;-)

the sysvinit init.d script relies on "daemonize" which is not

installed by default on devuan.


Would fixing it by checking a second round of REQUIRED_BY_INIT

after checking the init type be the right way ?


Or should I report an issue about that ?


But if daemonize is installed, the sysvinit support works

as expected, and I can run guix commands as for the

other tests I did.


Thanks