From patchwork Tue Jul 16 23:20:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 14694 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id BD5E617233; Wed, 17 Jul 2019 00:21:10 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 6E19B17231 for ; Wed, 17 Jul 2019 00:21:09 +0100 (BST) Received: from localhost ([::1]:52854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnWkt-0005Ie-DC for patchwork@mira.cbaines.net; Tue, 16 Jul 2019 19:21:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58745) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnWkq-0005IY-Pn for guix-patches@gnu.org; Tue, 16 Jul 2019 19:21:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnWkp-0008UY-Rx for guix-patches@gnu.org; Tue, 16 Jul 2019 19:21:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42470) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hnWkp-0008US-Oy for guix-patches@gnu.org; Tue, 16 Jul 2019 19:21:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hnWkp-0003Nx-JA for guix-patches@gnu.org; Tue, 16 Jul 2019 19:21:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#36699] [PATCH 0/4] Strengthen '.guix-channel' file handling Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 16 Jul 2019 23:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36699 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 36699@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.156331923012951 (code B ref -1); Tue, 16 Jul 2019 23:21:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Jul 2019 23:20:30 +0000 Received: from localhost ([127.0.0.1]:51291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnWkH-0003Mp-UV for submit@debbugs.gnu.org; Tue, 16 Jul 2019 19:20:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:52778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnWkD-0003Me-TD for submit@debbugs.gnu.org; Tue, 16 Jul 2019 19:20:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58539) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnWkD-0005Ez-1S for guix-patches@gnu.org; Tue, 16 Jul 2019 19:20:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hnWkC-0008BC-UL; Tue, 16 Jul 2019 19:20:24 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60140 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hnWkC-0002aV-GB; Tue, 16 Jul 2019 19:20:24 -0400 From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Wed, 17 Jul 2019 01:20:16 +0200 Message-Id: <20190716232016.16559-1-ludo@gnu.org> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello Guix, These patches change ‘.guix-channel’ parsing and handling following the same pattern as /read-manifest/profile-manifest and other places where we deal with serialized data structures. The last patch addresses a potential security issue with the ‘directory’ field of ‘.guix-channel’ that hadn’t occurred to me while reviewing it. Thoughts? Ludo’. Ludovic Courtès (4): channels: Strictly check the version of '.guix-channel'. channels: Remove unneeded 'version' field of . channels: Always provide a record. channels: Reject directories with '..' in '.guix-channel' file. guix/channels.scm | 102 +++++++++++++++++++++++++++++---------------- tests/channels.scm | 81 +++++++++++++++++++++++++---------- 2 files changed, 124 insertions(+), 59 deletions(-)