From patchwork Mon Mar 4 16:19:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tobias Geerinckx-Rice X-Patchwork-Id: 1324 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 4293416CFA; Mon, 4 Mar 2019 16:31:37 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id CD3AE16CF8 for ; Mon, 4 Mar 2019 16:31:36 +0000 (GMT) Received: from localhost ([127.0.0.1]:56852 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0qV6-0002Jy-1h for patchwork@mira.cbaines.net; Mon, 04 Mar 2019 11:31:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0qKw-0002rI-1Z for guix-patches@gnu.org; Mon, 04 Mar 2019 11:21:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h0qKs-0005fA-9c for guix-patches@gnu.org; Mon, 04 Mar 2019 11:21:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46562) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h0qKs-0005db-3b for guix-patches@gnu.org; Mon, 04 Mar 2019 11:21:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h0qKr-00083I-QG for guix-patches@gnu.org; Mon, 04 Mar 2019 11:21:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#33026] [PATCH v2 0/2] gnu: Add pdns. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Mar 2019 16:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33026 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 33026@debbugs.gnu.org Received: via spool by 33026-submit@debbugs.gnu.org id=B33026.155171641630865 (code B ref 33026); Mon, 04 Mar 2019 16:21:01 +0000 Received: (at 33026) by debbugs.gnu.org; 4 Mar 2019 16:20:16 +0000 Received: from localhost ([127.0.0.1]:60101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0qK8-00081k-Fd for submit@debbugs.gnu.org; Mon, 04 Mar 2019 11:20:16 -0500 Received: from tobias.gr ([80.241.217.52]:59964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0qK4-00081P-Vf for 33026@debbugs.gnu.org; Mon, 04 Mar 2019 11:20:15 -0500 Received: by tobias.gr (OpenSMTPD) with ESMTP id cc2f4ca4; Mon, 4 Mar 2019 16:20:10 +0000 (UTC) Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id ba551b1c (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 4 Mar 2019 16:20:09 +0000 (UTC) From: Tobias Geerinckx-Rice Date: Mon, 4 Mar 2019 17:19:53 +0100 Message-Id: <20190304161955.12712-1-somebody@not-sent-or-endorsed-by.tobias.gr> X-Mailer: git-send-email 2.20.1 In-Reply-To: <8736t7c6rv.fsf@gnu.org> References: <8736t7c6rv.fsf@gnu.org> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches From: Tobias Geerinckx-Rice Ludo', Thanks for the review and sorry for the late reply. I've think I've addressed all your points below, apart from the last one. I've also added Ruby and Perl to run the full test suite, and tried to make the ‘move-tools’ phase a bit more straightforward. Ludovic Courtès wrote: > What about “powerdns” then? > > Tobias Geerinckx-Rice skribis: >> [blah blah blah blah] > > Alright, go for “pdns” then! Sorry for asking. ;-) You'll never make that mistake again. > We could do that indeed! Well the backend itself may be free, but > it's useless without the non-free piece of software, so it makes > sense to remove it (as long as the build system allows it.) OK. > I think you can avoid @dfn here as well. :-) OK. Replaced with @acronym if that's all right. > A few questions: > > • Are things under ext/ simply bundled libraries? If so, do you think > there’s something we could/should do about them? There are 3 libraries under ext/: - json11 (https://github.com/dropbox/json11) is a one-C++-file library without own build system, intended for bundling; - luawrapper is just a lone header file (LuaContext.hpp); - yahttp (https://github.com/cmouse/yahttp) is most like a real package, and while the README instructs developers to just plonk its headers in with their own and ship it that way, I was able to package & use it. > • I suppose we don’t build and thus don’t care about the license of > modules/oraclebackend, do we? :-) Out it goes. > • The license of m4/* doesn’t matter for the combined work; I’d just > remove it. Done. > • GPLv2-only code cannot be combined with GPLv3+ code. Is it really > what’s happening? I think so: $ head pdns/ssqlite3.cc /* SQLite backend for PowerDNS * Copyright (C) 2003, Michel Stol * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 * as published by the Free Software Foundation. * * Additionally, the license of this program contains a special * exception which allows to distribute the program in binary form when * it is linked against OpenSSL. Is this really a deal-breaker? We could disable the sqlite and LDAP back ends (hardly ideal) but pdns/tcpreceiver.cc is linked into the core pdns_server… Uh oh, T G-R Tobias Geerinckx-Rice (2): gnu: Add yahttp. gnu: Add pdns. gnu/packages/dns.scm | 176 +++++++++++++++++++++++++++++++++++++++++++ gnu/packages/web.scm | 42 +++++++++++ 2 files changed, 218 insertions(+)