mbox series

[bug#33955,0/6] KDE: Enable more tests.

Message ID 20190102184521.8001-1-h.goebel@crazy-compilers.com
Headers show
Series KDE: Enable more tests. | expand

Message

Hartmut Goebel Jan. 2, 2019, 6:45 p.m. UTC 
After applying patches from #33820:
<http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33820> some more tests
pass. Activate them.

Hartmut Goebel (6):
  gnu: kcoreaddons: Enable test-suite.
  gnu: kirigami: Enable test-suite.
  gnu: kpackage: Enable test-suite.
  gnu: kemoticons: Enable test-suite.
  gnu: knewstuff: Enable test-suite.
  gnu: kwindowsystem: Enable test-suite.

 gnu/packages/kde-frameworks.scm | 91 ++++++++++++++++++++---------------------
 1 file changed, 45 insertions(+), 46 deletions(-)

Comments

Meiyo Peng Jan. 3, 2019, 1:59 a.m. UTC | #1 
Hi Hartmut,

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> After applying patches from #33820:
> <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33820> some more tests
> pass. Activate them.
>
> Hartmut Goebel (6):
>   gnu: kcoreaddons: Enable test-suite.
>   gnu: kirigami: Enable test-suite.
>   gnu: kpackage: Enable test-suite.
>   gnu: kemoticons: Enable test-suite.
>   gnu: knewstuff: Enable test-suite.
>   gnu: kwindowsystem: Enable test-suite.
>
>  gnu/packages/kde-frameworks.scm | 91 ++++++++++++++++++++---------------------
>  1 file changed, 45 insertions(+), 46 deletions(-)

Would you mind having a look at patch #33951:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33951

I found that bug while investigating kwindowsystem. That bug caused
kwindowsystem installed plugins into PREFIX/lib/plugins rather than
PREFIX/lib/qt5/plugins.

Thanks.

--
Meiyo Peng
https://www.pengmeiyu.com/
Hartmut Goebel Jan. 3, 2019, 7:40 p.m. UTC | #2 
Hi Meiyo,
> Would you mind having a look at patch #33951: 

Thanks for pointing me to this.

This mainly is a duplicate of
<https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33812#5> which I files a
few days earlier.

The difference is that #33951 does not care about the Android
special-case, while #33812 tries to do and adds a respective comment. So
IMHO #33812 is to be preferred. WDYT?
Ludovic Courtès Jan. 14, 2019, 9:50 p.m. UTC | #3 
Hello Hartmut,

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> After applying patches from #33820:
> <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33820> some more tests
> pass. Activate them.
>
> Hartmut Goebel (6):
>   gnu: kcoreaddons: Enable test-suite.
>   gnu: kirigami: Enable test-suite.
>   gnu: kpackage: Enable test-suite.
>   gnu: kemoticons: Enable test-suite.
>   gnu: knewstuff: Enable test-suite.
>   gnu: kwindowsystem: Enable test-suite.

The patches LGTM, and it’s a great initiative!

Thanks,
Ludo’.
Hartmut Goebel Jan. 16, 2019, 11:20 p.m. UTC | #4 
Applied as 2615ee95204fbd5cbc73d236ecbd24a4fbdc5de5
Thanks for the review.