mbox series

[bug#33698,v2,0/2] Update emacs-cider

Message ID 20181211065147.18404-1-arunisaac@systemreboot.net
Headers show
Series Update emacs-cider | expand

Message

Arun Isaac Dec. 11, 2018, 6:51 a.m. UTC 
I've made several modifications to your patches. Most notably, I have changed
the synopsis and description of emacs-sesman. I have switched both
emacs-sesman and emacs-cider to using git-fetch. We do this now because
auto-generated github tarballs are unstable and cause hash mismatch errors. I
also enabled tests for emacs-sesman and made a few other minor stylistic
changes.

Let me know if the updated patches are fine. If they are, I will push them to
master.

Mathieu Lirzin (2):
  gnu: Add emacs-sesman.
  gnu: emacs-cider: Update to 0.18.0.

 gnu/packages/emacs.scm | 50 ++++++++++++++++++++++++++++++++----------
 1 file changed, 39 insertions(+), 11 deletions(-)

Comments

Mathieu Lirzin Dec. 11, 2018, 8:51 a.m. UTC | #1 
Hello Arun,

Arun Isaac <arunisaac@systemreboot.net> writes:

> I've made several modifications to your patches. Most notably, I have changed
> the synopsis and description of emacs-sesman. I have switched both
> emacs-sesman and emacs-cider to using git-fetch. We do this now because
> auto-generated github tarballs are unstable and cause hash mismatch errors. I
> also enabled tests for emacs-sesman and made a few other minor stylistic
> changes.
>
> Let me know if the updated patches are fine. If they are, I will push them to
> master.

Excellent, thanks for polishing the patches and letting me know about
the ‘git-fetch’ policy change.  I saw various commits in the Git log
doing such changes without understanding the goal since commit messages
don't include any context/rationale.

Please go ahead.
Arun Isaac Dec. 11, 2018, 5:44 p.m. UTC | #2 
Pushed to master. Thanks! :-)