mbox series

[bug#62473,0/4] OpenFoam update to version 10

Message ID 010201871fb2f5ee-836441b8-36b9-47f9-b8de-3bd1eddf2d6e-000000@eu-west-1.amazonses.com
Headers show
Series OpenFoam update to version 10 | expand

Message

reza March 26, 2023, 8:53 p.m. UTC 
This is a patch series updating OpenFoam to version 10. This series gets rid
of the OpenFoam patch file and also adds the OpenFoam build from openfoam.com
(therefore the distinction with openfoam-org and openfoam-com).  Some effort
was put forward to build the two packages with the same instructions as the
sources are still very similar.  There is a strange issue that inside the
build of openfoam-com which inherits from openfoam-org, the version of
openfoam-org is used. Maybe this is a bug? Furthermore the dependencies and
build instructions have been updated to build the paraview plugin for OpenFoam
and the OpenFoam tests (only available for openfoam-org).

Reza Housseini (4):
  gnu: Add ftest.
  gnu: utfcpp: Update to 3.2.3.
  gnu: Add openfoam-org.
  gnu: Add openfoam-com.

 gnu/local.mk                                  |   2 +-
 gnu/packages/check.scm                        |  34 ++
 .../patches/openfoam-4.1-cleanup.patch        | 243 ----------
 gnu/packages/simulation.scm                   | 432 ++++++++++++------
 gnu/packages/textutils.scm                    |  35 +-
 5 files changed, 346 insertions(+), 400 deletions(-)
 delete mode 100644 gnu/packages/patches/openfoam-4.1-cleanup.patch


base-commit: de84b24613afa4020f3f0553dad8e39a78d1f92c
-- 
2.39.2

Comments

reza March 27, 2023, 4:51 p.m. UTC | #1 
This would also resolve [1].

[1] https://issues.guix.gnu.org/51071
reza Aug. 10, 2023, 3:40 p.m. UTC | #2 
Hi Ludo,

Thank you very much! Sorry for not following up on your review feedback, 
this was not intentional.
I asked on the mailing list about the circular dependency issue but got 
no reply and with my basic knowledge of guile I was basically lost.
Also the issue with line endings has me still scratching my head. I 
prepared the patch on a guix system with git send-mail I searched the 
internet for the issue but could not figure out why I had dos line endings?
The rest of the problems are really on my side and I apologize for it.

I'm in the process of preparing a follow up patch for openfoam, first to 
bump the version to 11 and second there is an issue with the naming 
convention of the share/OpenFOAM folder. I hope I can sort out the line 
ending issue, maybe you have an idea?

Best,
Reza
Hartmut Goebel Feb. 15, 2024, 9:38 a.m. UTC | #3 
This seems to be merged, see https://issues.guix.gnu.org/62473#29

  Can it be closed?
reza Feb. 16, 2024, 9:12 p.m. UTC | #4 
>   Can it be closed?

Yes this can be closed. There is already an update to version 11 here: 
https://issues.guix.gnu.org/66262
reza Feb. 17, 2024, 10:01 a.m. UTC | #5 
>   Can it be closed?

Yes this can be closed. There is already an update to version 11 here: 
https://issues.guix.gnu.org/66262