| Message ID | 3e89f7f30708b5702e1283534348cfc486ec0c61.1684060546.git.liliana.prikler@gmail.com |
|---|---|
| State | New |
| Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 4F22C27BBE9; Sun, 14 May 2023 11:40:14 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 4295D27BBE2 for <patchwork@mira.cbaines.net>; Sun, 14 May 2023 11:40:13 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1py993-0001Df-V0; Sun, 14 May 2023 06:40:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1py991-0001CW-Pv for guix-patches@gnu.org; Sun, 14 May 2023 06:40:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1py991-0002M4-H0 for guix-patches@gnu.org; Sun, 14 May 2023 06:40:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1py991-00043M-Ce; Sun, 14 May 2023 06:40:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63499] [PATCH gnome-team 3/3] gnu: gtksourceview: Fix build. Resent-From: Liliana Marie Prikler <liliana.prikler@gmail.com> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: maxim.cournoyer@gmail.com, rg@raghavgururajan.name, liliana.prikler@gmail.com, guix-patches@gnu.org Resent-Date: Sun, 14 May 2023 10:40:03 +0000 Resent-Message-ID: <handler.63499.B63499.168406078515528@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63499 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63499@debbugs.gnu.org Cc: maxim.cournoyer@gmail.com, rg@raghavgururajan.name, liliana.prikler@gmail.com X-Debbugs-Original-Xcc: maxim.cournoyer@gmail.com, rg@raghavgururajan.name, liliana.prikler@gmail.com Received: via spool by 63499-submit@debbugs.gnu.org id=B63499.168406078515528 (code B ref 63499); Sun, 14 May 2023 10:40:03 +0000 Received: (at 63499) by debbugs.gnu.org; 14 May 2023 10:39:45 +0000 Received: from localhost ([127.0.0.1]:40397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1py98i-00042O-Qm for submit@debbugs.gnu.org; Sun, 14 May 2023 06:39:45 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:59609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@gmail.com>) id 1py98d-00041f-K6 for 63499@debbugs.gnu.org; Sun, 14 May 2023 06:39:39 -0400 Received: by mail-ej1-f67.google.com with SMTP id a640c23a62f3a-965e93f915aso2041872766b.2 for <63499@debbugs.gnu.org>; Sun, 14 May 2023 03:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684060774; x=1686652774; h=to:content-transfer-encoding:mime-version:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=qvbwKf9QArTqkYqztog8XDr50xPem66QyAI6Dqbxfr0=; b=LrxtDaKRHMOFYo17Pw8YfE/gD8IGC4iPcnlEM3Kqvy9nnBEZJyx4K4ODEBQax8l/c5 uA9EHCOgvDKe2wnQz9goHhrZWyAjgopFB6XcSoBOnkY3y5C1JHsxlIyOzzCfcmaX0Ptj 2qHU5FvpMpc1V39pzIt8So3SJ41d2+yMdYj24d9dmYM5DnvFS05FakGnqWn6tGIaz1x+ eXPM28u4CnNp8RWQBtpNRXY1bqOTZwVZGeFNahemd6PptqnxmgCiXnQKuKNkhRNIpdvX Uyk1XdUYPHjZ86EzQUmAeEXGlYWr+Nd7u5n/0wnbXq6l5QtIsop5jgm6foj40OrlpY+d FeRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684060774; x=1686652774; h=to:content-transfer-encoding:mime-version:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qvbwKf9QArTqkYqztog8XDr50xPem66QyAI6Dqbxfr0=; b=J05P6hAb4nzS4fQ0bMm2EU8Z0ckz8WFvDVn9V1CFafzmyxsUQGlf7CyybwvzXyKbI1 tZSvYxxiifrTtD3cL/emGx7NuQDZgcdrtWuTBka9mt6PiUh4vc15RRkmLaArcALy5rjV iAs9Xwx8fp5Fsuk/z9rtwq18AV1L3zmX5o0thzhO7Fkxs3AltvFy0MU5Z4CQdop5mvP1 8o01ud6Z0G8ZqJ7K/1ckUM8v8XFcuyboAV165ig96OyLuXy+SVyaUY/Ring6I5ZJ0TMv 3mDRN5DCbpnxS51ABFO5ObJxNaV1H2nzwTUkIXPGMz3MW7QBm3gcRw9yu8mfKNn6qetM NxqQ== X-Gm-Message-State: AC+VfDww1IMK+d2L3Bw8HlCZYl2gKdVFpy3sQFupRxZx94RVxuzMCsl6 UsvO6sQG5n3vqCnMXbZRgF1p4DKnhVpH+Q== X-Google-Smtp-Source: ACHHUZ4IeTAZ6tJoDkVAKXSc0VCJCPCGhhO8tzxOYrOFqvXf0OReeVrgCPA0MvTIBSjpHxEjw8i49w== X-Received: by 2002:a17:907:7fa3:b0:965:6075:d100 with SMTP id qk35-20020a1709077fa300b009656075d100mr32779121ejc.39.1684060773828; Sun, 14 May 2023 03:39:33 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id n10-20020a17090673ca00b0096a6be0b66dsm4628527ejl.208.2023.05.14.03.39.33 for <63499@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 May 2023 03:39:33 -0700 (PDT) Message-Id: <3e89f7f30708b5702e1283534348cfc486ec0c61.1684060546.git.liliana.prikler@gmail.com> In-Reply-To: <cover.1684060546.git.liliana.prikler@gmail.com> References: <cover.1684060546.git.liliana.prikler@gmail.com> From: Liliana Marie Prikler <liliana.prikler@gmail.com> Date: Sat, 13 May 2023 22:27:57 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
| Series |
To GTK and beyond
|
|
Commit Message
Liliana Marie Prikler
May 13, 2023, 8:27 p.m. UTC
* gnu/packages/gtk.scm (gtksourceview)[#:phases]<pre-check>: Set “GDK_BACKEND” and “GTK_A11Y”. --- gnu/packages/gtk.scm | 3 +++ 1 file changed, 3 insertions(+)
Comments
Hello, Liliana Marie Prikler <liliana.prikler@gmail.com> writes: > * gnu/packages/gtk.scm (gtksourceview)[#:phases]<pre-check>: Set “GDK_BACKEND” > and “GTK_A11Y”. > --- > gnu/packages/gtk.scm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm > index de45eb3870..7d76610293 100644 > --- a/gnu/packages/gtk.scm > +++ b/gnu/packages/gtk.scm > @@ -616,6 +616,9 @@ (define-public gtksourceview > ;; Tests require a running X server. > (system (string-append Xvfb " :1 &")) > (setenv "DISPLAY" ":1") > + ;; For GTK Nitpick: Add a full stop (period) for standalone comments. Perhaps expound how these environment variables are useful to set ('For GTK' leaves me wondering, as 'gtksourceview' already seems GTK-focused). > + (setenv "GDK_BACKEND" "x11") > + (setenv "GTK_A11Y" "none") > ;; For the missing /etc/machine-id. > (setenv "DBUS_FATAL_WARNINGS" "0"))))))) > (native-inputs Otherwise, LGTM.
Am Montag, dem 15.05.2023 um 09:49 -0400 schrieb Maxim Cournoyer: > Hello, > > Liliana Marie Prikler <liliana.prikler@gmail.com> writes: > > > * gnu/packages/gtk.scm (gtksourceview)[#:phases]<pre-check>: Set > > “GDK_BACKEND” > > and “GTK_A11Y”. > > --- > > gnu/packages/gtk.scm | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm > > index de45eb3870..7d76610293 100644 > > --- a/gnu/packages/gtk.scm > > +++ b/gnu/packages/gtk.scm > > @@ -616,6 +616,9 @@ (define-public gtksourceview > > ;; Tests require a running X server. > > (system (string-append Xvfb " :1 &")) > > (setenv "DISPLAY" ":1") > > + ;; For GTK > > Nitpick: Add a full stop (period) for standalone comments. Perhaps > expound how these environment variables are useful to set ('For GTK' > leaves me wondering, as 'gtksourceview' already seems GTK-focused). Full disclosure, I don't quite understand what's wrong here myself, but with the upgrade to GTK 4.10, tests fail - due to GDK_BACKEND not being said for ??? reason - due to GTK_A11Y because GTK tries to spawn dbus and fails to connect. > If there's a better wording for that, I'm all ears :)
Hi, Liliana Marie Prikler <liliana.prikler@gmail.com> writes: > Am Montag, dem 15.05.2023 um 09:49 -0400 schrieb Maxim Cournoyer: >> Hello, >> >> Liliana Marie Prikler <liliana.prikler@gmail.com> writes: >> >> > * gnu/packages/gtk.scm (gtksourceview)[#:phases]<pre-check>: Set >> > “GDK_BACKEND” >> > and “GTK_A11Y”. >> > --- >> > gnu/packages/gtk.scm | 3 +++ >> > 1 file changed, 3 insertions(+) >> > >> > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm >> > index de45eb3870..7d76610293 100644 >> > --- a/gnu/packages/gtk.scm >> > +++ b/gnu/packages/gtk.scm >> > @@ -616,6 +616,9 @@ (define-public gtksourceview >> > ;; Tests require a running X server. >> > (system (string-append Xvfb " :1 &")) >> > (setenv "DISPLAY" ":1") >> > + ;; For GTK >> >> Nitpick: Add a full stop (period) for standalone comments. Perhaps >> expound how these environment variables are useful to set ('For GTK' >> leaves me wondering, as 'gtksourceview' already seems GTK-focused). > Full disclosure, I don't quite understand what's wrong here myself, but > with the upgrade to GTK 4.10, tests fail > - due to GDK_BACKEND not being said for ??? reason > - due to GTK_A11Y because GTK tries to spawn dbus and fails to connect. > >> > If there's a better wording for that, I'm all ears :) Perhaps above setenv "GTK_BACKEND" mention "XXX: To avoid failures in tests." and then above GTK_A11Y mention "Otherwise, GTK tries to spawn D-Bus and fails to connect." This captures everything you know; I think it's an improvement.
Am Montag, dem 15.05.2023 um 15:44 -0400 schrieb Maxim Cournoyer: > Hi, > > Liliana Marie Prikler <liliana.prikler@gmail.com> writes: > > > Am Montag, dem 15.05.2023 um 09:49 -0400 schrieb Maxim Cournoyer: > > > Hello, > > > > > > Liliana Marie Prikler <liliana.prikler@gmail.com> writes: > > > > > > > * gnu/packages/gtk.scm (gtksourceview)[#:phases]<pre-check>: > > > > Set > > > > “GDK_BACKEND” > > > > and “GTK_A11Y”. > > > > --- > > > > gnu/packages/gtk.scm | 3 +++ > > > > 1 file changed, 3 insertions(+) > > > > > > > > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm > > > > index de45eb3870..7d76610293 100644 > > > > --- a/gnu/packages/gtk.scm > > > > +++ b/gnu/packages/gtk.scm > > > > @@ -616,6 +616,9 @@ (define-public gtksourceview > > > > ;; Tests require a running X server. > > > > (system (string-append Xvfb " :1 &")) > > > > (setenv "DISPLAY" ":1") > > > > + ;; For GTK > > > > > > Nitpick: Add a full stop (period) for standalone comments. > > > Perhaps > > > expound how these environment variables are useful to set ('For > > > GTK' > > > leaves me wondering, as 'gtksourceview' already seems GTK- > > > focused). > > Full disclosure, I don't quite understand what's wrong here myself, > > but > > with the upgrade to GTK 4.10, tests fail > > - due to GDK_BACKEND not being said for ??? reason > > - due to GTK_A11Y because GTK tries to spawn dbus and fails to > > connect. > > > > > > > If there's a better wording for that, I'm all ears :) > > Perhaps above setenv "GTK_BACKEND" mention "XXX: To avoid failures in > tests." and then above GTK_A11Y mention "Otherwise, GTK tries to > spawn D-Bus and fails to connect." > > This captures everything you know; I think it's an improvement. Reworded a little and pushed with GStreamer 1.22.3. Cheers
diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm index de45eb3870..7d76610293 100644 --- a/gnu/packages/gtk.scm +++ b/gnu/packages/gtk.scm @@ -616,6 +616,9 @@ (define-public gtksourceview ;; Tests require a running X server. (system (string-append Xvfb " :1 &")) (setenv "DISPLAY" ":1") + ;; For GTK + (setenv "GDK_BACKEND" "x11") + (setenv "GTK_A11Y" "none") ;; For the missing /etc/machine-id. (setenv "DBUS_FATAL_WARNINGS" "0"))))))) (native-inputs