diff mbox series

[bug#63091,v2,2/2] gnu: sssd: Fix build

Message ID b6cb28fab9f30744fa6d411096291901c9e824e8.1682690616.git.bjc@spork.org
State New
Headers
Series [bug#63091,v2,1/2] gnu: sssd: Fix failing tests by using samba/pinned input |

Commit Message

brian cully April 28, 2023, 2:03 p.m. UTC 
Use python-toolchain explicitly in order to pull in our patched ZipFile
creation which ignores timestamp.

* gnu/packages/sssd.scm (sssd) [native-inputs]: Add python-toolchain.
---
 gnu/packages/sssd.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ludovic Courtès April 28, 2023, 7:02 p.m. UTC | #1 
Brian Cully <bjc@spork.org> skribis:

> Use python-toolchain explicitly in order to pull in our patched ZipFile
> creation which ignores timestamp.
>
> * gnu/packages/sssd.scm (sssd) [native-inputs]: Add python-toolchain.

Hi!  Apparently that’s not working; I get:

--8<---------------cut here---------------start------------->8---
  File "/gnu/store/06cjgrygh79bxbsr0x44ryx1wy1pwvh4-python-setuptools-67.6.1/lib/python3.10/site-packages/setuptools/command/bdist_egg.py", line 444, in visit
    z.write(path, p)
  File "/gnu/store/dy3xh053ahkhrp2jamggq8cpsyvp8mg0-python-3.10.7/lib/python3.10/zipfile.py", line 1739, in write
    zinfo = ZipInfo.from_file(filename, arcname,
  File "/gnu/store/dy3xh053ahkhrp2jamggq8cpsyvp8mg0-python-3.10.7/lib/python3.10/zipfile.py", line 518, in from_file
    zinfo = cls(arcname, date_time)
  File "/gnu/store/dy3xh053ahkhrp2jamggq8cpsyvp8mg0-python-3.10.7/lib/python3.10/zipfile.py", line 362, in __init__
    raise ValueError('ZIP does not support timestamps before 1980')
ValueError: ZIP does not support timestamps before 1980
make[4]: *** [Makefile:43890: install-exec-hook] Error 1
make[4]: Leaving directory '/tmp/guix-build-sssd-2.8.1.drv-0/source'
make[3]: *** [Makefile:41784: install-exec-am] Error 2
make[3]: Leaving directory '/tmp/guix-build-sssd-2.8.1.drv-0/source'
make[2]: *** [Makefile:39905: install-am] Error 2
make[2]: Leaving directory '/tmp/guix-build-sssd-2.8.1.drv-0/source'
make[1]: *** [Makefile:38753: install-recursive] Error 1
make[1]: Leaving directory '/tmp/guix-build-sssd-2.8.1.drv-0/source'
make: *** [Makefile:39898: install] Error 2
error: in phase 'install': uncaught exception:
%exception #<&invoke-error program: "make" arguments: ("install" "CFLAGS=-DRENEWAL_PROG_PATH=\\\"/gnu/store/6zgxgnsx65kqcmhi6kxjhcmh53pjc9hb-adcli-0.9.2/sbin/adcli\\\"" "DOCBOOK_XSLT=/gnu/store/ljajixj3z0pc98lvk4rfr7lydq4mwa16-docbook-xsl-1.79.2-0.fe16c90/xml/xsl/docbook-xsl-1.79.2-0.fe16c90/manpages/docbook.xsl" "XMLLINT_FLAGS = --catalogs --nonet --noent --xinclude --noout") exit-status: 2 term-signal: #f stop-signal: #f> 
phase `install' failed after 22.8 seconds
command "make" "install" "CFLAGS=-DRENEWAL_PROG_PATH=\\\"/gnu/store/6zgxgnsx65kqcmhi6kxjhcmh53pjc9hb-adcli-0.9.2/sbin/adcli\\\"" "DOCBOOK_XSLT=/gnu/store/ljajixj3z0pc98lvk4rfr7lydq4mwa16-docbook-xsl-1.79.2-0.fe16c90/xml/xsl/docbook-xsl-1.79.2-0.fe16c90/manpages/docbook.xsl" "XMLLINT_FLAGS = --catalogs --nonet --noent --xinclude --noout" failed with status 2
--8<---------------cut here---------------end--------------->8---

Could you take a look?

(This is on top of aecc6e70587f8412cbbb9b2c13141de4f534518e.)

Thanks,
Ludo’.
brian cully April 28, 2023, 7:14 p.m. UTC | #2 
Ludovic Courtès <ludo@gnu.org> writes:
> Hi!  Apparently that’s not working; I get:
>
>   File 
>   "/gnu/store/06cjgrygh79bxbsr0x44ryx1wy1pwvh4-python-setuptools-67.6.1/lib/python3.10/site-packages/setuptools/command/bdist_egg.py", 
>   line 444, in visit
>     z.write(path, p)
>   File 
>   "/gnu/store/dy3xh053ahkhrp2jamggq8cpsyvp8mg0-python-3.10.7/lib/python3.10/zipfile.py", 
>   line 1739, in write
>     zinfo = ZipInfo.from_file(filename, arcname,
>   File 
>   "/gnu/store/dy3xh053ahkhrp2jamggq8cpsyvp8mg0-python-3.10.7/lib/python3.10/zipfile.py", 
>   line 518, in from_file
>     zinfo = cls(arcname, date_time)
>   File 
>   "/gnu/store/dy3xh053ahkhrp2jamggq8cpsyvp8mg0-python-3.10.7/lib/python3.10/zipfile.py", 
>   line 362, in __init__
>     raise ValueError('ZIP does not support timestamps before 
>     1980')

This is the same ZipFile error as in #63044, so that has to be 
fixed first. I mentioned that eariler in this report, but probably 
should have re-iterated it here. #63149 is similar in this regard.

-bjc
diff mbox series

Patch

diff --git a/gnu/packages/sssd.scm b/gnu/packages/sssd.scm
index 4e585a62de..47f5d1e559 100644
--- a/gnu/packages/sssd.scm
+++ b/gnu/packages/sssd.scm
@@ -266,7 +266,7 @@  (define-public sssd
            p11-kit ; for PKCS#11 support
            pcre2
            popt
-           python
+           python ; for wrap-program phase
            samba/pinned
            talloc
            tdb
@@ -286,6 +286,7 @@  (define-public sssd
            libxslt
            openssh ; for tests
            pkg-config
+           python-toolchain
            po4a
            softhsm ; for tests
            `(,util-linux "lib"))) ; for uuid.h, reqired for KCM