[bug#33985] Update GnuCash to v3.4 and other improvements

Message ID 87pntbpvmm.fsf@apteryx.i-did-not-set--mail-host-address--so-tickle-me
State Accepted
Headers show
Series [bug#33985] Update GnuCash to v3.4 and other improvements | expand

Checks

Context Check Description
cbaines/applying patch success Successfully applied

Commit Message

Maxim Cournoyer Jan. 5, 2019, 4:37 a.m. UTC
Hello,

This patch series improve our GnuCash package so that it relies less on
patches (which are harder to maintain), updates it to the latest 3.4
version, as well as clarify how the documentation output can be used.

Thanks,

Maxim

Comments

Ludovic Courtès Jan. 21, 2019, 9:49 p.m. UTC | #1
Hi Maxim,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> This patch series improve our GnuCash package so that it relies less on
> patches (which are harder to maintain), updates it to the latest 3.4
> version, as well as clarify how the documentation output can be used.

All five patches LGTM, thank you!

Ludo’.

PS: To all the committers reading this: please consider reviewing your
    fellow hacker patches!  :-)
Maxim Cournoyer Jan. 23, 2019, 12:53 p.m. UTC | #2
Hello!

Ludovic Courtès <ludo@gnu.org> writes:

> Hi Maxim,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> This patch series improve our GnuCash package so that it relies less on
>> patches (which are harder to maintain), updates it to the latest 3.4
>> version, as well as clarify how the documentation output can be used.
>
> All five patches LGTM, thank you!

Pushed to master, thanks for the review!

> Ludo’.
>
> PS: To all the committers reading this: please consider reviewing your
>     fellow hacker patches!  :-)

I hear you! :-)

Have a nice day,

Maxim

Patch

From e65ecdc8e0f1ebd9c05ed9f06d623947cac5f9d9 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Fri, 4 Jan 2019 23:11:15 -0500
Subject: [PATCH 5/5] gnu: gnucash: Add information about how to use the
 documentation.

It was not obvious that another application, Yelp, needed to be installed to
so that opening the help of GnuCash from within the application would work.

Fixes issue #33960 (see: https://issues.guix.info/issue/33960).

* gnu/packages/gnucash.scm (gnucash)[description]: Explain how to enable the
  documentation.
---
 gnu/packages/gnucash.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnucash.scm b/gnu/packages/gnucash.scm
index 057ca709d..b22045eb8 100644
--- a/gnu/packages/gnucash.scm
+++ b/gnu/packages/gnucash.scm
@@ -188,7 +188,10 @@ 
 It can be used to track bank accounts, stocks, income and expenses, based on
 the double-entry accounting practice.  It includes support for QIF/OFX/HBCI
 import and transaction matching.  It also automates several tasks, such as
-financial calculations or scheduled transactions.")
+financial calculations or scheduled transactions.
+
+To make the GnuCash documentation available, its doc output must be
+installed as well as Yelp, the Gnome help browser.")
     (license license:gpl3+)))
 
 ;; This package is not public, since we use it to build the "doc" output of
-- 
2.20.1