diff mbox series

[bug#54362] gnu: cl-find-port: Update to 20190601.

Message ID 20220312231808.29254-1-jgart@dismail.de
State New
Headers
Series [bug#54362] gnu: cl-find-port: Update to 20190601. |

Commit Message

jgart March 12, 2022, 11:18 p.m. UTC 
* gnu/packages/lisp-xyz.scm (cl-find-port): Update to 20190601.
[version]: Use git-version function with date of commit.
---
 gnu/packages/lisp-xyz.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Tobias Geerinckx-Rice March 12, 2022, 11:27 p.m. UTC | #1 
On 12 March 2022 23:18:08 UTC, jgart via Guix-patches via <guix-patches@gnu.org> wrote:
> (define-public sbcl-find-port
>-  (let ((commit "00c96a25af93a0f8681d34ec548861f2d7485478")
>-        (revision "1"))
>+  (let ((commit "811727f88d7f000623bf92fdb0e64678a7112a28")
>+        (revision "2"))

LGTM.

>-      (version "0.1")
>+      (version (git-version "20190601" revision commit))

Err... LNSGTM.  Why?  I can't find a justification for this upstream.

If there is one, please always add it as comment.

Otherwise, it should remain 0.1 but (indeed) with git-version which should have been there from the start.
Hi jgart,

Thanks!

T G-R

Sent on the go.  Excuse or enjoy my brevity.
jgart March 13, 2022, 1:33 a.m. UTC | #2 
On Sat, 12 Mar 2022 23:27:09 +0000 Tobias Geerinckx-Rice <me@tobias.gr> wrote:
> If there is one, please always add it as comment.

Hi Tobias!

I'll make sure to add a comment in the future for packages that don't
have version numbers.

It seems like a fairly common practice in the common lisp community to
not make version releases though.

Do you need me to send a v2 with the comment?

> Otherwise, it should remain 0.1 but (indeed) with git-version which should have been there from the start.
> Hi jgart,

There's no mention of 0.1 in the current commit. Is it a Guix convention
to use 0.1 when we don't know the version of the package and only have
a particular commit?

all best,

jgart
Guillaume Le Vaillant March 13, 2022, 8:37 a.m. UTC | #3 
jgart via Guix-patches via <guix-patches@gnu.org> skribis:

> There's no mention of 0.1 in the current commit. Is it a Guix convention
> to use 0.1 when we don't know the version of the package and only have
> a particular commit?

Hi,

In the "find-port.asd" file, the find-port system definition has a field
indicating ":version 0.1".
Raghav Gururajan March 13, 2022, 8:53 a.m. UTC | #4 
I agree with T G-R. It should have been git-version from the beginning. 
Also, for packages with no releases, we usually start version and 
revision with "0", and increment revision by one for every update. Not 
sure why the version was started with "0.1", but lets keep it that way 
for now. :)

Pushed as 1a36fb51a8..f69727278b to master.
diff mbox series

Patch

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index fc18742e3c..53aa9c6ae5 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -5120,12 +5120,12 @@  (define-public cl-verbose
   (sbcl-package->cl-source-package sbcl-verbose))
 
 (define-public sbcl-find-port
-  (let ((commit "00c96a25af93a0f8681d34ec548861f2d7485478")
-        (revision "1"))
+  (let ((commit "811727f88d7f000623bf92fdb0e64678a7112a28")
+        (revision "2"))
     (package
       (name "sbcl-find-port")
       (build-system asdf-build-system/sbcl)
-      (version "0.1")
+      (version (git-version "20190601" revision commit))
       (home-page "https://github.com/eudoxia0/find-port")
       (source
        (origin
@@ -5136,7 +5136,7 @@  (define-public sbcl-find-port
          (file-name (git-file-name name version))
          (sha256
           (base32
-           "0d6dzbb45jh0rx90wgs6v020k2xa87mvzas3mvfzvivjvqqlpryq"))))
+           "1fw6q7d2bxxb7fqk548ylq8mx4sz95yc0q5h0rwd0mnqjrbwbari"))))
       (native-inputs
        (list sbcl-fiveam))
       (inputs