[bug#59648] gnu: icedove: Use native notifications when available
Commit Message
* gnu/packages/gnuzilla.scm (icedove)[phases]{wrap-program}: Add libnotify
to LD_LIBRARY_PATH.
---
gnu/packages/gnuzilla.scm | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
Comments
Hi,
SeerLite <seerlite@nixnet.email> skribis:
> * gnu/packages/gnuzilla.scm (icedove)[phases]{wrap-program}: Add libnotify
> to LD_LIBRARY_PATH.
Jonathan: this one’s for you. :-)
Ludo’.
Hello SeerNet,
hm, when I enable notifications in Thunderbird I get notifications from
my sway desktop:
I just enabled it via Settings -> General -> Incoming Messages -> When
new messages arrive -> [x] Show an alert.
This is without your patch applied...
~Jonathan
Hi! Sorry, I didn't receive this response when it was sent, and it
wasn't in my inbox.
> Hello SeerNet,
It's SeerLite :s
> hm, when I enable notifications in Thunderbird I get notifications from
> my sway desktop:
> I just enabled it via Settings -> General -> Incoming Messages -> When
> new messages arrive -> [x] Show an alert.
>
> This is without your patch applied...
Yes, that's the same for me as well. The issue is not that there aren't
notifications, but that IceDove chooses to use its own fallback
implementation of them rather than using the program configured to send
them (in my case it's dunst). Without my patch I get large notifications
inconsistent with my setup. With my patch I get my custom configured
dunst notifications.
I'm pretty sure Icecat would use the same fallback notification
implementation if it didn't have libnotify. That's how I found out about
this issue back when I made the patch after all, but I can't remember
the details anymore. All I can say is Icedove uses the right
notifications on my machine with the patch applied.
I hope that explains the difference and maybe you're able to reproduce
the issue.
PS: I was actually actively waiting for a response since I sent the
patch (same as my other patch). Unfortunately I didn't check mumi
earlier. I've also changed my E-mail provider as the server I was
previously using was having a hard time getting to Debbugs.
Hello SeerLite,
rebased and pushed as a3239ffd84e6ee9d9494085ddc3b875ebf43e225.
~Jonathan
@@ -1189,6 +1189,7 @@ (define (runpaths-of-input label)
"eudev"
"pulseaudio"
;; For the integration of native notifications
+ ;; (same reason as icedove)
"libnotify"))))
(wrap-program (car (find-files lib "^icecat$"))
`("XDG_DATA_DIRS" prefix (,gtk-share))
@@ -1496,10 +1497,13 @@ (define-public icedove
(pulseaudio #$(this-package-input "pulseaudio"))
(pulseaudio-lib (string-append pulseaudio "/lib"))
(eudev #$(this-package-input "eudev"))
- (eudev-lib (string-append eudev "/lib")))
+ (eudev-lib (string-append eudev "/lib"))
+ ;; For the integration of native notifications (same reason as icecat)
+ (libnotify #$(this-package-input "libnotify"))
+ (libnotify-lib (string-append libnotify "/lib")))
(wrap-program (car (find-files lib "^icedove$"))
`("XDG_DATA_DIRS" prefix (,gtk-share))
- `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib ,eudev-lib)))))))))
+ `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib ,eudev-lib ,libnotify-lib)))))))))
(inputs
(list alsa-lib
bzip2
@@ -1519,6 +1523,7 @@ (define-public icedove
libffi
libgnome
libjpeg-turbo
+ libnotify
libpng-apng
libvpx
libxcomposite