diff mbox series

[bug#60944] gnu: cl-croatoan: Update to 0.0.1-7.622a590.

Message ID 20230119092247.27606-1-sharlatanus@gmail.com
State New
Headers
Series [bug#60944] gnu: cl-croatoan: Update to 0.0.1-7.622a590. |

Commit Message

Sharlatan Hellseher Jan. 19, 2023, 9:22 a.m. UTC 
* gnu/packages/lisp-xyz.scm (sbcl-croatoan): Update to 0.0.1-7.622a590.
  [arguments]{asd-systems} Add croatoan, croatoan-ncurses and ansi-escape.
  [arguments]{phases}(fix-paths): Use search-input-file procedure.
---
 gnu/packages/lisp-xyz.scm | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

Comments

Guillaume Le Vaillant Jan. 25, 2023, 9:11 a.m. UTC | #1 
Hi,

The tinmop dependent package fails to build with this updated croatoan:

--8<---------------cut here---------------start------------->8---
; compiling file "/tmp/guix-build-tinmop-0.9.9.14.drv-0/source/src/windows.lisp" (written 01 JAN 1970 12:00:01 AM):
; 
; caught ERROR:
;   READ error during COMPILE-FILE:
;   
;     Symbol "DIALOG-WINDOW" not found in the DE.ANVI.CROATOAN package.
;   
;       Line: 538, Column: -1, File-Position: 19509
;   
;       Stream: #<SB-INT:FORM-TRACKING-STREAM for "file /tmp/guix-build-tinmop-0.9.9.14.drv-0/source/src/windows.lisp" {10030DDD23}>
--8<---------------cut here---------------end--------------->8---

Could you take a look? (Maybe updating tinmop too would work...)
Sharlatan Hellseher Jan. 25, 2023, 8:28 p.m. UTC | #2 
Hi Cage,

I sow your comment on this issue
https://github.com/McParen/croatoan/issues/49 and would like to let
you know that tinmop stoped building with latest commit of croatoan.

Regards,
Oleg

On Wed, 25 Jan 2023 at 09:17, Guillaume Le Vaillant <glv@posteo.net> wrote:
>
> Hi,
>
> The tinmop dependent package fails to build with this updated croatoan:
>
> --8<---------------cut here---------------start------------->8---
> ; compiling file "/tmp/guix-build-tinmop-0.9.9.14.drv-0/source/src/windows.lisp" (written 01 JAN 1970 12:00:01 AM):
> ;
> ; caught ERROR:
> ;   READ error during COMPILE-FILE:
> ;
> ;     Symbol "DIALOG-WINDOW" not found in the DE.ANVI.CROATOAN package.
> ;
> ;       Line: 538, Column: -1, File-Position: 19509
> ;
> ;       Stream: #<SB-INT:FORM-TRACKING-STREAM for "file /tmp/guix-build-tinmop-0.9.9.14.drv-0/source/src/windows.lisp" {10030DDD23}>
> --8<---------------cut here---------------end--------------->8---
>
> Could you take a look? (Maybe updating tinmop too would work...)



-- 

… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.
cage Jan. 26, 2023, 2:58 p.m. UTC | #3 
Hi everyone!

[...]

> > The tinmop dependent package fails to build with this updated croatoan:
> >
> > --8<---------------cut here---------------start------------->8---
> > ; compiling file "/tmp/guix-build-tinmop-0.9.9.14.drv-0/source/src/windows.lisp" (written 01 JAN 1970 12:00:01 AM):
> > ;
> > ; caught ERROR:
> > ;   READ error during COMPILE-FILE:
> > ;
> > ;     Symbol "DIALOG-WINDOW" not found in the DE.ANVI.CROATOAN package.
> > ;
> > ;       Line: 538, Column: -1, File-Position: 19509
> > ;
> > ;       Stream: #<SB-INT:FORM-TRACKING-STREAM for "file /tmp/guix-build-tinmop-0.9.9.14.drv-0/source/src/windows.lisp" {10030DDD23}>
> > --8<---------------cut here---------------end--------------->8---
> >
> > Could you take a look? (Maybe updating tinmop too would work...)

Unfortunately the fix appears to be blocked because of this issue:

https://mailman.common-lisp.net/pipermail/croatoan-devel/2023/000010.html

Bye!
C.
cage Jan. 30, 2023, 5:51 p.m. UTC | #4 
Hi everyone!

The library has been  fixed upstream. Now I just need  to fix the code
of tinmop to repflect the API changes. After that the library could be
updated without breaking any packages (or so I hope!).

I'll report here when the software will  be patched (i need a few days
to make a proper release, unfortunately).

Bye!
C.
cage Jan. 31, 2023, 5:57 p.m. UTC | #5 
Hi!

I just released a new version of tinmop that is linked to the latest Croatoan version.

Bye!
C.
Sharlatan Hellseher Feb. 13, 2023, 12:22 a.m. UTC | #6 
Hi,

I've updated my patches and include tinmop latest version.
> ./pre-inst-env guix build $(./pre-inst-env guix refresh --list-dependent sbcl-croatoan|awk -F: '{print $2}')
> /gnu/store/c71jknbvb92hjwbcpfsw7x43jxrqfjgy-tinmop-0.9.9.141
> /gnu/store/k36q6yqsil5mrirnndxkhix62482v5yy-cl-croatoan-0.0.1-7.42e474f

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.
cage Feb. 14, 2023, 6:33 p.m. UTC | #7 
Hi!

Thanks for helps with packaging!

Bye!
C.
diff mbox series

Patch

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index 39fe5c3f76..947e7fa6ed 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -17121,8 +17121,8 @@  (define-public cl-tooter
   (sbcl-package->cl-source-package sbcl-tooter))
 
 (define-public sbcl-croatoan
-  (let ((commit "35c92fcc6c4458339c7e27bdf16f7fa908d95eb8")
-        (revision "6"))
+  (let ((commit "622a5902c38b45248bf843e66158a2ee19468018")
+        (revision "7"))
     (package
       (name "sbcl-croatoan")
       (version (git-version "0.0.1" revision commit))
@@ -17134,18 +17134,17 @@  (define-public sbcl-croatoan
                (commit commit)))
          (file-name (git-file-name "cl-croatoan" version))
          (sha256
-          (base32 "0v1lrdjd29krjb6pr0mql9hjj5c2lv760xwpr17dbsw263vx29xz"))))
+          (base32 "015xq5bbmv05bnl9hynw0bc7c6dv49hak72f5h45ry8zmpxx5cr5"))))
       (build-system asdf-build-system/sbcl)
       (arguments
-       '(#:phases
+       '(#:asd-systems '("croatoan" "croatoan-ncurses" "ansi-escape")
+         #:phases
          (modify-phases %standard-phases
            (add-after 'unpack 'fix-paths
              (lambda* (#:key inputs #:allow-other-keys)
                (substitute* "ncurses/ncurses.lisp"
-                 (("libncursesw" all)
-                  (string-append (assoc-ref inputs "ncurses")
-                                 "/lib/"
-                                 all))))))))
+                 (("libncursesw.so")
+                  (search-input-file inputs "/lib/libncursesw.so"))))))))
       (inputs
        (list ncurses
              sbcl-cffi