| Message ID | cover.1729415197.git.poptsov.artyom@gmail.com |
|---|---|
| Headers | show |
| Series | gnu: yggdrasil: Update to 0.5.9. | expand |
Hi, Some review points, but it looks fine in general. Looks ok and trivial - [PATCH 2/4] gnu: go-github-com-wlynxg-anet: Update to 0.0.5. - [PATCH 3/4] gnu: go-github-com-arceliar-ironwood: Update to v0.0.0-20241016082300-f6fb9da97a17. The project is quite active and big, maybe we may add more info into description with some highlights of features. WDYT? - [PATCH 1/4] gnu: Add go-github-com-coder-websocket. --8<---------------cut here---------------start------------->8--- + `(#:import-path "github.com/coder/websocket")) --8<---------------cut here---------------end--------------->8--- I guess "guix import go" generates "(arguments (list ...))" style, let's stick to that. Looks ok. Maybe check if we have associated service and 0.5.9 did not bring any breaking changes or new features in configuration. - [PATCH 4/4] gnu: yggdrasil: Update to 0.5.9. I could build it locally: --8<---------------cut here---------------start------------->8--- successfully built /gnu/store/bk5ksmjyhza2dznnnmqhi0fxvb8snlvn-yggdrasil-0.5.9.drv /gnu/store/grlv79cw4z3m60q2vgqshkk4dl3lxqn8-yggdrasil-0.5.9 --8<---------------cut here---------------end--------------->8--- Comments are optional, you don't have to send v2 if you decided to apply changes reflecting them. -- Thanks, Oleg
Reviewed by: Sharlatan Hellseher <sharlatanus@gmail.com> Merged to the "master" branch as: - 44c9441434f10477e0e366f839c4778d9ca4a735 - 76c7b00bc4e92131e2420221189a7d828dcbfb41 - 93c632ea8d5fce95ec997fcbfe9fcd6633df0669 - bd26815cf8ce38a3b03676a6e3fc482bb74247cb - avp
This patchset updates Yggdrasil to 0.5.9. Artyom V. Poptsov (4): gnu: Add go-github-com-coder-websocket. gnu: go-github-com-wlynxg-anet: Update to 0.0.5. gnu: go-github-com-arceliar-ironwood: Update to v0.0.0-20241016082300-f6fb9da97a17. gnu: yggdrasil: Update to 0.5.9. gnu/packages/golang-web.scm | 27 +++++++++++++++++++++++++-- gnu/packages/golang.scm | 4 ++-- gnu/packages/networking.scm | 9 +++++---- 3 files changed, 32 insertions(+), 8 deletions(-) base-commit: 551a2b293ee34855f9395b9032e5a8837a64e08e