Message ID | 20220731152938.28770-1-mail@muradm.net |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 313A527BBEB; Sun, 31 Jul 2022 16:30:16 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 6946A27BBEA for <patchwork@mira.cbaines.net>; Sun, 31 Jul 2022 16:30:15 +0100 (BST) Received: from localhost ([::1]:43520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org>) id 1oIAtS-0002r8-In for patchwork@mira.cbaines.net; Sun, 31 Jul 2022 11:30:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1oIAtH-0002qS-0S for guix-patches@gnu.org; Sun, 31 Jul 2022 11:30:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48735) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1oIAtG-000817-Mh for guix-patches@gnu.org; Sun, 31 Jul 2022 11:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1oIAtG-00030g-1f for guix-patches@gnu.org; Sun, 31 Jul 2022 11:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56858] [PATCH] gnu: libcgroup: Update to 2.0.2. Resent-From: muradm <mail@muradm.net> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 31 Jul 2022 15:30:01 +0000 Resent-Message-ID: <handler.56858.B.165928139211524@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56858 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56858@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165928139211524 (code B ref -1); Sun, 31 Jul 2022 15:30:01 +0000 Received: (at submit) by debbugs.gnu.org; 31 Jul 2022 15:29:52 +0000 Received: from localhost ([127.0.0.1]:38484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1oIAt6-0002zo-7w for submit@debbugs.gnu.org; Sun, 31 Jul 2022 11:29:52 -0400 Received: from lists.gnu.org ([209.51.188.17]:59050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@muradm.net>) id 1oIAt1-0002ze-PT for submit@debbugs.gnu.org; Sun, 31 Jul 2022 11:29:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mail@muradm.net>) id 1oIAsy-0002iV-6s for guix-patches@gnu.org; Sun, 31 Jul 2022 11:29:47 -0400 Received: from nomad-cl1.staging.muradm.net ([139.162.159.157]:38440 helo=nomad-cl1.muradm.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mail@muradm.net>) id 1oIAsv-0007tv-QV for guix-patches@gnu.org; Sun, 31 Jul 2022 11:29:43 -0400 Received: from localhost ([127.0.0.1]:58998) by nomad-cl1.muradm.net with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <mail@muradm.net>) id 1oIAsT-0007UB-27 for guix-patches@gnu.org; Sun, 31 Jul 2022 15:29:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; s=mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To: From:Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=a0Yfk076JquHNTHz6iAYDlnp4ws6iyw2loTffm1Ppn4=; b=hiOdNHJghD0Q0HHnln6Tm6bLAt fkbxo8VIia8iiJLe42XECjWInk52CEE7UaIckW2V55u10K2Lwg3+SXJOOMErR94MaTv7hkg/G8B0O diS5Ep3Xcus5hCBhIMnGiHndkTpLhd5tx6RfGubdpdNElaeHMM4QMSxsqGY6a1mmgLW/uBinRbL8h QqjMY/PVP1aatl5VR9EAbeKZYFnwOHtzfA78YV6ssoiwwUg7QZKdghsDcRITgvUTZIHztwkWbRsJS HQUDuSL7ilL9aSJ7HErCU4gREUKZwhXbWSWomgIFIbu3sHU5gKtqpkeVlAYRM2WN0YuWugwmtV4Dg GxId23dD772BZieWs7Q7cWxsPloL/wCRUk9kz0Qzuj0GIXkfaZDb8ZoII15UMOIvPnweKgM+qXKvH Th/zOTp7TLa3X2+cbnSXjRTirKe1esCUPb1bHAzIQb43/58O8yt/UoqoThaV8FFkE++dfdmHDPnq/ zEbKEIE6V9sp1Xz0G3Wju4H4; Received: from muradm by localhost with local (Exim 4.96) (envelope-from <mail@muradm.net>) id 1oIAss-0007UA-0W for guix-patches@gnu.org; Sun, 31 Jul 2022 18:29:38 +0300 From: muradm <mail@muradm.net> Date: Sun, 31 Jul 2022 18:29:38 +0300 Message-Id: <20220731152938.28770-1-mail@muradm.net> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=139.162.159.157; envelope-from=mail@muradm.net; helo=nomad-cl1.muradm.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-getmail-retrieved-from-mailbox: Patches |
Series |
[bug#56858] gnu: libcgroup: Update to 2.0.2.
|
|
Commit Message
muradm
July 31, 2022, 3:29 p.m. UTC
* gnu/packages/linux.scm (libcgroup): Update to 2.0.2. [source]: Project migrated to github. --- gnu/packages/linux.scm | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
Comments
Hi! On Sun Jul 31, 2022 at 4:29 PM BST, muradm wrote: > + (home-page "https://github.com/libcgroup/libcgroup") Put home-page under inputs and above synopsis, where it was before. > (method url-fetch) > - (uri (string-append > - "mirror://sourceforge/libcg/" name "/" > - version "/" name "-" version ".tar.bz2")) > + (uri (string-append home-page "/releases/download/v" > + version "/" name "-" version ".tar.gz")) Since we're using github now, we likely want to use git-fetch here. I've been told Github releases are volatile. -- (
"(" <paren@disroot.org> writes: > Hi! > > On Sun Jul 31, 2022 at 4:29 PM BST, muradm wrote: >> + (home-page "https://github.com/libcgroup/libcgroup") > Put home-page under inputs and above synopsis, where it was > before. > Is there a guideline where home-page should be? I find it more DRY when reusing. >> (method url-fetch) >> - (uri (string-append >> - "mirror://sourceforge/libcg/" name "/" >> - version "/" name "-" version ".tar.bz2")) >> + (uri (string-append home-page "/releases/download/v" >> + version "/" name "-" version >> ".tar.gz")) > Since we're using github now, we likely want to use git-fetch > here. > I've been told Github releases are volatile. > > -- ( Their repo is not suitable for building from, instead they release sources manually.
On Mon Aug 1, 2022 at 6:42 AM BST, muradm wrote: > Is there a guideline where home-page should be? I find it more > DRY when reusing. Almost every package in Guix puts it directly above synopsis, though you do have a point about DRY. > Their repo is not suitable for building from, instead > they release sources manually. Looks okay to me: <https://github.com/libcgroup/libcgroup/tree/v2.0.2> But there is a problem with vendoring googletest, it seems. You'll want to use the system's googletest, and (recursive? #t) in the git-reference to clone the tests repo. Also, the tarball seems to contain pregenerated autotools files, which are discouraged by Guix. -- (
On Mon Aug 1, 2022 at 10:02 AM BST, ( via Guix-patches via wrote:
> (recursive? #t) in the git-reference to clone the tests repo.
Alternatively, write an <origin> for the tests repo, then use
that as an input for the libcgroup package.
-- (
Previous version was also built from sources. I didn't find it feasible to battle with bootstraping for this version either. Tests are very intrusive and/or containerized with lxc. So yeah, as per their process, there are tons of things to be done manually from bootstraping. May be sometime in the future if they will move to more modern project layout, that could become feasible. "(" <paren@disroot.org> writes: > On Mon Aug 1, 2022 at 6:42 AM BST, muradm wrote: >> Is there a guideline where home-page should be? I find it more >> DRY when reusing. > Almost every package in Guix puts it directly above synopsis, > though > you do have a point about DRY. > >> Their repo is not suitable for building from, instead >> they release sources manually. > Looks okay to me: > <https://github.com/libcgroup/libcgroup/tree/v2.0.2> > But there is a problem with vendoring googletest, it seems. > You'll want > to use the system's googletest, and (recursive? #t) in the > git-reference > to clone the tests repo. Also, the tarball seems to contain > pregenerated > autotools files, which are discouraged by Guix. > > > -- (
"(" <paren@disroot.org> writes: > Hi! > > On Sun Jul 31, 2022 at 4:29 PM BST, muradm wrote: >> + (home-page "https://github.com/libcgroup/libcgroup") > Put home-page under inputs and above synopsis, where it was before. > >> (method url-fetch) >> - (uri (string-append >> - "mirror://sourceforge/libcg/" name "/" >> - version "/" name "-" version ".tar.bz2")) >> + (uri (string-append home-page "/releases/download/v" >> + version "/" name "-" version ".tar.gz")) > Since we're using github now, we likely want to use git-fetch here. > I've been told Github releases are volatile. Hello, I believe '/releases' are okay, since they are uploaded manual by the owner, the unstable ones are under '/archive' which are auto-generated tarballs for tags.
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 906303175d..bcb2bb284a 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -8146,15 +8146,15 @@ (define-public fbcat (define-public libcgroup (package (name "libcgroup") - (version "0.41") + (version "2.0.2") + (home-page "https://github.com/libcgroup/libcgroup") (source (origin (method url-fetch) - (uri (string-append - "mirror://sourceforge/libcg/" name "/" - version "/" name "-" version ".tar.bz2")) + (uri (string-append home-page "/releases/download/v" + version "/" name "-" version ".tar.gz")) (sha256 - (base32 "0lgvyq37gq84sk30sg18admxaj0j0p5dq3bl6g74a1ppgvf8pqz4")))) + (base32 "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf")))) (build-system gnu-build-system) (arguments `(#:tests? #f)) @@ -8162,7 +8162,6 @@ (define-public libcgroup (list bison flex)) (inputs (list linux-pam)) - (home-page "https://sourceforge.net/projects/libcg/") (synopsis "Control groups management tools") (description "Control groups is Linux kernel method for process resource restriction, permission handling and more. This package provides userspace