Message ID | cover.1717676657.git.gemmaro.dev@gmail.com |
---|---|
Headers | show |
Series | gnu: solaar: Update to 1.1.13. | expand |
Hello, thanks for the update! I have applied the first patch. Concerning the second patch, we do not need a gexp; they are similar to quoting and unquoting and needed to stage code execution (from the package definition to the build). Here everything is done at package definition time. #~ is some kind of (quasi-)quoting, but there is no corresponding unquoting #$ or #+ in the following block. (Actually, to make this even clearer, one could replace ` by '; but this would not warrant a commit.) Andreas
Andreas Enge <andreas@enge.fr> writes: > Concerning the second patch, we do not need a gexp; they are similar to > quoting and unquoting and needed to stage code execution (from the package > definition to the build). Here everything is done at package definition > time. #~ is some kind of (quasi-)quoting, but there is no corresponding > unquoting #$ or #+ in the following block. (Actually, to make this even > clearer, one could replace ` by '; but this would not warrant a commit.) Note that quoting vs gexps matters for package inheritance, so even though there's no ungexp'ing happening in this pacakge, the phases could be ungexp'ed by a package that inherits from solaar. For this reason, I think it's important to move to using gexp's for all phases, even the trivial ones, so that there are less issues when it comes to package inheritance and modifying phases.
Am Mon, Jun 10, 2024 at 11:07:11AM +0100 schrieb Christopher Baines: > Note that quoting vs gexps matters for package inheritance, so even > though there's no ungexp'ing happening in this pacakge, the phases could > be ungexp'ed by a package that inherits from solaar. > For this reason, I think it's important to move to using gexp's for all > phases, even the trivial ones, so that there are less issues when it > comes to package inheritance and modifying phases. Good point, although most packages do not lead to inheritance; but when they do, this issue becomes difficult to debug. Feel free to push the second patch if you want to. Andreas