mbox series

[bug#69731,0/2] Fix prosody system test

Message ID cover.1710157873.git.carlo@zancanaro.id.au
Headers show
Series Fix prosody system test | expand

Message

Carlo Zancanaro March 11, 2024, 11:57 a.m. UTC 
In a previous patch[1], Liliana found that the prosody system test was
failing. I did some investigation, and found that this was because the
saslauth module doesn't allow PLAIN or LOGIN authentication on insecure
connections.

There is a configuration item for this, but we didn't have it as a part of the
Guix prosody-configuration objects, so I added it and then used it to make the
test pass.

[1]: https://issues.guix.gnu.org/69272#10

Carlo Zancanaro (2):
  gnu: services: Add insecure-sasl-mechanisms to prosody configuration.
  gnu: tests: Fix prosody system test.

 doc/guix.texi              | 12 +++++++++---
 gnu/services/messaging.scm |  6 ++++++
 gnu/tests/messaging.scm    |  2 +-
 3 files changed, 16 insertions(+), 4 deletions(-)


base-commit: 2a8018e42c0d9b81de56cf322043c797e443c267

Comments

Liliana Marie Prikler March 11, 2024, 5:24 p.m. UTC | #1 
Am Montag, dem 11.03.2024 um 22:57 +1100 schrieb Carlo Zancanaro:
> In a previous patch[1], Liliana found that the prosody system test
> was failing. I did some investigation, and found that this was
> because the saslauth module doesn't allow PLAIN or LOGIN
> authentication on insecure connections.
> 
> There is a configuration item for this, but we didn't have it as a
> part of the Guix prosody-configuration objects, so I added it and
> then used it to make the test pass.
> 
> [1]: https://issues.guix.gnu.org/69272#10
> 
> Carlo Zancanaro (2):
>   gnu: services: Add insecure-sasl-mechanisms to prosody
> configuration.
>   gnu: tests: Fix prosody system test.
> 
>  doc/guix.texi              | 12 +++++++++---
>  gnu/services/messaging.scm |  6 ++++++
>  gnu/tests/messaging.scm    |  2 +-
>  3 files changed, 16 insertions(+), 4 deletions(-)
> 
> 
> base-commit: 2a8018e42c0d9b81de56cf322043c797e443c267
Nice catch.  Would you also like to submit tests for the modules in
69272?

Cheers
Carlo Zancanaro March 12, 2024, 1:01 a.m. UTC | #2 
On Mon, Mar 11 2024, Liliana Marie Prikler wrote:
> Nice catch.  Would you also like to submit tests for the modules in
> 69272?

I'm not sure how to test them. I had a look at the Freetalk API, but it
doesn't seem like it supports any of the XMPP features that those extra
modules add. We'd need to use a different client (or send raw XML
stanzas) to poke prosody in the right ways.

I'm not prepared to do that amount of exploratory work right now.

Carlo
Liliana Marie Prikler March 17, 2024, 12:29 p.m. UTC | #3 
Am Dienstag, dem 12.03.2024 um 12:01 +1100 schrieb Carlo Zancanaro:
> On Mon, Mar 11 2024, Liliana Marie Prikler wrote:
> > Nice catch.  Would you also like to submit tests for the modules in
> > 69272?
> 
> I'm not sure how to test them. I had a look at the Freetalk API, but
> it doesn't seem like it supports any of the XMPP features that those
> extra modules add. We'd need to use a different client (or send raw
> XML stanzas) to poke prosody in the right ways.
> 
> I'm not prepared to do that amount of exploratory work right now.
Fair enough, I pushed what you already have.

Cheers