| Message ID | 80505f63bef0e6d97c31bd5e52c8dcff69772b10.1731303037.git.maxim.cournoyer@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | gstreamer, GTK, fontmanager updates | expand |
Am Montag, dem 11.11.2024 um 15:17 +0900 schrieb Maxim Cournoyer: > This is a regression introduced by a change to glib-networking. > > * gnu/packages/gnome.scm (libsoup-minimal) [arguments]: Set #:tests? > to #f. > > Change-Id: I07b16aab2b04726ba5363d452b32362a683c9b39 > --- > gnu/packages/gnome.scm | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > index b01fd51ff3..52d128f5c8 100644 > --- a/gnu/packages/gnome.scm > +++ b/gnu/packages/gnome.scm > @@ -5160,6 +5160,10 @@ (define-public libsoup-minimal > (build-system meson-build-system) > (arguments > (list > + ;; FIXME: The test suite is disabled as most tests are > currently broken > + ;; due to glib-networking/GnuTLS expecting a valid trust store > under > + ;; /etc/ssl/certs (see: https://issues.guix.gnu.org/46779). Can we fix this assumption instead? > + #:tests? #f > #:configure-flags #~(list "-Ddocs=disabled") > #:phases > #~(modify-phases %standard-phases
Hi, Liliana Marie Prikler <liliana.prikler@gmail.com> writes: > Am Montag, dem 11.11.2024 um 15:17 +0900 schrieb Maxim Cournoyer: >> This is a regression introduced by a change to glib-networking. >> >> * gnu/packages/gnome.scm (libsoup-minimal) [arguments]: Set #:tests? >> to #f. >> >> Change-Id: I07b16aab2b04726ba5363d452b32362a683c9b39 >> --- >> gnu/packages/gnome.scm | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm >> index b01fd51ff3..52d128f5c8 100644 >> --- a/gnu/packages/gnome.scm >> +++ b/gnu/packages/gnome.scm >> @@ -5160,6 +5160,10 @@ (define-public libsoup-minimal >> (build-system meson-build-system) >> (arguments >> (list >> + ;; FIXME: The test suite is disabled as most tests are >> currently broken >> + ;; due to glib-networking/GnuTLS expecting a valid trust store >> under >> + ;; /etc/ssl/certs (see: https://issues.guix.gnu.org/46779). > Can we fix this assumption instead? Not easily. glib-networking has simplified its handling of trust store, it now leaves it up to the crypto implementation (GnuTLS), which is has its trust store hard-coded to a fixed location. Our best bet is to apply a GnuTLS patch from Nix I've shared in #46779, potentially polishing it a bit for upstream consideration.
Am Dienstag, dem 12.11.2024 um 22:47 +0900 schrieb Maxim Cournoyer: > Hi, > > Liliana Marie Prikler <liliana.prikler@gmail.com> writes: > > > Am Montag, dem 11.11.2024 um 15:17 +0900 schrieb Maxim Cournoyer: > > > This is a regression introduced by a change to glib-networking. > > > > > > * gnu/packages/gnome.scm (libsoup-minimal) [arguments]: Set > > > #:tests? > > > to #f. > > > > > > Change-Id: I07b16aab2b04726ba5363d452b32362a683c9b39 > > > --- > > > gnu/packages/gnome.scm | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > > > index b01fd51ff3..52d128f5c8 100644 > > > --- a/gnu/packages/gnome.scm > > > +++ b/gnu/packages/gnome.scm > > > @@ -5160,6 +5160,10 @@ (define-public libsoup-minimal > > > (build-system meson-build-system) > > > (arguments > > > (list > > > + ;; FIXME: The test suite is disabled as most tests are > > > currently broken > > > + ;; due to glib-networking/GnuTLS expecting a valid trust > > > store > > > under > > > + ;; /etc/ssl/certs (see: > > > https://issues.guix.gnu.org/46779). > > Can we fix this assumption instead? > > Not easily. glib-networking has simplified its handling of trust > store, it now leaves it up to the crypto implementation (GnuTLS), > which is has its trust store hard-coded to a fixed location. Our > best bet is to apply a GnuTLS patch from Nix I've shared in #46779, > potentially polishing it a bit for upstream consideration. Okay, in that case we can leave this patch as-is. Cheers
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index b01fd51ff3..52d128f5c8 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -5160,6 +5160,10 @@ (define-public libsoup-minimal (build-system meson-build-system) (arguments (list + ;; FIXME: The test suite is disabled as most tests are currently broken + ;; due to glib-networking/GnuTLS expecting a valid trust store under + ;; /etc/ssl/certs (see: https://issues.guix.gnu.org/46779). + #:tests? #f #:configure-flags #~(list "-Ddocs=disabled") #:phases #~(modify-phases %standard-phases