diff mbox series

[bug#55774] gnu: quodlibet: Add dependencies for plugins to work.

Message ID BN8PR07MB7027B7A3811C66F33FB041D899A19@BN8PR07MB7027.namprd07.prod.outlook.com
State New
Headers
Series [bug#55774] gnu: quodlibet: Add dependencies for plugins to work. |

Commit Message

Jaft June 3, 2022, 5:02 a.m. UTC 
  * gnu/packages/music.scm (quodlibet): Add dependencies for plugins to work.
---
 gnu/packages/music.scm | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

Comments

Liliana Marie Prikler June 3, 2022, 6:04 a.m. UTC | #1 
Am Freitag, dem 03.06.2022 um 00:02 -0500 schrieb Wamm K. D:
> * gnu/packages/music.scm (quodlibet): Add dependencies for plugins to
> work.
Should be ... (quodlibet)[inputs]: Add ACTUAL_INPUTS...

> ---
>  gnu/packages/music.scm | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 554d70f266..3751305b3c 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -47,6 +47,7 @@
>  ;;; Copyright © 2022 Sughosha <sughosha@disroot.org>
>  ;;; Copyright © 2022 Remco van 't Veer <remco@remworks.net>
>  ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
> +;;; Copyright © 2022 Wamm K. D. <jaft.r@outlook.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -179,6 +180,7 @@ (define-module (gnu packages music)
>    #:use-module (gnu packages vim)       ;for 'xxd'
>    #:use-module (gnu packages web)
>    #:use-module (gnu packages webkit)
> +  #:use-module (gnu packages wm)
>    #:use-module (gnu packages wxwidgets)
>    #:use-module (gnu packages xdisorg)
>    #:use-module (gnu packages xml)
> @@ -6752,7 +6754,16 @@ (define-public quodlibet
>             python-pygobject
>             python-pytest
>             python-sgmllib3k
> -           python-toml))
> +           python-toml
> +           ;; optional but needed for multimedia keys not under
> Gnome
> +           keybinder-3.0
> +           ;; optional but needed for Undo/Redo
> +           ;; support for multiline text fields
> +           gtksourceview
> +           ;; optional but needed for the auto library update plugin
> +           python-pyinotify
> +           ;; optional but needed for the Musicbrainz plugin
> +           python-musicbrainzngs))
YMMV, but it's better for inputs to be sorted alphabetically.  Use line
comments to demarcate specific features, e.g. 
  keybinder-3.0 ; keybindings outside of GNOME
  gtksourceview ; undo, redo, multiline text fields
  ...
Don't forget the 79 character limit; when in doubt claim less features.
If possible, try to line up the comments.

Also, comments like "musicbrainz plugin needs python-musicbrainz" are
not as informative as you'd think and can probably be dropped :)

Cheers
Jaft June 3, 2022, 1:13 p.m. UTC | #2 
On Fri. (Jun 03, 2022) at 08:04:10 AM +02, Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> wrote:
> Am Freitag, dem 03.06.2022 um 00:02 -0500 schrieb Wamm K. D:
>> * gnu/packages/music.scm (quodlibet): Add dependencies for plugins to
>> work.
> Should be ... (quodlibet)[inputs]: Add ACTUAL_INPUTS...

👍; I'll get that updated.

> YMMV, but it's better for inputs to be sorted alphabetically.  Use line
> comments to demarcate specific features, e.g. 
>   keybinder-3.0 ; keybindings outside of GNOME
>   gtksourceview ; undo, redo, multiline text fields
>   ...
> Don't forget the 79 character limit; when in doubt claim less features.
> If possible, try to line up the comments.

Fair; I'll get those updated, as well. Yeah, I was trying to weigh what
to include vs. not but, due to the installation structure of Guix, you
wouldn't be able to use these features by just installing the
dependencies (leastwise, with just a naïve straightforward install, when
I tried) so I figured they were worth including, from that perspective.

> Also, comments like "musicbrainz plugin needs python-musicbrainz" are
> not as informative as you'd think and can probably be dropped :)

Haha; fair. While I could see repeating "musicbrainz" as being
repetitive, I was figuring it's easy to lose track that the dependency
was present specifically due to a plugin, for future developers who
might work on the package, and was mostly trying to capture it was
plugin-related. Thanks for pointing it out and I'll that adjusted.

I'll try making the updates later tonight; thanks a ton.
Liliana Marie Prikler June 3, 2022, 1:22 p.m. UTC | #3 
Am Freitag, dem 03.06.2022 um 08:13 -0500 schrieb Wamm K. D.:
> 
> > YMMV, but it's better for inputs to be sorted alphabetically.  Use
> > line
> > comments to demarcate specific features, e.g. 
> >   keybinder-3.0 ; keybindings outside of GNOME
> >   gtksourceview ; undo, redo, multiline text fields
> >   ...
> > Don't forget the 79 character limit; when in doubt claim less
> > features.
> > If possible, try to line up the comments.
> 
> Fair; I'll get those updated, as well. Yeah, I was trying to weigh
> what to include vs. not but, due to the installation structure of
> Guix, you wouldn't be able to use these features by just installing
> the dependencies (leastwise, with just a naïve straightforward
> install, when I tried) so I figured they were worth including, from
> that perspective.
Oh, you understood me wrongly.  Do add all the inputs, but per input
you might not have enough space to describe *all* that it enables, so
if you run out of horizontal space, stick to the most useful features.

> > Also, comments like "musicbrainz plugin needs python-musicbrainz"
> > are not as informative as you'd think and can probably be dropped
> > :)
> 
> Haha; fair. While I could see repeating "musicbrainz" as being
> repetitive, I was figuring it's easy to lose track that the
> dependency was present specifically due to a plugin, for future
> developers who might work on the package, and was mostly trying to
> capture it was plugin-related. Thanks for pointing it out and I'll
> that adjusted.
IIUC much of quodlibet is actually just plugins, so future packagers
looking into it shouldn't be too confused.  Plus we aim for complete
feature sets in pretty much everything except -minimal package variants
:)

Cheers
diff mbox series

Patch

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 554d70f266..3751305b3c 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -47,6 +47,7 @@ 
 ;;; Copyright © 2022 Sughosha <sughosha@disroot.org>
 ;;; Copyright © 2022 Remco van 't Veer <remco@remworks.net>
 ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2022 Wamm K. D. <jaft.r@outlook.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -179,6 +180,7 @@  (define-module (gnu packages music)
   #:use-module (gnu packages vim)       ;for 'xxd'
   #:use-module (gnu packages web)
   #:use-module (gnu packages webkit)
+  #:use-module (gnu packages wm)
   #:use-module (gnu packages wxwidgets)
   #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xml)
@@ -6752,7 +6754,16 @@  (define-public quodlibet
            python-pygobject
            python-pytest
            python-sgmllib3k
-           python-toml))
+           python-toml
+           ;; optional but needed for multimedia keys not under Gnome
+           keybinder-3.0
+           ;; optional but needed for Undo/Redo
+           ;; support for multiline text fields
+           gtksourceview
+           ;; optional but needed for the auto library update plugin
+           python-pyinotify
+           ;; optional but needed for the Musicbrainz plugin
+           python-musicbrainzngs))
     (home-page "https://github.com/quodlibet/quodlibet")
     (synopsis "Music manager and player")
     (description "Quod Libet provides several ways to browse and view your