| Message ID | CAO0k7008t9g14PM_9iLJ+VYHFF2c7EQLofCriaXCNky006s5ZQ@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [bug#60640] Gnu: Add gdcm | expand |
Hi, Tor-björn Claesson <tclaesson@gmail.com> skribis: > From e1e8d18c4db9de4c8f46354ba3fc912f23ebe9d0 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Tor-bj=C3=B6rn=20Claesson?= <tclaesson@gmail.com> > Date: Fri, 20 Jan 2023 14:38:39 +0200 > Subject: [PATCH] gnu: gdcm: Ignore 3 failing tests. > > --- > gnu/packages/bioinformatics.scm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm > index e60dffc21e..c23f731687 100644 > --- a/gnu/packages/bioinformatics.scm > +++ b/gnu/packages/bioinformatics.scm > @@ -17861,6 +17861,9 @@ (define-public gdcm > "'TestFileMetaInformation" > "|TestElement2" > "|TestSCUValidation" > + "|TestWriter" > + "|TestAnonymizer4" > + "|TestPrinter1" > "|TestEcho" Applied, thanks! It would be nice if you could investigate the test failures: they might reveal that something’s wrong with our packaging. Ludo’.
Tor-björn Claesson <tclaesson@gmail.com> skribis: > From e1e8d18c4db9de4c8f46354ba3fc912f23ebe9d0 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Tor-bj=C3=B6rn=20Claesson?= <tclaesson@gmail.com> > Date: Fri, 20 Jan 2023 14:38:39 +0200 > Subject: [PATCH] gnu: gdcm: Ignore 3 failing tests. Actually I’m seeing more test failures in a -c24 build: --8<---------------cut here---------------start------------->8--- 195/217 Test #195: TestStrictScanner1 .....................***Failed 0.01 sec No such directory: /tmp/guix-build-gdcm-3.0.20.drv-0/build/Testing/Temporary/TestWriter Start 196: TestStrictScanner2_1 196/217 Test #196: TestStrictScanner2_1 ...................***Failed 0.01 sec No such directory: /tmp/guix-build-gdcm-3.0.20.drv-0/build/Testing/Temporary/TestWriter Start 197: TestStrictScanner2 197/217 Test #197: TestStrictScanner2 .....................***Failed 0.02 sec No such directory: /tmp/guix-build-gdcm-3.0.20.drv-0/build/Testing/Temporary/TestWriter Start 198: TestStrictScanner2_2 198/217 Test #198: TestStrictScanner2_2 ...................***Failed 0.02 sec No such directory: /tmp/guix-build-gdcm-3.0.20.drv-0/build/Testing/Temporary/TestWriter […] 98% tests passed, 4 tests failed out of 217 Total Test time (real) = 596.45 sec The following tests FAILED: 195 - TestStrictScanner1 (Failed) 196 - TestStrictScanner2_1 (Failed) 197 - TestStrictScanner2 (Failed) 198 - TestStrictScanner2_2 (Failed) Errors while running CTest --8<---------------cut here---------------end--------------->8--- Passing #:parallel-tests? #f doesn’t help. Could you take a look? TIA, Ludo’.
Hi again! Ludovic Courtès <ludo@gnu.org> writes: > It would be nice if you could investigate the test failures: they might > reveal that something’s wrong with our packaging. Maybe the following is of any help, I was confused by the TestWriter etc. passing in my local checkout, but not when I later tried to build gdcm from the real guix repository. This can be reproduced as follows: 1. Check out and build the original commit to add gdcm 2.8.9 (15caeb745c) 2. Check out and build the "upgrade to 3.0.20" commit (2bdbd962e3) Now the tests suddenly pass. What does the build of 2.8.9 leave behind? I'm still really confused by this!
From e1e8d18c4db9de4c8f46354ba3fc912f23ebe9d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tor-bj=C3=B6rn=20Claesson?= <tclaesson@gmail.com> Date: Fri, 20 Jan 2023 14:38:39 +0200 Subject: [PATCH] gnu: gdcm: Ignore 3 failing tests. --- gnu/packages/bioinformatics.scm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm index e60dffc21e..c23f731687 100644 --- a/gnu/packages/bioinformatics.scm +++ b/gnu/packages/bioinformatics.scm @@ -17861,6 +17861,9 @@ (define-public gdcm "'TestFileMetaInformation" "|TestElement2" "|TestSCUValidation" + "|TestWriter" + "|TestAnonymizer4" + "|TestPrinter1" "|TestEcho" "|TestFind'")))) (home-page "https://gdcm.sourceforge.net/wiki/index.php/Main_Page") -- 2.38.1