diff mbox series

[bug#59085] gnu: Fix copyright line

Message ID 20221107205508.12280-1-hello@lnikki.la
State New
Headers show
Series [bug#59085] gnu: Fix copyright line | expand

Commit Message

Leo Nikkilä Nov. 7, 2022, 8:55 p.m. UTC 
Thanks Chris,

> This sounds reasonable to me, I haven't checked the exact values are
> correct but I'm assuming they're sensible.

I retrieved these values from QEMU, in `scripts/qemu-binfmt-conf.sh'
as described in the source file. I've also tested that they work on my
aarch64 machine at least.

I also noticed that I added the copyright line to the packages file by
mistake, I've attached another patch to correct this below.

--

This is a follow-up to commit 9ad311ec15c05efc78f74252e7eb6cddfb0b5cea.

* gnu/packages/virtualization.scm: Remove copyright line.
* gnu/services/virtualization.scm: Add copyright line.
---
 gnu/packages/virtualization.scm | 1 -
 gnu/services/virtualization.scm | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

Comments

Christopher Baines Nov. 20, 2022, 12:07 p.m. UTC | #1 
Leo Nikkilä <hello@lnikki.la> writes:

> Thanks Chris,
>
>> This sounds reasonable to me, I haven't checked the exact values are
>> correct but I'm assuming they're sensible.
>
> I retrieved these values from QEMU, in `scripts/qemu-binfmt-conf.sh'
> as described in the source file. I've also tested that they work on my
> aarch64 machine at least.

Great :)

> I also noticed that I added the copyright line to the packages file by
> mistake, I've attached another patch to correct this below.

Awesome, thanks, I've finally got around to pushing this now as
d072bcebbf884c68573aeb999db3ae296a7cf939.

Chris
diff mbox series

Patch

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 4c8662f770..981e5e0cf3 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -28,7 +28,6 @@ 
 ;;; Copyright © 2022 Ekaitz Zarraga <ekaitz@elenq.tech>
 ;;; Copyright © 2022 Arun Isaac <arunisaac@systemreboot.net>
 ;;; Copyright © 2022 Zhu Zihao <all_but_last@163.com>
-;;; Copyright © 2022 Leo Nikkilä <hello@lnikki.la>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualization.scm
index b3dc9d2114..601c11b0d1 100644
--- a/gnu/services/virtualization.scm
+++ b/gnu/services/virtualization.scm
@@ -4,6 +4,7 @@ 
 ;;; Copyright © 2020,2021 Jan (janneke) Nieuwenhuizen <janneke@gnu.org>
 ;;; Copyright © 2021 Timotej Lazar <timotej.lazar@araneo.si>
 ;;; Copyright © 2022 Oleg Pykhalov <go.wigust@gmail.com>
+;;; Copyright © 2022 Leo Nikkilä <hello@lnikki.la>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;