diff mbox series

[bug#48028,wip-gnome,v2,06/10] gnu: libsoup: Add missing argument and input.

Message ID 20210426090823.30672-6-rg@raghavgururajan.name
State Accepted
Headers show
Series [bug#48028,wip-gnome,v2,01/10] gnu: gtkmm@2: Remove inheritance from gtkmm@3. | expand

Checks

Context Check Description
cbaines/submitting builds success
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

Raghav Gururajan April 26, 2021, 9:08 a.m. UTC 
* gnu/packages/gnome.scm (libsoup)[arguments](glib-or-gtk): New argument.
[inputs]: Add samba.
---
 gnu/packages/gnome.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

M April 26, 2021, 9:02 p.m. UTC | #1 
Raghav Gururajan via Guix-patches via schreef op ma 26-04-2021 om 05:08 [-0400]:
> * gnu/packages/gnome.scm (libsoup)[arguments](glib-or-gtk): New argument.
> [inputs]: Add samba.
> ---
> [...]
> +       #:glib-or-gtk? #t ; To wrap binaries and/or compile schemas
> [...]
> +       ("ntlm_auth" ,samba))) ; For ntlm_auth support

A clearer commit message would be:
  libsoup: Add input for NTLM-based authentication
and:
  libsoup: Wrap and/or compile schemas.

(+ the usual * gnu/STUFF (package)[arguments].... of course)

Greetings,
Maxime.
Raghav Gururajan April 27, 2021, 9:34 a.m. UTC | #2 
Hi Maxime,

> A clearer commit message would be:
>    libsoup: Add input for NTLM-based authentication
> and:
>    libsoup: Wrap and/or compile schemas.
> 
> (+ the usual * gnu/STUFF (package)[arguments].... of course)

This patch is no longer applicable as-is, starting from v3.

Regards,
RG.
diff mbox series

Patch

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 29779c39af..21f5eaa4c9 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -4913,7 +4913,7 @@  libxml to ease remote use of the RESTful API.")
      `(#:modules ((guix build utils)
                   (guix build meson-build-system)
                   (ice-9 popen))
-
+       #:glib-or-gtk? #t ; To wrap binaries and/or compile schemas
        #:configure-flags '("-Dgtk_doc=true")
        #:phases
        (modify-phases %standard-phases
@@ -4970,7 +4970,8 @@  libxml to ease remote use of the RESTful API.")
        ("zlib" ,zlib)))
     (inputs
      `(("glib-networking" ,glib-networking)
-       ("mit-krb5" ,mit-krb5)))
+       ("mit-krb5" ,mit-krb5)
+       ("ntlm_auth" ,samba))) ; For ntlm_auth support
     (home-page "https://live.gnome.org/LibSoup/")
     (synopsis "GLib-based HTTP Library")
     (description