Message ID | 20201207152159.28551-1-ludo@gnu.org |
---|---|
Headers | show |
Series | Making fewer 'stat' calls during startup | expand |
Hey Ludo, > The semantic difference should be invisible to users: their modules > are still visible and usable in manifests, in ‘guix repl’, etc.; they > just cannot take precedence over modules from Guile and from the > channels. For instance, one cannot define a (gnu packages base) > module or (ice-9 rdelim), drop it in $GUILE_LOAD_PATH, and have that > module picked up in lieu of the original one. I think that’s a > reasonable tradeoff. I think that's reasonable too. I tested it locally and have the following command: --8<---------------cut here---------------start------------->8--- strace -c -e stat,openat ./pre-inst-env guix --8<---------------cut here---------------end--------------->8--- drop from 1671 calls to 1017 calls, which is nice. The patchset looks good to me. Thanks, Mathieu
Hi, Mathieu Othacehe <othacehe@gnu.org> skribis: >> The semantic difference should be invisible to users: their modules >> are still visible and usable in manifests, in ‘guix repl’, etc.; they >> just cannot take precedence over modules from Guile and from the >> channels. For instance, one cannot define a (gnu packages base) >> module or (ice-9 rdelim), drop it in $GUILE_LOAD_PATH, and have that >> module picked up in lieu of the original one. I think that’s a >> reasonable tradeoff. > > I think that's reasonable too. I tested it locally and have the > following command: > > strace -c -e stat,openat ./pre-inst-env guix > > drop from 1671 calls to 1017 calls, which is nice. You should try: ./pre-inst-env strace -c stat guix but even then you’ll get more ‘stat’ calls than the ‘guix’ command provided by ‘guix pull’. You can run, say: strace -c $(make as-derivation)/bin/guix > The patchset looks good to me. Cool, thanks! Ludo’.
Hi! Pushed as 41d01b4e2e74a3e655bac03c241f0de7cb34b75f! Ludo’.