[bug#78645,emacs-team] gnu: emacs-vertico: Update to 2.2.
Commit Message
* gnu/packages/emacs-xyz.scm (emacs-vertico): Update to 2.2.
[source]: Update URL.
[arguments] <#:phases> {makeinfo}: Remove install-file.
Change-Id: I6ce7709c5925bae4ebe4a5feefb6f138e62193df
---
gnu/packages/emacs-xyz.scm | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
base-commit: e3b189854c957c9aa2a68d903d268fcf984d7c23
--
2.49.0
Comments
Am Freitag, dem 30.05.2025 um 23:15 +0200 schrieb Cayetano Santos:
> * gnu/packages/emacs-xyz.scm (emacs-vertico): Update to 2.2.
>
Gratuituous blank line?
> [source]: Update URL.
This appears to be missing.
> [arguments] <#:phases> {makeinfo}: Remove install-file.
Why, though?
Either way, you can shorten that to [#:phases]<makeinfo> imho.
Cheers
> > * gnu/packages/emacs-xyz.scm (emacs-vertico): Update to 2.2.
> >
> Gratuituous blank line?
Removed in v2.
> > [source]: Update URL.
> This appears to be missing.
Removed in v2.
> > [arguments] <#:phases> {makeinfo}: Remove install-file.
> Why, though?
To my understanding, there is no need to, as the build-system takes care of.
> Either way, you can shorten that to [#:phases]<makeinfo> imho.
Let me know if this is mandatory of a personal preference, as I feel
like some will reply to v2 arguing that [arguments] are missing ...
C.
Am Freitag, dem 06.06.2025 um 10:41 +0200 schrieb Cayetano Santos:
> > Either way, you can shorten that to [#:phases]<makeinfo> imho.
>
> Let me know if this is mandatory of a personal preference, as I feel
> like some will reply to v2 arguing that [arguments] are missing ...
While this is a personal opinion and style – and ChangeLog style does
vary quite a bit in Guix commits, as it is not too strictly enforced –
there are a number of contributors with a similar style. Both Ian Eure
and Hilton Chain are members of emacs-team, who can be shown by a quick
'git log --grep' to use '[#:phases]'.
The idea behind this is that four levels of nesting is already the
maximum with the brackets we have and for keyword arguments it's clear
that those belong to arguments. Particularly, when no other argument
is changed, it doesn't make much sense to spell out <arguments>.
Cheers
> The idea behind this is that four levels of nesting is already the
> maximum with the brackets we have and for keyword arguments it's clear
> that those belong to arguments. Particularly, when no other argument
> is changed, it doesn't make much sense to spell out <arguments>.
Thanks for the explanation, fixed in v3.
Let me just point out that, as a random contributor and for light
changes, changelogs appear way more sophisticated that changes
themselves, specially when they seem kind of redundant with the changes.
Anyway, I’ll do my best to comply with the above in following patches.
C.
@@ -42119,7 +42119,7 @@ (define-public emacs-ivy-avy
(define-public emacs-vertico
(package
(name "emacs-vertico")
- (version "2.0")
+ (version "2.2")
(source
(origin
(method git-fetch)
@@ -42128,7 +42128,7 @@ (define-public emacs-vertico
(commit version)))
(file-name (git-file-name name version))
(sha256
- (base32 "0qgw0mhfrjylhyznjmjf7wqs5p3xvdv0lq19pql54plbnr6fspqk"))))
+ (base32 "15zf0kj12an9dmdi55ghpkxj053bqzm50fwlhpga4sjzx7qmv5q8"))))
(build-system emacs-build-system)
(arguments
(list
@@ -42142,15 +42142,13 @@ (define-public emacs-vertico
(for-each (lambda (f)
(rename-file f (basename f)))
el-files))))
- (add-after 'install 'makeinfo
+ (add-after 'move-source-files 'makeinfo
(lambda _
(invoke "emacs"
"--batch"
"--eval=(require 'ox-texinfo)"
"--eval=(find-file \"README.org\")"
- "--eval=(org-texinfo-export-to-info)")
- (install-file "vertico.info"
- (string-append #$output "/share/info")))))))
+ "--eval=(org-texinfo-export-to-info)"))))))
(native-inputs
(list texinfo))
(propagated-inputs