diff mbox series

[bug#78297,electronics-team] gnu: Add python-pydigitalwavetools.

Message ID 6c686a4cab7540c3cc17360df1aaaf57ad338ccc.1746606631.git.csantosb@inventati.org
State New
Headers
Series [bug#78297,electronics-team] gnu: Add python-pydigitalwavetools. |

Commit Message

Cayetano Santos May 7, 2025, 8:30 a.m. UTC 
  * gnu/packages/electronics.scm (python-pydigitalwavetools): New variable.

Change-Id: Iff4d12231b366cff20b386fb1d1ae121ef50e51e
---
 gnu/packages/electronics.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)


base-commit: 658dc3ff5efb3f17e66d4f692a45805fae007989

Comments

Gabriel Wicki May 7, 2025, 1:13 p.m. UTC | #1 
Thanks for the patch!  It LGTM.
Maxim Cournoyer May 8, 2025, 7:52 a.m. UTC | #2 
Hi,

Cayetano Santos <csantosb@inventati.org> writes:

> * gnu/packages/electronics.scm (python-pydigitalwavetools): New variable.
>
> Change-Id: Iff4d12231b366cff20b386fb1d1ae121ef50e51e
> ---
>  gnu/packages/electronics.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
> index 4df7064243..db9459ac03 100644
> --- a/gnu/packages/electronics.scm
> +++ b/gnu/packages/electronics.scm
> @@ -551,6 +551,30 @@ (define-public python-edalize
>  some tool-specific options are set.")
>      (license license:bsd-2)))
>  
> +(define-public python-pydigitalwavetools
> +  (package
> +    (name "python-pydigitalwavetools")
> +    (version "1.1")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/Nic30/pyDigitalWaveTools/")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "1zbk4ndpwm4h8vdv9f567bpsizpy6q4jf0xmma77h0gsnnaqkwis"))))
> +    (build-system pyproject-build-system)
> +    (native-inputs
> +     (list python-pytest
> +           python-setuptools
> +           python-wheel))
> +    (home-page "https://github.com/Nic30/pyDigitalWaveTools/")
> +    (synopsis "Library to manipulate digital wave files.")
> +    (description
> +     "Pydigitalwavetools is a python library to parse, write and format VCD and other digital wave files.")

Please M-x fill-paragraph (M-q) or equivalent in your editor to meet our
80 columns maximum width guideline.  Also,

s/python/Python/
s/wav/WAV/

I'd also use @acronym{VCD, Video CD}, and @acronym{WAV, Waveform Audio
File Format} in the description.

Could you please send a v2 with these small suggested improvements?
diff mbox series

Patch

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index 4df7064243..db9459ac03 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -551,6 +551,30 @@  (define-public python-edalize
 some tool-specific options are set.")
     (license license:bsd-2)))
 
+(define-public python-pydigitalwavetools
+  (package
+    (name "python-pydigitalwavetools")
+    (version "1.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Nic30/pyDigitalWaveTools/")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1zbk4ndpwm4h8vdv9f567bpsizpy6q4jf0xmma77h0gsnnaqkwis"))))
+    (build-system pyproject-build-system)
+    (native-inputs
+     (list python-pytest
+           python-setuptools
+           python-wheel))
+    (home-page "https://github.com/Nic30/pyDigitalWaveTools/")
+    (synopsis "Library to manipulate digital wave files.")
+    (description
+     "Pydigitalwavetools is a python library to parse, write and format VCD and other digital wave files.")
+    (license license:expat)))
+
 (define-public python-surf
   (package
     (name "python-surf")