[bug#78011,v2] gnu: Add opensta.
Commit Message
* gnu/packages/electronics.scm (opensta): New variable.
Change-Id: If753078958535971c8ab3fd7c934d19d24f0a2f7
---
gnu/packages/electronics.scm | 41 ++++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
base-commit: 501a9603f5e3cda07f3be8e7fecac31f7af5ce52
--
2.49.0
Comments
Hi,
Cayetano Santos <csantosb@inventati.org> writes:
[...]
> +(define-public opensta
> + ;; There are no releases, we use last commit.
> + (let ((commit "eb8d39a7dd81b5ca2582ad9bbce0fb6e094b3e0f")
> + (revision "0"))
> + (package
> + (name "opensta")
> + (version (git-version "2.6.2" revision commit))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/parallaxsw/OpenSTA/")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "0bpc7fj4pd5713yny2vrh542jbag1kj20g0ji01c9scqb9av5qw5"))))
> + (build-system cmake-build-system)
> + (arguments
> + (list
Please use the -DBUILD_SHARED_LIBRARY=ON #:configure-flags I suggested
to reduce the output size, as suggested in my original review.
> + #:phases
> + #~(modify-phases %standard-phases
> + (replace 'check
> + (lambda* (#:key (tests? #t) #:allow-other-keys)
Please do not set default values for arguments to this anonymous
procedure; it just clutters the view (#:tests? is always passed by the
build system -- it is it which holds the default value).
> + (when tests?
> + (invoke "../source/test/regression")))))
> + #:configure-flags
> + #~(list
> + (string-append "-DCUDD_DIR=" #$(this-package-input "cudd")))))
> + (native-inputs (list swig bison flex))
> + (inputs (list tcl tcllib zlib cudd eigen))
It looks like you overlooked my suggestion to sort the
native-inputs/inputs.
> + (synopsis "Parallax Static Timing Analyzer")
> + (description
> + "OpenSTA is a gate level static timing verifier. As a stand-alone executable
> +it can be used to verify the timing of a design using standard file formats.")
> + (home-page "https://github.com/parallaxsw/OpenSTA/")
> + (license license:gpl3))))
Why the license change from gpl3+ to gpl3? The former was correct.
Otherwise, LGTM.
Could you send a v3?
>sam. 26 avril 2025 at 21:44, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
> Please use the -DBUILD_SHARED_LIBRARY=ON #:configure-flags I suggested
> to reduce the output size, as suggested in my original review.
Sorry about that ! For some reason, I completely missed your second
reply: v3 sent, hopefully, including all suggestions.
Thanks for your patience !
C.
Hello!
Cayetano Santos <csantosb@inventati.org> writes:
>>sam. 26 avril 2025 at 21:44, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>
>> Please use the -DBUILD_SHARED_LIBRARY=ON #:configure-flags I suggested
>> to reduce the output size, as suggested in my original review.
>
> Sorry about that ! For some reason, I completely missed your second
> reply: v3 sent, hopefully, including all suggestions.
>
> Thanks for your patience !
No worries, I just applied your v3 as b8e2d556d9b. Thanks for your
patience as well!
@@ -38,6 +38,7 @@ (define-module (gnu packages electronics)
#:use-module (gnu packages algebra)
#:use-module (gnu packages autotools)
#:use-module (gnu packages base)
+ #:use-module (gnu packages bison)
#:use-module (gnu packages boost)
#:use-module (gnu packages c)
#:use-module (gnu packages check)
@@ -45,6 +46,7 @@ (define-module (gnu packages electronics)
#:use-module (gnu packages compression)
#:use-module (gnu packages documentation)
#:use-module (gnu packages embedded)
+ #:use-module (gnu packages flex)
#:use-module (gnu packages fontutils)
#:use-module (gnu packages gl)
#:use-module (gnu packages glib)
@@ -53,6 +55,7 @@ (define-module (gnu packages electronics)
#:use-module (gnu packages libftdi)
#:use-module (gnu packages libusb)
#:use-module (gnu packages linux)
+ #:use-module (gnu packages maths)
#:use-module (gnu packages m4)
#:use-module (gnu packages pkg-config)
#:use-module (gnu packages python)
@@ -65,6 +68,7 @@ (define-module (gnu packages electronics)
#:use-module (gnu packages sqlite)
#:use-module (gnu packages stb)
#:use-module (gnu packages swig)
+ #:use-module (gnu packages tcl)
#:use-module (gnu packages tls)
#:use-module (gnu packages toolkits)
#:use-module (gnu packages version-control))
@@ -415,6 +419,43 @@ (define-public openboardview
@end itemize")
(license license:expat)))
+(define-public opensta
+ ;; There are no releases, we use last commit.
+ (let ((commit "eb8d39a7dd81b5ca2582ad9bbce0fb6e094b3e0f")
+ (revision "0"))
+ (package
+ (name "opensta")
+ (version (git-version "2.6.2" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/parallaxsw/OpenSTA/")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "0bpc7fj4pd5713yny2vrh542jbag1kj20g0ji01c9scqb9av5qw5"))))
+ (build-system cmake-build-system)
+ (arguments
+ (list
+ #:phases
+ #~(modify-phases %standard-phases
+ (replace 'check
+ (lambda* (#:key (tests? #t) #:allow-other-keys)
+ (when tests?
+ (invoke "../source/test/regression")))))
+ #:configure-flags
+ #~(list
+ (string-append "-DCUDD_DIR=" #$(this-package-input "cudd")))))
+ (native-inputs (list swig bison flex))
+ (inputs (list tcl tcllib zlib cudd eigen))
+ (synopsis "Parallax Static Timing Analyzer")
+ (description
+ "OpenSTA is a gate level static timing verifier. As a stand-alone executable
+it can be used to verify the timing of a design using standard file formats.")
+ (home-page "https://github.com/parallaxsw/OpenSTA/")
+ (license license:gpl3))))
+
(define-public pulseview
(package
(name "pulseview")