Message ID | 6a4c3d1a2e7f3123de3bc37e9768b5939358adb8.1744786200.git.csantosb@inventati.org |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 2FE9E27BC4A; Wed, 16 Apr 2025 07:51:46 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 9255D27BC49 for <patchwork@mira.cbaines.net>; Wed, 16 Apr 2025 07:51:44 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1u4wc5-0006qf-Dq; Wed, 16 Apr 2025 02:51:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1u4wc3-0006qO-98 for guix-patches@gnu.org; Wed, 16 Apr 2025 02:51:11 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1u4wc2-0004ze-Ui for guix-patches@gnu.org; Wed, 16 Apr 2025 02:51:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=8g4yKXWKIqgogDoLwDWJ52b0vNYuXui7E3v1q44acco=; b=YhxLHpJheRUynqmjcaCIzjPs5kKDgq/y/5EK9MFuSderBDc7sqoO43C+QlH+7bAZbkJZu1HLLaXwyZXEelwKwoS9+tvL0iU0lccLdWh+1fFRsZeM4y/VGE0fDOn5KfvUoo59X3HKv/27OZKeGyewBLrgWnaJdWrcoQ6bP/m6sHgzCSuEKrqDLajY0ysy+uiUoytQh+/20igKzMM4Ciiih1yrVk9YejFZjuA/7GkL10vf+0x+Ula9C3xJmHlNKEkjIkEvrQcAz0ndz46KNAAQ9Jz6+z26FOrn8b+IEJhdodag68Iy31ith4f3ewIDaDLnvizG8rAMaCMKZB4GuFQs0w==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1u4wbt-000721-Pe; Wed, 16 Apr 2025 02:51:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#77836] [PATCH emacs-team] gnu: emacs-ws-butler: Update to 1.3. Resent-From: Cayetano Santos <csantosb@inventati.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: andrew@trop.in, csantosb@inventati.org, divya@subvertising.org, hako@ultrarare.space, ian@retrospec.tv, cox.katherine.e+guix@gmail.com, liliana.prikler@gmail.com, guix-patches@gnu.org Resent-Date: Wed, 16 Apr 2025 06:51:01 +0000 Resent-Message-ID: <handler.77836.B.174478625427008@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 77836 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 77836@debbugs.gnu.org Cc: Cayetano Santos <csantosb@inventati.org>, Andrew Tropin <andrew@trop.in>, Cayetano Santos <csantosb@inventati.org>, Divya Ranjan Pattanaik <divya@subvertising.org>, Hilton Chain <hako@ultrarare.space>, Ian Eure <ian@retrospec.tv>, Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>, Liliana Marie Prikler <liliana.prikler@gmail.com> X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Andrew Tropin <andrew@trop.in>, Cayetano Santos <csantosb@inventati.org>, Divya Ranjan Pattanaik <divya@subvertising.org>, Hilton Chain <hako@ultrarare.space>, Ian Eure <ian@retrospec.tv>, Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>, Liliana Marie Prikler <liliana.prikler@gmail.com> Received: via spool by submit@debbugs.gnu.org id=B.174478625427008 (code B ref -1); Wed, 16 Apr 2025 06:51:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Apr 2025 06:50:54 +0000 Received: from localhost ([127.0.0.1]:33684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1u4wbm-00071W-An for submit@debbugs.gnu.org; Wed, 16 Apr 2025 02:50:54 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42006) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <csantosb@inventati.org>) id 1u4wbk-00070o-8a for submit@debbugs.gnu.org; Wed, 16 Apr 2025 02:50:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <csantosb@inventati.org>) id 1u4wbM-0006ma-Od for guix-patches@gnu.org; Wed, 16 Apr 2025 02:50:32 -0400 Received: from devianza.investici.org ([2c0f:f930:0:4::108]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <csantosb@inventati.org>) id 1u4wbK-0004tZ-4W for guix-patches@gnu.org; Wed, 16 Apr 2025 02:50:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1744786220; bh=8g4yKXWKIqgogDoLwDWJ52b0vNYuXui7E3v1q44acco=; h=From:To:Cc:Subject:Date:From; b=iYqOWddZRIxGBmmixYtmJYCAyaD0k2keESMN1lPfaMPm5OXMTfy3EYASaeBccB/gx SUNJjXPDZamNUPzFImlPkhPP5GqktAscPiefyH5nJrZkKDu/hMVJr1v+ke/L2+k7Zz fOntt9pd7NdI2eYtzpdhY5lKq8R9JwTJVdJLvN8k= Received: from mx2.investici.org (unknown [127.0.0.1]) by devianza.investici.org (Postfix) with ESMTP id 4Zcs984ySFz6vM8; Wed, 16 Apr 2025 06:50:20 +0000 (UTC) Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4Zcs983NvGz6vLy; Wed, 16 Apr 2025 06:50:20 +0000 (UTC) Date: Wed, 16 Apr 2025 08:50:00 +0200 Message-ID: <6a4c3d1a2e7f3123de3bc37e9768b5939358adb8.1744786200.git.csantosb@inventati.org> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2c0f:f930:0:4::108; envelope-from=csantosb@inventati.org; helo=devianza.investici.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Reply-to: Cayetano Santos <csantosb@inventati.org> X-ACL-Warn: , Cayetano Santos via Guix-patches <guix-patches@gnu.org> From: Cayetano Santos via Guix-patches via <guix-patches@gnu.org> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
[bug#77836,emacs-team] gnu: emacs-ws-butler: Update to 1.3.
|
|
Commit Message
Cayetano Santos
April 16, 2025, 6:50 a.m. UTC
* gnu/packages/emacs-xyz.scm (emacs-ws-butler): Update to 1.3. Change-Id: Ibee124269d8fe54029f9dea902991ba7d86cab89 --- gnu/packages/emacs-xyz.scm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) base-commit: 373545dc9efbae6589f502773aa49e26e42c585e
Comments
Am Mittwoch, dem 16.04.2025 um 08:50 +0200 schrieb Cayetano Santos: > * gnu/packages/emacs-xyz.scm (emacs-ws-butler): Update to 1.3. > > Change-Id: Ibee124269d8fe54029f9dea902991ba7d86cab89 > --- > gnu/packages/emacs-xyz.scm | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index 82831f0595..4504ecae6e 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -23123,15 +23123,19 @@ (define-public emacs-hercules > (define-public emacs-ws-butler > (package > (name "emacs-ws-butler") > - (version "1.1") > + (version "1.3") > (source > (origin > (method url-fetch) > (uri (string-append > "https://elpa.nongnu.org/nongnu/ws-butler-" version > ".tar")) > (sha256 > - (base32 > "1vy7g2ryg1drcz9zpn011d36zcd9a5b5yny5hwpjrllqj5dg73jx")))) > + (base32 > "14q19rvps5jcshyls3aa55pxmqbbkhhbdlchnl7ybxwkvvmig9zh")))) > (build-system emacs-build-system) > + (arguments > + (list > + #:tests? #f ; no Makefile in tar file > + #:test-command #~(list "make" "test"))) Why do you use "make" for a test command, when there's no Makefile? > (home-page "https://elpa.nongnu.org/nongnu/ws-butler.html") > (synopsis "Unobtrusively remove trailing whitespace") > (description > > base-commit: 373545dc9efbae6589f502773aa49e26e42c585e Cheers
>mer. 16 avril 2025 at 21:49, Liliana Marie Prikler <liliana.prikler@gmail.com> wrote: >> (source >> (origin >> (method url-fetch) >> (uri (string-append >> "https://elpa.nongnu.org/nongnu/ws-butler-" version >> ".tar")) >> (sha256 >> - (base32 >> "1vy7g2ryg1drcz9zpn011d36zcd9a5b5yny5hwpjrllqj5dg73jx")))) >> + (base32 >> "14q19rvps5jcshyls3aa55pxmqbbkhhbdlchnl7ybxwkvvmig9zh")))) >> (build-system emacs-build-system) >> + (arguments >> + (list >> + #:tests? #f ; no Makefile in tar file >> + #:test-command #~(list "make" "test"))) > Why do you use "make" for a test command, when there's no Makefile? There is a Makefile in the repo, including a target for tests: https://git.savannah.gnu.org/cgit/emacs/nongnu.git/tree/?h=elpa/ws-butler Except that the Makefile is removed from elpa .tar file. Similar to other packages, we disable tests, specifying the reason, while we provide the recipe to run them, once the issue fixed. Not sure what is the right option with elpa .tar files, cloning nongnu instead ? remove test-command ? C.
Am Donnerstag, dem 17.04.2025 um 10:51 +0200 schrieb Cayetano Santos: > > > mer. 16 avril 2025 at 21:49, Liliana Marie Prikler > > <liliana.prikler@gmail.com> wrote: > > > > (source > > > (origin > > > (method url-fetch) > > > (uri (string-append > > > "https://elpa.nongnu.org/nongnu/ws-butler-" version > > > ".tar")) > > > (sha256 > > > - (base32 > > > "1vy7g2ryg1drcz9zpn011d36zcd9a5b5yny5hwpjrllqj5dg73jx")))) > > > + (base32 > > > "14q19rvps5jcshyls3aa55pxmqbbkhhbdlchnl7ybxwkvvmig9zh")))) > > > (build-system emacs-build-system) > > > + (arguments > > > + (list > > > + #:tests? #f ; no Makefile in tar file > > > + #:test-command #~(list "make" "test"))) > > Why do you use "make" for a test command, when there's no Makefile? > > There is a Makefile in the repo, including a target for tests: > > > https://git.savannah.gnu.org/cgit/emacs/nongnu.git/tree/?h=elpa/ws-butler > > Except that the Makefile is removed from elpa .tar file. > > Similar to other packages, we disable tests, specifying the reason, > while we provide the recipe to run them, once the issue fixed. > > Not sure what is the right option with elpa .tar files, cloning > nongnu instead ? remove test-command ? Looking at the Makefile, I think it's actually preferable to spell out the Emacs command for testing (including "--batch", which upstream does not appear to use), in which case we only need the tests themselves preserved in the archive. Cheers
>jeu. 17 avril 2025 at 20:19, Liliana Marie Prikler <liliana.prikler@gmail.com> wrote: >> > Why do you use "make" for a test command, when there's no Makefile? >> There is a Makefile in the repo, including a target for tests: >> https://git.savannah.gnu.org/cgit/emacs/nongnu.git/tree/?h=elpa/ws-butler >> >> Except that the Makefile is removed from elpa .tar file. >> >> Similar to other packages, we disable tests, specifying the reason, >> while we provide the recipe to run them, once the issue fixed. >> >> Not sure what is the right option with elpa .tar files, cloning >> nongnu instead ? remove test-command ? > Looking at the Makefile, I think it's actually preferable to spell out > the Emacs command for testing (including "--batch", which upstream does > not appear to use), in which case we only need the tests themselves > preserved in the archive. Correct me if I’m wrong, but the tests folder itself is absent from the tar file, I’m afraid. At some point, we’d better replace all those limited elpa .tar files by the real sources.
Am Donnerstag, dem 17.04.2025 um 21:42 +0200 schrieb Cayetano Santos: > > Looking at the Makefile, I think it's actually preferable to spell > > out the Emacs command for testing (including "--batch", which > > upstream does not appear to use), in which case we only need the > > tests themselves preserved in the archive. > > Correct me if I’m wrong, but the tests folder itself is absent from > the tar file, I’m afraid. > > At some point, we’d better replace all those limited elpa .tar files > by the real sources. Yeah, we do this for Python packages too and the same logic applies here. No tests in ELPA/PyPI? => Use upstream git. Cheers
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 82831f0595..4504ecae6e 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -23123,15 +23123,19 @@ (define-public emacs-hercules (define-public emacs-ws-butler (package (name "emacs-ws-butler") - (version "1.1") + (version "1.3") (source (origin (method url-fetch) (uri (string-append "https://elpa.nongnu.org/nongnu/ws-butler-" version ".tar")) (sha256 - (base32 "1vy7g2ryg1drcz9zpn011d36zcd9a5b5yny5hwpjrllqj5dg73jx")))) + (base32 "14q19rvps5jcshyls3aa55pxmqbbkhhbdlchnl7ybxwkvvmig9zh")))) (build-system emacs-build-system) + (arguments + (list + #:tests? #f ; no Makefile in tar file + #:test-command #~(list "make" "test"))) (home-page "https://elpa.nongnu.org/nongnu/ws-butler.html") (synopsis "Unobtrusively remove trailing whitespace") (description