diff mbox series

[bug#77782,v2,2/2] gnu: mozjs: Disable test suite failing for DST.

Message ID 7d34871b99eaa6155fb7a8e3bcab9799ca09d8a7.1744893965.git.hako@ultrarare.space
State New
Headers
Series [bug#77782,v2,1/2] gnu: Remove mozjs-102. |

Commit Message

Hilton Chain April 17, 2025, 12:46 p.m. UTC 
  * gnu/packages/gnuzilla.scm (mozjs)[arguments]<#:phases>: Delete test suite
non262/Date/15.9.5.7.js.

Change-Id: I480c78d208ccecda8a5467461a0e5c7228262f9d
---
 gnu/packages/gnuzilla.scm | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Clément Lassieur April 17, 2025, 2:06 p.m. UTC | #1 
On Thu, Apr 17 2025, Hilton Chain wrote:

> * gnu/packages/gnuzilla.scm (mozjs)[arguments]<#:phases>: Delete test suite
> non262/Date/15.9.5.7.js.
>
> Change-Id: I480c78d208ccecda8a5467461a0e5c7228262f9d
> ---
>  gnu/packages/gnuzilla.scm | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
> index 76d5ab1d29..78d6151ceb 100644
> --- a/gnu/packages/gnuzilla.scm
> +++ b/gnu/packages/gnuzilla.scm
> @@ -186,6 +186,10 @@ (define-public mozjs
>                              (("mips64") "mips64|riscv64")))
>                         #~())
>  
> +                ;; FIXME: An one-hour difference is produced after DST
> +                ;; starting in the timezone the test suite uses.
> +                (delete-file "non262/Date/15.9.5.7.js")

Great, LGTM, thanks.

>                  ;; The test suite expects a lightly patched ICU.  Disable tests
>                  ;; that do not work with the system version.  See
>                  ;; "intl/icu-patches" for clues.
Hilton Chain April 19, 2025, 6:30 a.m. UTC | #2 
On Thu, 17 Apr 2025 22:06:16 +0800,
Clément Lassieur wrote:
>
> On Thu, Apr 17 2025, Hilton Chain wrote:
>
> > * gnu/packages/gnuzilla.scm (mozjs)[arguments]<#:phases>: Delete test suite
> > non262/Date/15.9.5.7.js.
> >
> > Change-Id: I480c78d208ccecda8a5467461a0e5c7228262f9d
> > ---
> >  gnu/packages/gnuzilla.scm | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
> > index 76d5ab1d29..78d6151ceb 100644
> > --- a/gnu/packages/gnuzilla.scm
> > +++ b/gnu/packages/gnuzilla.scm
> > @@ -186,6 +186,10 @@ (define-public mozjs
> >                              (("mips64") "mips64|riscv64")))
> >                         #~())
> >
> > +                ;; FIXME: An one-hour difference is produced after DST
> > +                ;; starting in the timezone the test suite uses.
> > +                (delete-file "non262/Date/15.9.5.7.js")
>
> Great, LGTM, thanks.
>
> >                  ;; The test suite expects a lightly patched ICU.  Disable tests
> >                  ;; that do not work with the system version.  See
> >                  ;; "intl/icu-patches" for clues.

Thanks, I have applied it as b276cf2f9785c71cc37688c3e2b1db38e2c710a1.
diff mbox series

Patch

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 76d5ab1d29..78d6151ceb 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -186,6 +186,10 @@  (define-public mozjs
                             (("mips64") "mips64|riscv64")))
                        #~())
 
+                ;; FIXME: An one-hour difference is produced after DST
+                ;; starting in the timezone the test suite uses.
+                (delete-file "non262/Date/15.9.5.7.js")
+
                 ;; The test suite expects a lightly patched ICU.  Disable tests
                 ;; that do not work with the system version.  See
                 ;; "intl/icu-patches" for clues.