| Message ID | 1e929d92cbab025e4c692064652c3e443d2734e2.1744558458.git.hako@ultrarare.space |
|---|---|
| State | New |
| Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 09C3827BC4A; Sun, 13 Apr 2025 16:40:41 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FROM_SUSPICIOUS_NTLD,MAILING_LIST_MULTI,PDS_OTHER_BAD_TLD, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 081F227BC49 for <patchwork@mira.cbaines.net>; Sun, 13 Apr 2025 16:40:37 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1u3zRI-0002i6-Pk; Sun, 13 Apr 2025 11:40:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1u3zRE-0002hW-UP for guix-patches@gnu.org; Sun, 13 Apr 2025 11:40:05 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1u3zRE-0003xF-KX for guix-patches@gnu.org; Sun, 13 Apr 2025 11:40:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=innngYrP8KNILLKprFkkswa6lRGPamU6orHuDfhhYxI=; b=MICFCnCi9a9AGNt9b3kszOPsaYDyrMhYkGaF9Zx4IZZihjhZSn6u9ERbCikjy27NbjEUNJWwvMO8c4nmDFNcO0Mk/arFnRCw3L49cfSq/t/sk0gypS0iMf+HAWkbk9CyWQjL3vDkFIOEQXpxJ49xBJ6H0upe1PMLL+56kWUGEfswmnFUmlwyQQcPJ2VtJ2HZmvHlqaEmKVQzIM2epL8FrYMC5xBBeeDfeRz/4libxE9NqExiaijQk4FzgidF0pNwd9Lp27PhzbSn/f2eg6nsCU5bFW+2WZ2pGoJHTl5aGrZiZJEyC3ThLm5NX6xRp58ktD/H8Bem5z8i6WN1iDiQWA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1u3zRC-0002vF-15; Sun, 13 Apr 2025 11:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#77782] [PATCH 2/2] gnu: mozjs: Work around DST affected tests. Resent-From: Hilton Chain <hako@ultrarare.space> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: nandre@riseup.net, clement@lassieur.org, hako@ultrarare.space, ian@retrospec.tv, jonathan.brielmaier@web.de, mhw@netris.org, guix-patches@gnu.org Resent-Date: Sun, 13 Apr 2025 15:40:01 +0000 Resent-Message-ID: <handler.77782.B77782.174455875111137@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77782 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 77782@debbugs.gnu.org Cc: Hilton Chain <hako@ultrarare.space>, =?utf-8?b?QW5kcsOp?= Batista <nandre@riseup.net>, =?utf-8?q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>, Hilton Chain <hako@ultrarare.space>, Ian Eure <ian@retrospec.tv>, Jonathan Brielmaier <jonathan.brielmaier@web.de>, Mark H Weaver <mhw@netris.org> X-Debbugs-Original-Xcc: =?utf-8?b?QW5kcsOp?= Batista <nandre@riseup.net>, =?utf-8?q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>, Hilton Chain <hako@ultrarare.space>, Ian Eure <ian@retrospec.tv>, Jonathan Brielmaier <jonathan.brielmaier@web.de>, Mark H Weaver <mhw@netris.org> Received: via spool by 77782-submit@debbugs.gnu.org id=B77782.174455875111137 (code B ref 77782); Sun, 13 Apr 2025 15:40:01 +0000 Received: (at 77782) by debbugs.gnu.org; 13 Apr 2025 15:39:11 +0000 Received: from localhost ([127.0.0.1]:43479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1u3zQN-0002tZ-Eq for submit@debbugs.gnu.org; Sun, 13 Apr 2025 11:39:11 -0400 Received: from mx.boiledscript.com ([2a01:4f8:10b:392::42]:40680) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <hako@ultrarare.space>) id 1u3zQK-0002tM-MM for 77782@debbugs.gnu.org; Sun, 13 Apr 2025 11:39:09 -0400 From: Hilton Chain <hako@ultrarare.space> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1744558746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=innngYrP8KNILLKprFkkswa6lRGPamU6orHuDfhhYxI=; b=V5XuJGRg6PCtSwxV2IhOXvoZUCxWcoUvjXUKrWHH2RaewARBdKEcjtIJAa2G+xrav3ptiN xnRoYxPQbJatvCNWOk2GeLG5Tb+Q+BctiNhUy1xyqJ/QKEht6jEbv9ks99y7COXPcJ3EqJ bwog+ttl2Y0QuQd7ubFJ2P1B/XYa03NJBPKvaaJKs/eihfvUX8EwaBvDH9IhFFSB4Y2Obe uvK1YOksXjxfM2cszZoLT7HJYRoSsynlL2UnXq8I8ZsZQrNOAZ4ElKvDD4G0Jg+8rIrUDf JbHhmxQNHSzsbAbUNbZQ9BuBp4dCeGVur2AI7So8dgWANKBILR/pzLvk/zgy/w== Date: Sun, 13 Apr 2025 23:38:54 +0800 Message-ID: <1e929d92cbab025e4c692064652c3e443d2734e2.1744558458.git.hako@ultrarare.space> In-Reply-To: <75e2dcf712c509a2a84c331c8718e6bb9731a2bc.1744558458.git.hako@ultrarare.space> References: <75e2dcf712c509a2a84c331c8718e6bb9731a2bc.1744558458.git.hako@ultrarare.space> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
| Series |
[bug#77782,1/2] gnu: Remove mozjs-102.
|
|
Commit Message
Hilton Chain
April 13, 2025, 3:38 p.m. UTC
* gnu/packages/gnuzilla.scm (mozjs)[arguments]<#:phases>: Use UTC for timezone related tests. Change-Id: I480c78d208ccecda8a5467461a0e5c7228262f9d --- gnu/packages/gnuzilla.scm | 4 ++++ 1 file changed, 4 insertions(+)
Comments
On Sun, Apr 13 2025, Hilton Chain wrote: > * gnu/packages/gnuzilla.scm (mozjs)[arguments]<#:phases>: Use UTC for timezone > related tests. > > Change-Id: I480c78d208ccecda8a5467461a0e5c7228262f9d > --- > gnu/packages/gnuzilla.scm | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm > index 76d5ab1d29..6bcff1c348 100644 > --- a/gnu/packages/gnuzilla.scm > +++ b/gnu/packages/gnuzilla.scm > @@ -178,6 +178,10 @@ (define-public mozjs > ((".*killed process should not have exitStatus.*") > "")) > > + ;; FIXME: Affected by DST. > + (substitute* "non262/Date/15.9.5.7.js" > + (("PST") "UTC")) > + > ;; This was fixed sometime between 102.15.1 and 115.11.0. > ;; These tests are supposed to be skipped on all 64-bit systems. > #$@(if (target-riscv64?) Hello! Could you please explain a bit more what this patch fixes? Thanks, Clément
On Mon, 14 Apr 2025 06:12:45 +0800, Clément Lassieur wrote: > > On Sun, Apr 13 2025, Hilton Chain wrote: > > > * gnu/packages/gnuzilla.scm (mozjs)[arguments]<#:phases>: Use UTC for timezone > > related tests. > > > > Change-Id: I480c78d208ccecda8a5467461a0e5c7228262f9d > > --- > > gnu/packages/gnuzilla.scm | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm > > index 76d5ab1d29..6bcff1c348 100644 > > --- a/gnu/packages/gnuzilla.scm > > +++ b/gnu/packages/gnuzilla.scm > > @@ -178,6 +178,10 @@ (define-public mozjs > > ((".*killed process should not have exitStatus.*") > > "")) > > > > + ;; FIXME: Affected by DST. > > + (substitute* "non262/Date/15.9.5.7.js" > > + (("PST") "UTC")) > > + > > ;; This was fixed sometime between 102.15.1 and 115.11.0. > > ;; These tests are supposed to be skipped on all 64-bit systems. > > #$@(if (target-riscv64?) > > Hello! Could you please explain a bit more what this patch fixes? The test suite currently fails: --8<---------------cut here---------------start------------->8--- TEST-UNEXPECTED-FAIL | non262/Date/15.9.5.7.js | (args: "") | d = new Date(1744545315400); d == new Date(d.toDateString() + " " + d.toLocaleTimeString()) = Sun Apr 13 2025 03:55:15 GMT-0700 (Pacific Daylight Time) expected: Sun Apr 13 2025 04:55:15 GMT-0700 (Pacific Daylight Time) [0.0 s] TEST-UNEXPECTED-FAIL | non262/Date/15.9.5.7.js | (args: "") | d = new Date(1744574115400); d == new Date(d.toDateString() + " " + d.toLocaleTimeString()) = Sun Apr 13 2025 11:55:15 GMT-0700 (Pacific Daylight Time) expected: Sun Apr 13 2025 12:55:15 GMT-0700 (Pacific Daylight Time) [0.0 s] TEST-UNEXPECTED-FAIL | non262/Date/15.9.5.7.js | (args: "") [0.0 s] --8<---------------cut here---------------end--------------->8--- You can reproduce this by rebuilding mozjs on master.
On Mon, Apr 14 2025, Hilton Chain wrote: > On Mon, 14 Apr 2025 06:12:45 +0800, > Clément Lassieur wrote: >> >> On Sun, Apr 13 2025, Hilton Chain wrote: >> >> > * gnu/packages/gnuzilla.scm (mozjs)[arguments]<#:phases>: Use UTC for timezone >> > related tests. >> > >> > Change-Id: I480c78d208ccecda8a5467461a0e5c7228262f9d >> > --- >> > gnu/packages/gnuzilla.scm | 4 ++++ >> > 1 file changed, 4 insertions(+) >> > >> > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm >> > index 76d5ab1d29..6bcff1c348 100644 >> > --- a/gnu/packages/gnuzilla.scm >> > +++ b/gnu/packages/gnuzilla.scm >> > @@ -178,6 +178,10 @@ (define-public mozjs >> > ((".*killed process should not have exitStatus.*") >> > "")) >> > >> > + ;; FIXME: Affected by DST. >> > + (substitute* "non262/Date/15.9.5.7.js" >> > + (("PST") "UTC")) >> > + >> > ;; This was fixed sometime between 102.15.1 and 115.11.0. >> > ;; These tests are supposed to be skipped on all 64-bit systems. >> > #$@(if (target-riscv64?) >> >> Hello! Could you please explain a bit more what this patch fixes? > > The test suite currently fails: > > TEST-UNEXPECTED-FAIL | non262/Date/15.9.5.7.js | (args: "") | d = new Date(1744545315400); d == new Date(d.toDateString() + " " + d.toLocaleTimeString()) = Sun Apr 13 2025 03:55:15 GMT-0700 (Pacific Daylight Time) expected: Sun Apr 13 2025 04:55:15 GMT-0700 (Pacific Daylight Time) [0.0 s] > TEST-UNEXPECTED-FAIL | non262/Date/15.9.5.7.js | (args: "") | d = new Date(1744574115400); d == new Date(d.toDateString() + " " + d.toLocaleTimeString()) = Sun Apr 13 2025 11:55:15 GMT-0700 (Pacific Daylight Time) expected: Sun Apr 13 2025 12:55:15 GMT-0700 (Pacific Daylight Time) [0.0 s] > TEST-UNEXPECTED-FAIL | non262/Date/15.9.5.7.js | (args: "") [0.0 s] > > You can reproduce this by rebuilding mozjs on master. And does the test still make sense with this patch? Wouldn't it be wiser to just disable the non-working test?
diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index 76d5ab1d29..6bcff1c348 100644 --- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -178,6 +178,10 @@ (define-public mozjs ((".*killed process should not have exitStatus.*") "")) + ;; FIXME: Affected by DST. + (substitute* "non262/Date/15.9.5.7.js" + (("PST") "UTC")) + ;; This was fixed sometime between 102.15.1 and 115.11.0. ;; These tests are supposed to be skipped on all 64-bit systems. #$@(if (target-riscv64?)