[bug#77391,2/2] gnu: emacs-ellama: Update to 1.7.2.

Message ID 05a1600566a8d1dbc5c3863248535a9923f600e2.1743367165.git.suhail@bayesians.ca
State New
Headers
Series gnu: emacs-ellama: Update to 1.7.2. |

Commit Message

Suhail Singh March 30, 2025, 4:42 p.m. UTC
  * gnu/packages/emacs-xyz.scm (emacs-ellama): Update to 1.7.2.

Change-Id: I516f99587b0381b8635d1161c56bda5d7db35920
---
 gnu/packages/emacs-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Cayetano Santos April 2, 2025, 9:10 a.m. UTC | #1
Hi Suhail, thanks for the patch ! A couple of remarks:

- emacs-dash is not a dependency anymore
- we need to provide package tests, as the upstream project includes
  them (or disable them explicitly and put a comment with the reason)
  
Suhail Singh April 2, 2025, 1:27 p.m. UTC | #2
Cayetano Santos <csantosb@inventati.org> writes:

> - emacs-dash is not a dependency anymore

Good catch, thanks!  Will remove in v2.

> - we need to provide package tests, as the upstream project includes
>   them (or disable them explicitly and put a comment with the reason)

Could you please explain what you mean by "provide package tests"?  As
in, set "#:tests?" to #t ?  Or something else?
  
Cayetano Santos April 2, 2025, 1:36 p.m. UTC | #3
>Wed 02 Apr 2025 at 09:27, Suhail Singh <suhailsingh247@gmail.com> wrote:

> Could you please explain what you mean by "provide package tests"?  As
> in, set "#:tests?" to #t ?  Or something else?

Yes, exactly, tests are active by default, and need to be explicitly
deactivated otherwise, with a little comment about why. In this case,
there is a "tests" folder in the upstream repository.
  

Patch

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b7cce7be70..61db0bb319 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -5776,7 +5776,7 @@  (define-public emacs-elf-mode
 (define-public emacs-ellama
   (package
     (name "emacs-ellama")
-    (version "1.4.5")
+    (version "1.7.2")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -5784,7 +5784,7 @@  (define-public emacs-ellama
                     (commit version)))
               (file-name (git-file-name name version))
               (sha256 (base32
-                       "1d2z7hc2h583g11rr1labmlvfs27336qxgp9q9nv2fh0f9l1qnv4"))))
+                       "15dxcgsad4wna5v3483ixvfm2zxff12cmi8szxy0m6k4b10gwa0b"))))
     (build-system emacs-build-system)
     (propagated-inputs (list emacs-compat emacs-dash emacs-llm emacs-spinner))
     (home-page "https://github.com/s-kostyaev/ellama")