Message ID | 2f17180041e0fa52a8fe2081616e2865f8f29cd1.1743396418.git.atai@atai.org |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 192C927BBE2; Mon, 31 Mar 2025 05:48:57 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 0A06F27BBE9 for <patchwork@mira.cbaines.net>; Mon, 31 Mar 2025 05:48:55 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1tz74R-0000DU-8E; Mon, 31 Mar 2025 00:48:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tz746-0000Bo-UJ for guix-patches@gnu.org; Mon, 31 Mar 2025 00:48:09 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tz746-0007yD-Ke for guix-patches@gnu.org; Mon, 31 Mar 2025 00:48:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=xGJucEdTb7VkWlEm6b+9cX9PyLBfblORgH2IBWbCo0k=; b=Awx8UgFNC8PHsyMp03IcJPSmKK7MrLlbJf8hl5Uz7bfGNva+PdSY7dBUVpgub75TPYDGX9HLspsw8aeABiE5O/r4Rb+a3OuEugMx4oJoSIUI+aUEAcf1npyOVO53fVu9TKR5bV6/UwnWDMw126RHeGNveJ6bPBWjGOFtw5EACGTMPD37ZDOR0PDLx6y5G62SmPW34j8TFV2Qp9J/izyv1XfZPM3AnDnw4iTz+Gmw1Ru02HJkuwSCRV78UpC7aQUsA7ptTWxB6elLmn+VcFB9/p+gtZy67Bbh56yNnQcrO2hLTdQOvM1WaQG34TIPezdHONUPJfwrYo9DMIPmL2Xh4w==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tz746-00012f-7P for guix-patches@gnu.org; Mon, 31 Mar 2025 00:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#77398] [PATCH] gnu: xrdp: Update to 0.10.3, xorgxrdp: Update to 0.10.4. Resent-From: Andy Tai <atai@atai.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 31 Mar 2025 04:48:01 +0000 Resent-Message-ID: <handler.77398.B.17433964553786@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 77398 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 77398@debbugs.gnu.org Cc: Andy Tai <atai@atai.org> X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17433964553786 (code B ref -1); Mon, 31 Mar 2025 04:48:01 +0000 Received: (at submit) by debbugs.gnu.org; 31 Mar 2025 04:47:35 +0000 Received: from localhost ([127.0.0.1]:38994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1tz73e-0000yv-3p for submit@debbugs.gnu.org; Mon, 31 Mar 2025 00:47:34 -0400 Received: from lists.gnu.org ([2001:470:142::17]:48874) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <lichengtai@gmail.com>) id 1tz73Z-0000wm-JL for submit@debbugs.gnu.org; Mon, 31 Mar 2025 00:47:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <lichengtai@gmail.com>) id 1tz73R-00008z-DK for guix-patches@gnu.org; Mon, 31 Mar 2025 00:47:21 -0400 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <lichengtai@gmail.com>) id 1tz73P-0007s7-E4 for guix-patches@gnu.org; Mon, 31 Mar 2025 00:47:21 -0400 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-2279915e06eso82844495ad.1 for <guix-patches@gnu.org>; Sun, 30 Mar 2025 21:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743396437; x=1744001237; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=xGJucEdTb7VkWlEm6b+9cX9PyLBfblORgH2IBWbCo0k=; b=R6idSk5x5B+ljHZl8kCbwDZkP7Ik54JBYqMHkWMwY/vGPEaqctJPUV9tmm9hiERSWM 6paUUls6hG/qNlTozog3do+bW6ONbXMtQbg5rez88wzBeU0GM8gIVW2o5PtEYWihDf7U LnpPVkxLYEQYzpeX+CIoQkoVXyKki3YPa+j7KmJaHe4waA2t5T1colEB2KLhZjebJ+eM OXlqV4scWTHTjwLwh4WrjFOyifSFkAio1Iwi4M/g5PzrfR60wf6XNlGR7hJ3a5UukqYZ 4A6G71Uw/MlQc1wa/TIsG808IZLCeUZFl3z7cetM2rfghD0+jVCZy0UM05rJmDQ1vPCc Fl8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743396437; x=1744001237; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xGJucEdTb7VkWlEm6b+9cX9PyLBfblORgH2IBWbCo0k=; b=JAA+L09Uh61qX2EN52n1tDni8vNHRhdPSP3zs2Jk3OvHHd8c3MpsYIbmO4vKS7IxN2 kdv+NgkZfCopMQnAhlyrQ4IzBENRfYfb5EfJrbfHmWjJMM+DC65Him0V5CTzI8ZRgOA8 8qmIb7VVLi71yNTk0dCgQVNtSPWgbcjZh0rVZUDZ+sFHPHvUmyqg4GuWms0gG1sF3Jov dyjI3l3vDLIxwHhJ1tjSkOB/LNTLv/lRyESMq65CGlxY3MtFQkTKQVaYRjQ2Jh4inBkM r3v4nYpqZBBooPjtkgSGgZsad1y8KZcYFtTCISVlJuR5S13Ue+zaKtylYXx5zZEAwo6y +CkA== X-Gm-Message-State: AOJu0YwnDY4gAxNnil2WeOMCzxx+ncR6m3SW//F+3vYj+1bsO6WFbB4r uXZaPRCEDGt5rQwPydNV7hAQmmX2d8xPgynoC0bq5dP5gWaamUjhPQ5LDbNhrdA= X-Gm-Gg: ASbGnctovM1BK8sFkM86Zi0+APQTM/+6Vl6/x1hJIJMqDNld+U2xCJvHswt6EoCm+nE qBXE9hPhxU80wXtSH4KGbr0M+O9vC1JB8ZiUXF0LGbC2XsGjqkspPYdvvm6fqEXKCeEPbXPgA9a cFeXOiGtrleiQ5BlXTxAqUf11Z9MIlMLqKDj8+oHG701/Hdl9Si19m16c2RHDGvS2l5uNGo2R2c MCmJ7bW4UHg7jTNrWtrVhiSn+ti2zVz6BsLmJsrskhtYYS5R3FNQ29A+62nvwA0CxE0dH/C7kUa jqDz7xjspUFGFNvpPT5hSHL3+7qkzLUK0v6GUcX2dyQH0UcPZOGvsyGLJaVIVg== X-Google-Smtp-Source: AGHT+IHsfkmmvrkKhM2lYFvS4dHXe7pJwSBe8IrVZhNGKiStHe35fvACQQeiB7rqeQIQV2aAeyOIRw== X-Received: by 2002:a17:902:f691:b0:21f:61a9:be7d with SMTP id d9443c01a7336-2292f9ef608mr109518585ad.49.1743396437159; Sun, 30 Mar 2025 21:47:17 -0700 (PDT) Received: from DEskMiniX300.taila8caa5.ts.net ([172.98.218.160]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2291eeca203sm60841065ad.30.2025.03.30.21.47.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Mar 2025 21:47:16 -0700 (PDT) From: Andy Tai <atai@atai.org> Date: Sun, 30 Mar 2025 21:47:13 -0700 Message-ID: <2f17180041e0fa52a8fe2081616e2865f8f29cd1.1743396418.git.atai@atai.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=lichengtai@gmail.com; helo=mail-pl1-x62f.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
[bug#77398] gnu: xrdp: Update to 0.10.3, xorgxrdp: Update to 0.10.4.
|
|
Commit Message
Andy Tai
March 31, 2025, 4:47 a.m. UTC
* gnu/packages/rdesktop.scm (xrdp): Update to 0.10.3. [inputs]: Replace fuse-2 with fuse. * gnu/packages/rdesktop.scm (xorgxrdp): Update to 0.10.4. Change-Id: I581b8f75c25642d054bcdf22a325b67a1c47c73e --- gnu/packages/rdesktop.scm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) base-commit: 8c43056aabc2d22da61dc86049b143f7ae1ef516
Comments
Hello Andy, the patch fails on 32 bit according to QA: https://qa.guix.gnu.org/issue/77398/package-changes?i686-linux-change=broken&i686-linux-change=still-failing&i686-linux-change=unknown-to-failing&i686-linux-change=new-failing The somewhat surprising error message in https://bordeaux.guix.gnu.org/build/cb17cf76-2ea0-4a1e-b19f-2f7220cc4a8a/log is: In file included from /gnu/store/83yp83mwzvdqn0qhr7hvs5cvizrcf76a-fuse-3.10.5/include/fuse3/fuse_lowlevel.h:25, from chansrv_fuse.c:155: /gnu/store/83yp83mwzvdqn0qhr7hvs5cvizrcf76a-fuse-3.10.5/include/fuse3/fuse_common.h:853:1: error: static assertion failed: "fuse: off_t must be 64bit" 853 | _Static_assert(sizeof(off_t) == 8, "fuse: off_t must be 64bit"); Does this mean that fuse@3 only works on 64 bit platforms? In any case, going back to fuse@2 will probably solve the problem. Then I would suggest to write two commits for the two separate projects. Thanks! Andreas
OK I will take a look. I think xrdp switched to fuse 3 in this release... I need to check if 32-bit support is dropped On Tue, Apr 1, 2025 at 4:04 AM Andreas Enge <andreas@enge.fr> wrote: > Hello Andy, > > the patch fails on 32 bit according to QA: > > https://qa.guix.gnu.org/issue/77398/package-changes?i686-linux-change=broken&i686-linux-change=still-failing&i686-linux-change=unknown-to-failing&i686-linux-change=new-failing > > The somewhat surprising error message in > > https://bordeaux.guix.gnu.org/build/cb17cf76-2ea0-4a1e-b19f-2f7220cc4a8a/log > is: > In file included from > /gnu/store/83yp83mwzvdqn0qhr7hvs5cvizrcf76a-fuse-3.10.5/include/fuse3/fuse_lowlevel.h:25, > from chansrv_fuse.c:155: > /gnu/store/83yp83mwzvdqn0qhr7hvs5cvizrcf76a-fuse-3.10.5/include/fuse3/fuse_common.h:853:1: > error: static assertion failed: "fuse: off_t must be 64bit" > 853 | _Static_assert(sizeof(off_t) == 8, "fuse: off_t must be 64bit"); > > Does this mean that fuse@3 only works on 64 bit platforms? > In any case, going back to fuse@2 will probably solve the problem. > > Then I would suggest to write two commits for the two separate projects. > > Thanks! > > Andreas > >
For info, xrdp 0.10.2 moved to fuse 3 https://c-nergy.be/blog/?p=20148 so the change to fuse for input should be correct.. On Tue, Apr 1, 2025 at 2:40 PM Andy Tai <atai@atai.org> wrote: > > OK I will take a look. I think xrdp switched to fuse 3 in this release... I need to check if 32-bit support is dropped > > On Tue, Apr 1, 2025 at 4:04 AM Andreas Enge <andreas@enge.fr> wrote: >> >> Hello Andy, >> >> the patch fails on 32 bit according to QA: >> https://qa.guix.gnu.org/issue/77398/package-changes?i686-linux-change=broken&i686-linux-change=still-failing&i686-linux-change=unknown-to-failing&i686-linux-change=new-failing >> >> The somewhat surprising error message in >> https://bordeaux.guix.gnu.org/build/cb17cf76-2ea0-4a1e-b19f-2f7220cc4a8a/log >> is: >> In file included from /gnu/store/83yp83mwzvdqn0qhr7hvs5cvizrcf76a-fuse-3.10.5/include/fuse3/fuse_lowlevel.h:25, >> from chansrv_fuse.c:155: >> /gnu/store/83yp83mwzvdqn0qhr7hvs5cvizrcf76a-fuse-3.10.5/include/fuse3/fuse_common.h:853:1: error: static assertion failed: "fuse: off_t must be 64bit" >> 853 | _Static_assert(sizeof(off_t) == 8, "fuse: off_t must be 64bit");
The CFLAGS did work, nice! I have pushed and am closing the issue. Thanks, Andreas
diff --git a/gnu/packages/rdesktop.scm b/gnu/packages/rdesktop.scm index d5d49edc200..d7a105f4c27 100644 --- a/gnu/packages/rdesktop.scm +++ b/gnu/packages/rdesktop.scm @@ -168,7 +168,7 @@ (define-public freerdp (define-public xrdp (package (name "xrdp") - (version "0.10.1") + (version "0.10.3") (source (origin (method url-fetch) (uri (string-append @@ -176,10 +176,10 @@ (define-public xrdp version "/xrdp-" version ".tar.gz")) (sha256 (base32 - "10rgc9bfharwj7bq5k4qp4x00w214h6c6f861zi301h84125ylx2")))) + "15nhfh8lxwf0jlmq6knh3851sp6njps9nhl8n2867il7mcr9gmsj")))) (build-system gnu-build-system) (inputs (list check - fuse-2 + fuse imlib2 lame libjpeg-turbo @@ -234,7 +234,7 @@ (define-public xrdp (define-public xorgxrdp (package (name "xorgxrdp") - (version "0.10.2") + (version "0.10.4") (source (origin (method git-fetch) (uri (git-reference @@ -243,7 +243,7 @@ (define-public xorgxrdp (file-name (git-file-name name version)) (sha256 (base32 - "1dcxn0v88426j4n7irhy6h3qb21202v5xs1vr7j8xvs3sxihc2f7")))) + "0y243h7mk9jy5yrdgngjkcr6rzq4116ip7pvc6vwz7yfnxxd9v2f")))) (build-system gnu-build-system) (inputs (list check imlib2