Message ID | 218d5ad8274680771591e5d940dcc7b7e7c0aafd.1742073920.git.ludo@gnu.org |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 9856327BBEA; Sat, 15 Mar 2025 21:40:13 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 51DAB27BBE2 for <patchwork@mira.cbaines.net>; Sat, 15 Mar 2025 21:40:13 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1ttZEm-0005fI-Qn; Sat, 15 Mar 2025 17:40:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ttZEk-0005cT-VG for guix-patches@gnu.org; Sat, 15 Mar 2025 17:40:07 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ttZEk-00036C-Kz for guix-patches@gnu.org; Sat, 15 Mar 2025 17:40:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=Cv1jyZhj5WsmAPH1TjhOCm8CArfONTontknGhfeI63s=; b=lEVDGguu7GESQsK0reQH2N+1U2KQPtr2XRSrwrafd2UoJL3oQ7M3C1ud+aMsGefgMSr/osza3pnRw0ht6bNWUR/qQFGZMPwfRIa97mYrFdHWu58n2fdtXbTMp3vMwA2N7KGqM+Qo72aKiInUhw1kvcT5q5hjeLwHtBURtjsesBJAyR+nCXzFB4D+Eq/PYmcnE/eGKWyOpB/2xL9SrmJfUTsTalQrlZ4N7JjI4JOJ30AJVOqQbWmreZYu5Vy760VqpFNvEyV1BRWRh2/GJTWB1DrQfB0JQZ8yhciH+B72DI88fyzUSyY5GZPOlETXuqp3BPdfpRzYUosj3BBjWuZnfw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ttZEj-0004dI-48; Sat, 15 Mar 2025 17:40:05 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#77041] [PATCH 16/16] DRAFT news: Add entry for mcron deprecation. Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: pelzflorian@pelzflorian.de, julien@lepiller.eu, guix-patches@gnu.org Resent-Date: Sat, 15 Mar 2025 21:40:05 +0000 Resent-Message-ID: <handler.77041.B77041.174207476217446@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77041 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 77041@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org>, Florian Pelz <pelzflorian@pelzflorian.de>, Julien Lepiller <julien@lepiller.eu> X-Debbugs-Original-Xcc: Florian Pelz <pelzflorian@pelzflorian.de>, Julien Lepiller <julien@lepiller.eu> Received: via spool by 77041-submit@debbugs.gnu.org id=B77041.174207476217446 (code B ref 77041); Sat, 15 Mar 2025 21:40:05 +0000 Received: (at 77041) by debbugs.gnu.org; 15 Mar 2025 21:39:22 +0000 Received: from localhost ([127.0.0.1]:43884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1ttZE2-0004XC-4y for submit@debbugs.gnu.org; Sat, 15 Mar 2025 17:39:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50218) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <ludo@gnu.org>) id 1ttZD3-0004PY-VU for 77041@debbugs.gnu.org; Sat, 15 Mar 2025 17:38:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@gnu.org>) id 1ttZCy-0002jE-FN; Sat, 15 Mar 2025 17:38:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=Cv1jyZhj5WsmAPH1TjhOCm8CArfONTontknGhfeI63s=; b=eUHgSKstOzKymvZw0XXG DONYT/d2jgZPLAUPZbLinODakCbojMyJgHAFJYYAlqvxvMppiOe8kw9ELu9s/TLMGjxTkqgpnbqVP 3fjnpuTgOKi7V2aydxXqN2l4FIJBmju88F51lw9qWE+vRewIC2y7EObAYp9m0n2sA46Loewtg72io L76VeJDXtWk/c58TlL2GgwEnMebSsfVYoHZZmlW+plIKAH8q2b/f6RlFU5abpWXWdHY/2vHquql4H ni9fpMBQXhJkrtLRFw66bJ4hxgDms0yBJaa9Yxs/LE4U5W75wfCbnInoiqrI126pl15F4U86NtaRE lImCsTJX5wPhzg==; From: Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org> Date: Sat, 15 Mar 2025 22:37:22 +0100 Message-ID: <218d5ad8274680771591e5d940dcc7b7e7c0aafd.1742073920.git.ludo@gnu.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <cover.1742073920.git.ludo@gnu.org> References: <cover.1742073920.git.ludo@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
Replacing mcron jobs by Shepherd timers
|
|
Commit Message
Ludovic Courtès
March 15, 2025, 9:37 p.m. UTC
* etc/news.scm: Add entry. Change-Id: I7e096a8f137e20487f5dac5fca4ae5b05754f5cd --- etc/news.scm | 13 +++++++++++++ 1 file changed, 13 insertions(+)
Comments
Thank you Ludo for not only transitioning Guix but also for cleanups/refactoring here in this patch series. Looks good to me mostly but have not tested nor carefully checked the Scheme code. For fstrim doc/guix.texi, (type: shepherd-calendar-event) in the documentation might be better expressed as “type: Shepherd calendar event”, as there is no shepherd-calendar-event. For fstrim, you also removed the quoting ' of lists: -@item @code{listed-in} (default: @code{'("/etc/fstab" "/proc/self/mountinfo")}) (type: maybe-list-of-strings) +@item @code{listed-in} (default: @code{("/etc/fstab" "/proc/self/mountinfo")}) (type: maybe-list-of-strings) I still prefer quoting, as users need the quote in their configuration files. For [PATCH 15/16] services: mcron: Deprecate. I spot one typo / missing “instead of” in doc/guix.texi: +Please use the Shepherd instead mcron. Could you add the following German translation: (entry (commit "XXX") (title (en "Scheduled job execution with mcron superseded by Shepherd timers") (de "Geplante Auftragsausführung mit mcron abgelöst durch Shepherd-Timer")) (body (en "On Guix System and Guix Home, scheduled job execution with the mcron package is deprecated; @code{mcron-service-type} and @code{home-mcron-service-type} are slated for removal after 2026-04-01. As a replacement for mcron jobs, you can use Shepherd timers---a feature that appeared in version 1.0 of the Shepherd. Run @command{info \"(guix) Scheduled Job Execution\"} for more information on how to transition.") (de "Auf Guix System und Guix Home gilt geplante Auftragsausführung mit dem mcron-Paket als veraltet. Es ist vorgesehen, @code{mcron-service-type} und @code{home-mcron-service-type} nach dem 01.04.2026 zu entfernen. Als Ersatz für mcron-Aufträge können Sie auf Shepherd-Timer umsteigen – diese Funktion ist seit Shepherds Version 1.0 verfügbar. Führen Sie @command{info \"(guix.de) Geplante Auftragsausführung\"} aus, um weitere Informationen zum Umstieg zu bekommen."))) Regards, Florian
Hi Ludovic, Ludovic Courtès <ludo@gnu.org> writes: > * etc/news.scm: Add entry. > > Change-Id: I7e096a8f137e20487f5dac5fca4ae5b05754f5cd > --- > etc/news.scm | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/etc/news.scm b/etc/news.scm > index 8e37bc8bec..368bdb567a 100644 > --- a/etc/news.scm > +++ b/etc/news.scm > @@ -37,6 +37,19 @@ > (channel-news > (version 0) > > + (entry (commit "XXX") > + (title > + (en "Scheduled job execution with mcron superseded by Shepherd > +timers")) > + (body > + (en "On Guix System and Guix Home, scheduled job execution with the > +mcron package is deprecated; @code{mcron-service-type} and > +@code{home-mcron-service-type} are slated for removal after 2026-04-01. > + > +As a replacement for mcron jobs, you can use Shepherd timers---a feature that > +appeared in version 1.0 of the Shepherd. Run @command{info \"(guix) Scheduled > +Job Execution\"} for more information on how to transition."))) > + I'd turn this into a soft-deprecation: document Shepherd timers as the preferred alternative to use in most scenarios such as when authoring Guix System or home services,, but leave otherwise leave the mcron-service-type and home-mcron-service-type services be.
Hi Florian, "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis: > Thank you Ludo for not only transitioning Guix but also for > cleanups/refactoring here in this patch series. Looks good to me mostly > but have not tested nor carefully checked the Scheme code. Thanks! > For fstrim doc/guix.texi, > (type: shepherd-calendar-event) in the documentation might be better > expressed as “type: Shepherd calendar event”, as there is no > shepherd-calendar-event. > > For fstrim, you also removed the quoting ' of lists: > -@item @code{listed-in} (default: @code{'("/etc/fstab" "/proc/self/mountinfo")}) (type: maybe-list-of-strings) > +@item @code{listed-in} (default: @code{("/etc/fstab" "/proc/self/mountinfo")}) (type: maybe-list-of-strings) This was generated by: (configuration->documentation 'fstrim-configuration) I was surprised also by the lack of quote but I suspected this had been discussed before and implemented in ‘define-configuration’. If not, we should report a bug for that. I took note of the other issues you reported and will fix them for v2. Ludo’.
Hi Ludo’, On 2025-03-16 17:11, Ludovic Courtès wrote: > "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis: >> >> For fstrim, you also removed the quoting ' of lists: >> -@item @code{listed-in} (default: @code{'("/etc/fstab" "/proc/self/mountinfo")}) (type: maybe-list-of-strings) >> +@item @code{listed-in} (default: @code{("/etc/fstab" "/proc/self/mountinfo")}) (type: maybe-list-of-strings) > > This was generated by: > > (configuration->documentation 'fstrim-configuration) > > I was surprised also by the lack of quote but I suspected this had been > discussed before and implemented in ‘define-configuration’. If not, we > should report a bug for that. You didn't do anything wrong, this is a current bug/limitation of configuration->documentation, I added those quotes manually when I generated the documentation for that service.
diff --git a/etc/news.scm b/etc/news.scm index 8e37bc8bec..368bdb567a 100644 --- a/etc/news.scm +++ b/etc/news.scm @@ -37,6 +37,19 @@ (channel-news (version 0) + (entry (commit "XXX") + (title + (en "Scheduled job execution with mcron superseded by Shepherd +timers")) + (body + (en "On Guix System and Guix Home, scheduled job execution with the +mcron package is deprecated; @code{mcron-service-type} and +@code{home-mcron-service-type} are slated for removal after 2026-04-01. + +As a replacement for mcron jobs, you can use Shepherd timers---a feature that +appeared in version 1.0 of the Shepherd. Run @command{info \"(guix) Scheduled +Job Execution\"} for more information on how to transition."))) + (entry (commit "41e62cb10c3049610dc854f1d3e9b91aebd73aed") (title (en "Removable devices now mount under @file{/run/media/$USER} instead of @file{/media}")