[bug#73019,v5,2/3] gnu: Add vte-gtk-4-with-sixel.

Message ID 034da9fb3794397469012eb388a2c6d038a1db6f.1725737233.git.ashvithshetty10@gmail.com
State New
Headers
Series Add Black Box terminal |

Commit Message

Ashvith Shetty Sept. 7, 2024, 7:31 p.m. UTC
* gnu/packages/gnome.scm (vte-gtk-4-with-sixel-0.73.0-0.4530d38): New public variable.

Change-Id: I23cca7a2e77aa303303c532e4a4163fb82d2ce48
---
 gnu/packages/gnome.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
  

Comments

Liliana Marie Prikler Feb. 20, 2025, 8:57 p.m. UTC | #1
Am Sonntag, dem 08.09.2024 um 01:01 +0530 schrieb Ashvith Shetty:
> * gnu/packages/gnome.scm (vte-gtk-4-with-sixel-0.73.0-0.4530d38): New
> public variable.
I just noticed this, but the ChangeLogs do not refer to the actually
used variable names.  Do drop the -VERSION part.

> Change-Id: I23cca7a2e77aa303303c532e4a4163fb82d2ce48
> ---
>  gnu/packages/gnome.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 7339000436..598549fb94 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -79,6 +79,7 @@
>  ;;; Copyright © 2023 Zhu Zihao <all_but_last@163.com>
>  ;;; Copyright © 2024 Dariqq <dariqq@posteo.net>
>  ;;; Copyright © 2024 James Smith <jsubuntuxp@disroot.org>
> +;;; Copyright © 2024 Ashvith Shetty <ashvithshetty10@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -4666,6 +4667,29 @@ (define-public vte-with-gtk-4
>      (propagated-inputs (modify-inputs (package-propagated-inputs
> vte)
>                           (replace "gtk+" gtk)))))
>  
> +(define-public vte-gtk-4-with-sixel
> +    (let ((commit "4530d385191562d84f60066e168631fc1f45f3cc")
> +          (revision "0"))
> +  (package/inherit vte-with-gtk-4
> +    (name "vte-gtk4-with-sixel")
> +    (version (git-version "0.73.0" revision commit))
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://gitlab.gnome.org/GNOME/vte")
> +                    (commit commit)))
> +              (file-name (git-file-name name version))
> +              (sha256 (base32
> +                      
> "1z3pkpq0zjqzplq6mah68cwmcd1cr1ii2vp4nfppwmmn55mjapq0"))))
> +    (arguments (substitute-keyword-arguments (package-arguments
Add a newline after (arguments
> vte-with-gtk-4)
> +                 ((#:configure-flags flags
Drop the newline here.
> +                   #~'())
> +                  #~(cons* "-Dsixel=true"
> +                           #$flags))))
This can also be written in one line.
> +    (inputs (modify-inputs (package-inputs vte-with-gtk-4)
> +              (append lz4)
> +              (append libsixel))))))
> +
>  ;; Stable version for gtk2, required by gnurobots and lxterminal as
> of 2020-07.
>  (define-public vte/gtk+-2
>    (package (inherit vte)

For the record, vte is at 0.78 on gnome-team right now.  Maybe this
simplifies building a sixel variant?

Cheers
  

Patch

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 7339000436..598549fb94 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -79,6 +79,7 @@ 
 ;;; Copyright © 2023 Zhu Zihao <all_but_last@163.com>
 ;;; Copyright © 2024 Dariqq <dariqq@posteo.net>
 ;;; Copyright © 2024 James Smith <jsubuntuxp@disroot.org>
+;;; Copyright © 2024 Ashvith Shetty <ashvithshetty10@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4666,6 +4667,29 @@  (define-public vte-with-gtk-4
     (propagated-inputs (modify-inputs (package-propagated-inputs vte)
                          (replace "gtk+" gtk)))))
 
+(define-public vte-gtk-4-with-sixel
+    (let ((commit "4530d385191562d84f60066e168631fc1f45f3cc")
+          (revision "0"))
+  (package/inherit vte-with-gtk-4
+    (name "vte-gtk4-with-sixel")
+    (version (git-version "0.73.0" revision commit))
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://gitlab.gnome.org/GNOME/vte")
+                    (commit commit)))
+              (file-name (git-file-name name version))
+              (sha256 (base32
+                       "1z3pkpq0zjqzplq6mah68cwmcd1cr1ii2vp4nfppwmmn55mjapq0"))))
+    (arguments (substitute-keyword-arguments (package-arguments vte-with-gtk-4)
+                 ((#:configure-flags flags
+                   #~'())
+                  #~(cons* "-Dsixel=true"
+                           #$flags))))
+    (inputs (modify-inputs (package-inputs vte-with-gtk-4)
+              (append lz4)
+              (append libsixel))))))
+
 ;; Stable version for gtk2, required by gnurobots and lxterminal as of 2020-07.
 (define-public vte/gtk+-2
   (package (inherit vte)