[bug#76306] gnu: gnome-chess: Fix source URI.

Message ID 75cf3c09b9f2397e97e60021be5c163d10b01ce2.1739636352.git.vivien@planete-kraus.eu
State New
Headers
Series [bug#76306] gnu: gnome-chess: Fix source URI. |

Commit Message

Vivien Kraus Feb. 15, 2025, 4:26 p.m. UTC
  * gnu/packages/games.scm (gnome-chess): Update the source URI.

Change-Id: I1fb791e5b03e0841269e03634c7d31f9a4314d67
---
 gnu/packages/games.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 9a8fc85ab8e8c0946977d9bdbc1faf46de0a2c98
  

Comments

Leo Famulari Feb. 16, 2025, 12:16 a.m. UTC | #1
On Sat, Feb 15, 2025 at 05:26:37PM +0100, Vivien Kraus via Guix-patches via wrote:
> * gnu/packages/games.scm (gnome-chess): Update the source URI.

> -                                  (version-major+minor version)  "/"
> +                                  (version-major version)  "/"

Hm, I'm not sure. I applied the patch and tried building the gnome-chess
source:

------
$ ./pre-inst-env guix build -S gnome-chess --no-grafts --no-substitutes 
The following derivation will be built:
  /gnu/store/86myh2j4qrn2mljsqlgk45i8c6a0fx5d-gnome-chess-3.37.3.tar.xz.drv
building /gnu/store/86myh2j4qrn2mljsqlgk45i8c6a0fx5d-gnome-chess-3.37.3.tar.xz.drv...

Starting download of /gnu/store/x92xv7l8vzgamln7w36alwwa7y5fjbxl-gnome-chess-3.37.3.tar.xz
From https://download.gnome.org/sources/gnome-chess/3/gnome-chess-3.37.3.tar.xz...
download failed "https://download.gnome.org/sources/gnome-chess/3/gnome-chess-3.37.3.tar.xz" 404 "Not Found"

Starting download of /gnu/store/x92xv7l8vzgamln7w36alwwa7y5fjbxl-gnome-chess-3.37.3.tar.xz
From http://ftp.gnome.org/pub/GNOME/sources/gnome-chess/3/gnome-chess-3.37.3.tar.xz...
following redirection to `https://ftp.gnome.org/pub/GNOME/sources/gnome-chess/3/gnome-chess-3.37.3.tar.xz'...
following redirection to `https://download.gnome.org/sources/gnome-chess/3/gnome-chess-3.37.3.tar.xz'...
download failed "https://download.gnome.org/sources/gnome-chess/3/gnome-chess-3.37.3.tar.xz" 404 "Not Found"

Starting download of /gnu/store/x92xv7l8vzgamln7w36alwwa7y5fjbxl-gnome-chess-3.37.3.tar.xz
From https://bordeaux.guix.gnu.org/file/gnome-chess-3.37.3.tar.xz/sha256/09axf0q1mp13sv8cs0syfg8ahcd9r2qb26278r09j6s4njxmkfv4...
downloading from https://bordeaux.guix.gnu.org/file/gnome-chess-3.37.3.tar.xz/sha256/09axf0q1mp13sv8cs0syfg8ahcd9r2qb26278r09j6s4njxmkfv4 ...
 09axf0q1mp13sv8cs0syfg8ahcd9r2qb26278r09j6s4njxmkfv4  724KiB 362KiB/s 00:00 ▕█▌                09axf0q1mp13sv8cs0syfg8ahcd9r2qb26278r09j6s4njxmkfv4  724KiB 1010KiB/s 00:00 ▕█████████▌       09axf0q1mp13sv8cs0syfg8ahcd9r2qb26278r09j6s4njxmkfv4  724KiB 1.5MiB/s 00:00 ▕██████████████████▏ 100.0%
successfully built /gnu/store/86myh2j4qrn2mljsqlgk45i8c6a0fx5d-gnome-chess-3.37.3.tar.xz.drv
/gnu/store/x92xv7l8vzgamln7w36alwwa7y5fjbxl-gnome-chess-3.37.3.tar.xz
------

You can see the tarball was not available from GNOME, but was instead
found via content-addressing on a Guix server.

But without the patch, the tarball is found on the GNOME servers:

------
$ ./pre-inst-env guix build -S gnome-chess --no-grafts --no-substitutes           
The following derivation will be built:  
  /gnu/store/q10g29j7cnl4k3s9pivbrh6jnkkqf4vs-gnome-chess-3.37.3.tar.xz.drv
building /gnu/store/q10g29j7cnl4k3s9pivbrh6jnkkqf4vs-gnome-chess-3.37.3.tar.xz.drv...

Starting download of /gnu/store/x92xv7l8vzgamln7w36alwwa7y5fjbxl-gnome-chess-3.37.3.tar.xz
From https://download.gnome.org/sources/gnome-chess/3.37/gnome-chess-3.37.3.tar.xz...
downloading from https://download.gnome.org/sources/gnome-chess/3.37/gnome-chess-3.37.3.tar.xz ...
 gnome-chess-3.37.3.tar.xz  724KiB                                                                                                                    7.8MiB/s 00:00 ▕██████████████████▏ 100.0%
successfully built /gnu/store/q10g29j7cnl4k3s9pivbrh6jnkkqf4vs-gnome-chess-3.37.3.tar.xz.drv
/gnu/store/x92xv7l8vzgamln7w36alwwa7y5fjbxl-gnome-chess-3.37.3.tar.xz
------

And the upstream site does seem to organize things using the major and
minor versions:

https://download.gnome.org/sources/gnome-chess/
  
Vivien Kraus Feb. 16, 2025, 5:59 a.m. UTC | #2
Le samedi 15 février 2025 à 19:16 -0500, Leo Famulari a écrit :
> /gnu/store/86myh2j4qrn2mljsqlgk45i8c6a0fx5d-gnome-chess-
> 3.37.3.tar.xz.drv

I’m sorry, I have just set up mumi send-email (still not 100% working)
and it forgot to indicate it is intended for gnome-team. Should I send
a V2 with [PATCH gnome-team] in the subject?

Best regards,

Vivien
  
Liliana Marie Prikler Feb. 16, 2025, 6:20 a.m. UTC | #3
Am Samstag, dem 15.02.2025 um 19:16 -0500 schrieb Leo Famulari:
> On Sat, Feb 15, 2025 at 05:26:37PM +0100, Vivien Kraus via Guix-
> patches via wrote:
> > * gnu/packages/games.scm (gnome-chess): Update the source URI.
> 
> > -                                  (version-major+minor version) 
> > "/"
> > +                                  (version-major version)  "/"
> 
> Hm, I'm not sure. I applied the patch and tried building the gnome-
> chess source:
> […]
Yes gnome-chess and other packages that still use the "3.x.y" naming
scheme use major+minor.  If the major version is larger than 40, then
it'd be just major.

Cheers
  
Liliana Marie Prikler Feb. 16, 2025, 6:46 a.m. UTC | #4
Am Sonntag, dem 16.02.2025 um 06:59 +0100 schrieb Vivien Kraus:
> Le samedi 15 février 2025 à 19:16 -0500, Leo Famulari a écrit :
> > /gnu/store/86myh2j4qrn2mljsqlgk45i8c6a0fx5d-gnome-chess-
> > 3.37.3.tar.xz.drv
> 
> I’m sorry, I have just set up mumi send-email (still not 100%
> working) and it forgot to indicate it is intended for gnome-team.
> Should I send a V2 with [PATCH gnome-team] in the subject?
No need to, I pushed it just now.  Thanks for the clarification.

Cheers
  

Patch

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index b58fdcd315..de1472a0f7 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -2294,7 +2294,7 @@  (define-public gnome-chess
     (source (origin
               (method url-fetch)
               (uri (string-append "mirror://gnome/sources/gnome-chess/"
-                                  (version-major+minor version)  "/"
+                                  (version-major version)  "/"
                                   "gnome-chess-" version ".tar.xz"))
               (sha256
                (base32