| Message ID | 20190304111917.1981-2-hoonandon@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Update mate desktop to 1.20 | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparison |
| cbaines/applying patch | success | Successfully applied |
On Mon, Mar 04, 2019 at 12:18:47PM +0100, guy fleury iteriteka wrote: > --- > gnu/packages/mate.scm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gnu/packages/mate.scm b/gnu/packages/mate.scm > index ef94491..57a3ced 100644 > --- a/gnu/packages/mate.scm > +++ b/gnu/packages/mate.scm > @@ -73,7 +73,7 @@ > (define-public mate-common > (package > (name "mate-common") > - (version "1.18.0") > + (version "1.20.0") Thank you for these patches! I noticed that the commit messages are not complete, however. They are missing the section that describes the changes made in each file. For a patch like this, that simply updates the package with no other changes, you'd write the commit message like this: ------ gnu: mate-common: Update to 1.20.0. * gnu/packages/mate.scm (mate-common): Update to 1.20.0. ------ If there are other changes, they should be described as well. I recommend looking at our Git history for examples, or asking here on or IRC if you need help. Can you send an updated patch series? Normally, I would fix this sort of issue myself before pushing the patch, but there are too many patches in this case for me to do it. By the way, this style of commit logs is called the 'GNU Change Log' style and is documented here: https://www.gnu.org/prep/standards/html_node/Change-Logs.html
hi leo, thanks for your review, i sent the series patch in a tar archive(see attached file) to avoid duplicate . the only patch i change other than update version is : atril 0018-gnu-atril-Update-to-1.20.3.patch review this one i don't know if do thing well. Le ven. 15 mars 2019 à 18:12, Leo Famulari <leo@famulari.name> a écrit : > On Mon, Mar 04, 2019 at 12:18:47PM +0100, guy fleury iteriteka wrote: > > --- > > gnu/packages/mate.scm | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/gnu/packages/mate.scm b/gnu/packages/mate.scm > > index ef94491..57a3ced 100644 > > --- a/gnu/packages/mate.scm > > +++ b/gnu/packages/mate.scm > > @@ -73,7 +73,7 @@ > > (define-public mate-common > > (package > > (name "mate-common") > > - (version "1.18.0") > > + (version "1.20.0") > > Thank you for these patches! > > I noticed that the commit messages are not complete, however. They are > missing the section that describes the changes made in each file. > > For a patch like this, that simply updates the package with no other > changes, you'd write the commit message like this: > > ------ > gnu: mate-common: Update to 1.20.0. > > * gnu/packages/mate.scm (mate-common): Update to 1.20.0. > ------ > > If there are other changes, they should be described as well. > > I recommend looking at our Git history for examples, or asking here on > or IRC if you need help. Can you send an updated patch series? > > Normally, I would fix this sort of issue myself before pushing the > patch, but there are too many patches in this case for me to do it. > > By the way, this style of commit logs is called the 'GNU Change Log' > style and is documented here: > > https://www.gnu.org/prep/standards/html_node/Change-Logs.html > -----BEGIN PGP SIGNATURE----- > > iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlyL3OUACgkQJkb6MLrK > fwj1pBAAhyLxi0EFxJS4OSPmhr8mhaoP/R9q3gj2w4GDAvGaHplmK9mrs9k31p2p > 0tFjzqzsnq5T8QdGgDCwpQAx37l/IUU7U7EqFaVOkGtNA1sStF6Tot5mSXqFye3C > zcAc1CAPD7GB69FFK9Tdwd1FuPglmhu3+Cf+SpMqnaG58V8Tdz1xKYn0Xa6sA7SX > mSEFHzmUZYCvQURxvDHUkABEx1LqHHTFgnANvrFQP81nI8jR1zg5G7w5MNIEL6H7 > zGSgnktTCd3W+LPHUL1adHItMfrNfGpvFXONnukiSatYygp5KIm4iQkAtDBaTei+ > u3nbfIyFCgX4g3zEuPMjm0UDKb0Q1yU4FX0ahYF1oQ58CT5wxobifgqnnWYY/b7s > 6bBkzFjqUWjL8zwAlIICgmVW+sSzv63r7Izy96pw0VIrA803gwS4gurcImErxPaJ > R9ImaYCveQjWPFrkY8gKSmXCvhThaVoiBlwEnPjHjRTHtUk4wDK/AfD6M+vTt067 > JxahlnJ8z2mwf5EUBYI4yZNCZ+YcKHf83AU28/+4LDhcOihkB1qzqRxZjtJZlezD > gtWml2ElNubeTNkcT4q8UBilTmQUTgGKz/UEzVAAooR54wvOfzYniWTGxYfnYy4u > iCa/3zH9R6jJZJ+4nAS3TI1tZfOu4NhALNznocv8A0YmgN+Toag= > =CeZG > -----END PGP SIGNATURE----- >
Hi leo, Since my last series patch, MATE Desktop version 1.22 have been released i want to work on this recent version. i don't know if we can drop those series and i will send a updated series patch of version 1.22 in a few day. what do you think? Le sam. 16 mars 2019 à 09:36, Guy fleury <hoonandon@gmail.com> a écrit : > hi leo, > > thanks for your review, i sent the series patch in a tar archive(see > attached file) > to avoid duplicate . > > the only patch i change other than update version is : atril > 0018-gnu-atril-Update-to-1.20.3.patch > review this one i don't know if do thing well. > > Le ven. 15 mars 2019 à 18:12, Leo Famulari <leo@famulari.name> a écrit : > >> On Mon, Mar 04, 2019 at 12:18:47PM +0100, guy fleury iteriteka wrote: >> > --- >> > gnu/packages/mate.scm | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/gnu/packages/mate.scm b/gnu/packages/mate.scm >> > index ef94491..57a3ced 100644 >> > --- a/gnu/packages/mate.scm >> > +++ b/gnu/packages/mate.scm >> > @@ -73,7 +73,7 @@ >> > (define-public mate-common >> > (package >> > (name "mate-common") >> > - (version "1.18.0") >> > + (version "1.20.0") >> >> Thank you for these patches! >> >> I noticed that the commit messages are not complete, however. They are >> missing the section that describes the changes made in each file. >> >> For a patch like this, that simply updates the package with no other >> changes, you'd write the commit message like this: >> >> ------ >> gnu: mate-common: Update to 1.20.0. >> >> * gnu/packages/mate.scm (mate-common): Update to 1.20.0. >> ------ >> >> If there are other changes, they should be described as well. >> >> I recommend looking at our Git history for examples, or asking here on >> or IRC if you need help. Can you send an updated patch series? >> >> Normally, I would fix this sort of issue myself before pushing the >> patch, but there are too many patches in this case for me to do it. >> >> By the way, this style of commit logs is called the 'GNU Change Log' >> style and is documented here: >> >> https://www.gnu.org/prep/standards/html_node/Change-Logs.html >> -----BEGIN PGP SIGNATURE----- >> >> iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlyL3OUACgkQJkb6MLrK >> fwj1pBAAhyLxi0EFxJS4OSPmhr8mhaoP/R9q3gj2w4GDAvGaHplmK9mrs9k31p2p >> 0tFjzqzsnq5T8QdGgDCwpQAx37l/IUU7U7EqFaVOkGtNA1sStF6Tot5mSXqFye3C >> zcAc1CAPD7GB69FFK9Tdwd1FuPglmhu3+Cf+SpMqnaG58V8Tdz1xKYn0Xa6sA7SX >> mSEFHzmUZYCvQURxvDHUkABEx1LqHHTFgnANvrFQP81nI8jR1zg5G7w5MNIEL6H7 >> zGSgnktTCd3W+LPHUL1adHItMfrNfGpvFXONnukiSatYygp5KIm4iQkAtDBaTei+ >> u3nbfIyFCgX4g3zEuPMjm0UDKb0Q1yU4FX0ahYF1oQ58CT5wxobifgqnnWYY/b7s >> 6bBkzFjqUWjL8zwAlIICgmVW+sSzv63r7Izy96pw0VIrA803gwS4gurcImErxPaJ >> R9ImaYCveQjWPFrkY8gKSmXCvhThaVoiBlwEnPjHjRTHtUk4wDK/AfD6M+vTt067 >> JxahlnJ8z2mwf5EUBYI4yZNCZ+YcKHf83AU28/+4LDhcOihkB1qzqRxZjtJZlezD >> gtWml2ElNubeTNkcT4q8UBilTmQUTgGKz/UEzVAAooR54wvOfzYniWTGxYfnYy4u >> iCa/3zH9R6jJZJ+4nAS3TI1tZfOu4NhALNznocv8A0YmgN+Toag= >> =CeZG >> -----END PGP SIGNATURE----- >> >
Hi guix, This series can be closed. Updated patch start at 35087@debbugs.gnu.org Le 24 mars 2019 11:50, "Guy fleury" <hoonandon@gmail.com> a écrit : > Hi leo, > > Since my last series patch, MATE Desktop version 1.22 have been released > i want to work on this recent version. > > i don't know if we can drop those series and i will send a updated series > patch > of version 1.22 in a few day. > > what do you think? > > Le sam. 16 mars 2019 à 09:36, Guy fleury <hoonandon@gmail.com> a écrit : > >> hi leo, >> >> thanks for your review, i sent the series patch in a tar archive(see >> attached file) >> to avoid duplicate . >> >> the only patch i change other than update version is : atril >> 0018-gnu-atril-Update-to-1.20.3.patch >> review this one i don't know if do thing well. >> >> Le ven. 15 mars 2019 à 18:12, Leo Famulari <leo@famulari.name> a écrit : >> >>> On Mon, Mar 04, 2019 at 12:18:47PM +0100, guy fleury iteriteka wrote: >>> > --- >>> > gnu/packages/mate.scm | 4 ++-- >>> > 1 file changed, 2 insertions(+), 2 deletions(-) >>> > >>> > diff --git a/gnu/packages/mate.scm b/gnu/packages/mate.scm >>> > index ef94491..57a3ced 100644 >>> > --- a/gnu/packages/mate.scm >>> > +++ b/gnu/packages/mate.scm >>> > @@ -73,7 +73,7 @@ >>> > (define-public mate-common >>> > (package >>> > (name "mate-common") >>> > - (version "1.18.0") >>> > + (version "1.20.0") >>> >>> Thank you for these patches! >>> >>> I noticed that the commit messages are not complete, however. They are >>> missing the section that describes the changes made in each file. >>> >>> For a patch like this, that simply updates the package with no other >>> changes, you'd write the commit message like this: >>> >>> ------ >>> gnu: mate-common: Update to 1.20.0. >>> >>> * gnu/packages/mate.scm (mate-common): Update to 1.20.0. >>> ------ >>> >>> If there are other changes, they should be described as well. >>> >>> I recommend looking at our Git history for examples, or asking here on >>> or IRC if you need help. Can you send an updated patch series? >>> >>> Normally, I would fix this sort of issue myself before pushing the >>> patch, but there are too many patches in this case for me to do it. >>> >>> By the way, this style of commit logs is called the 'GNU Change Log' >>> style and is documented here: >>> >>> https://www.gnu.org/prep/standards/html_node/Change-Logs.html >>> -----BEGIN PGP SIGNATURE----- >>> >>> iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlyL3OUACgkQJkb6MLrK >>> fwj1pBAAhyLxi0EFxJS4OSPmhr8mhaoP/R9q3gj2w4GDAvGaHplmK9mrs9k31p2p >>> 0tFjzqzsnq5T8QdGgDCwpQAx37l/IUU7U7EqFaVOkGtNA1sStF6Tot5mSXqFye3C >>> zcAc1CAPD7GB69FFK9Tdwd1FuPglmhu3+Cf+SpMqnaG58V8Tdz1xKYn0Xa6sA7SX >>> mSEFHzmUZYCvQURxvDHUkABEx1LqHHTFgnANvrFQP81nI8jR1zg5G7w5MNIEL6H7 >>> zGSgnktTCd3W+LPHUL1adHItMfrNfGpvFXONnukiSatYygp5KIm4iQkAtDBaTei+ >>> u3nbfIyFCgX4g3zEuPMjm0UDKb0Q1yU4FX0ahYF1oQ58CT5wxobifgqnnWYY/b7s >>> 6bBkzFjqUWjL8zwAlIICgmVW+sSzv63r7Izy96pw0VIrA803gwS4gurcImErxPaJ >>> R9ImaYCveQjWPFrkY8gKSmXCvhThaVoiBlwEnPjHjRTHtUk4wDK/AfD6M+vTt067 >>> JxahlnJ8z2mwf5EUBYI4yZNCZ+YcKHf83AU28/+4LDhcOihkB1qzqRxZjtJZlezD >>> gtWml2ElNubeTNkcT4q8UBilTmQUTgGKz/UEzVAAooR54wvOfzYniWTGxYfnYy4u >>> iCa/3zH9R6jJZJ+4nAS3TI1tZfOu4NhALNznocv8A0YmgN+Toag= >>> =CeZG >>> -----END PGP SIGNATURE----- >>> >>
Hi Guy, Guy fleury <hoonandon@gmail.com> skribis: > This series can be closed. > Updated patch start at > 35087@debbugs.gnu.org Closing! (To close an issue, just email NNN-done@debbugs.gnu.org where NNN is the issue number.) Ludo’.
diff --git a/gnu/packages/mate.scm b/gnu/packages/mate.scm index ef94491..57a3ced 100644 --- a/gnu/packages/mate.scm +++ b/gnu/packages/mate.scm @@ -73,7 +73,7 @@ (define-public mate-common (package (name "mate-common") - (version "1.18.0") + (version "1.20.0") (source (origin (method url-fetch) @@ -82,7 +82,7 @@ name "-" version ".tar.xz")) (sha256 (base32 - "1005laf3z1h8qczm7pmwr40r842665cv6ykhjg7r93vldra48z6p")))) + "0h8s2qhc6f5flslx05cd3xxg243c67vv03spjiag14p8kqqrqvb1")))) (build-system gnu-build-system) (home-page "https://mate-desktop.org/") (synopsis "Common files for development of MATE packages")