diff mbox series

[bug#68258,1/7] services: openssh: Add dependency on ‘networking’.

Message ID d537001d43ef4a003895b721b983da092e6c2e55.1704451578.git.ludo@gnu.org
State New
Headers
Series Upgrading Shepherd and moving the Hurd to 0.10.x |

Commit Message

Ludovic Courtès Jan. 5, 2024, 10:56 a.m. UTC 
* gnu/services/ssh.scm (openssh-shepherd-service): Add ‘networking’ to
‘requirement’.

Change-Id: I14c48fe40cce86810a544de6bb7f925bc360653a
---
 gnu/services/ssh.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Janneke Nieuwenhuizen Jan. 5, 2024, 6 p.m. UTC | #1 
Ludovic Courtès writes:

> * gnu/services/ssh.scm (openssh-shepherd-service): Add ‘networking’ to
> ‘requirement’.
> +         ;; On the Hurd, this can only be started after pfinet is up, hence
> +         ;; the dependency on 'networking'.
> +         (requirement '(pam syslogd loopback networking))
>           (provision '(ssh-daemon ssh sshd))

This could be real nice.  On QEMU it always worked nicely for me, but on
bare iron, ssh would start too soon and fail and need a manual
[re]start.

Greetings,
Janneke
diff mbox series

Patch

diff --git a/gnu/services/ssh.scm b/gnu/services/ssh.scm
index 0abecd6b42..f759c5cf6e 100644
--- a/gnu/services/ssh.scm
+++ b/gnu/services/ssh.scm
@@ -1,5 +1,5 @@ 
 ;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2014-2019, 2022, 2023 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2014-2019, 2022-2024 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2016 David Craven <david@craven.ch>
 ;;; Copyright © 2016 Julien Lepiller <julien@lepiller.eu>
 ;;; Copyright © 2017 Clément Lassieur <clement@lassieur.org>
@@ -592,7 +592,10 @@  (define (openssh-shepherd-service config)
 
   (list (shepherd-service
          (documentation "OpenSSH server.")
-         (requirement '(pam syslogd loopback))
+
+         ;; On the Hurd, this can only be started after pfinet is up, hence
+         ;; the dependency on 'networking'.
+         (requirement '(pam syslogd loopback networking))
          (provision '(ssh-daemon ssh sshd))
 
          (start #~(if #$inetd-style?