| Message ID | 7c09a597a23276e1987898022ff7f0e145c9fd8a.1702194739.git.efraim@flashner.co.il |
|---|---|
| State | New |
| Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 8AC7227BBEA; Sun, 10 Dec 2023 07:54:01 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id CA4AD27BBE2 for <patchwork@mira.cbaines.net>; Sun, 10 Dec 2023 07:53:59 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1rCEdM-0002sC-OL; Sun, 10 Dec 2023 02:53:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rCEdJ-0002qq-6a for guix-patches@gnu.org; Sun, 10 Dec 2023 02:53:49 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rCEdI-0000Ab-UK for guix-patches@gnu.org; Sun, 10 Dec 2023 02:53:48 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rCEdW-00023k-TI for guix-patches@gnu.org; Sun, 10 Dec 2023 02:54:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67742] [PATCH] gnu: ci: Build tuned packages for common baselines. Resent-From: Efraim Flashner <efraim@flashner.co.il> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 10 Dec 2023 07:54:02 +0000 Resent-Message-ID: <handler.67742.B.17021948057845@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67742 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 67742@debbugs.gnu.org Cc: ludo@gnu.org, Efraim Flashner <efraim@flashner.co.il> X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17021948057845 (code B ref -1); Sun, 10 Dec 2023 07:54:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Dec 2023 07:53:25 +0000 Received: from localhost ([127.0.0.1]:49414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1rCEcv-00022T-4e for submit@debbugs.gnu.org; Sun, 10 Dec 2023 02:53:25 -0500 Received: from lists.gnu.org ([2001:470:142::17]:53210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <efraim.flashner@gmail.com>) id 1rCEcq-00022A-J7 for submit@debbugs.gnu.org; Sun, 10 Dec 2023 02:53:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <efraim.flashner@gmail.com>) id 1rCEcV-0002ep-7e for guix-patches@gnu.org; Sun, 10 Dec 2023 02:52:59 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <efraim.flashner@gmail.com>) id 1rCEcT-0008Vw-DU; Sun, 10 Dec 2023 02:52:58 -0500 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40c31f18274so27909215e9.0; Sat, 09 Dec 2023 23:52:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702194775; x=1702799575; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=d19G7faAOh12EkfgpsHVCN230japR+LFoKImdAWS9uc=; b=fKxhu3WnUfXsIfWw+hzuLiZNxRxTykWlupNRRDGt2P4nsmNvxtywwtiefsB/3zFdIg uIIPXk1AiKcfM2EGpR4R6cGZJ2HwS7ZXHpNlVnvAUO/4WYrgIhBRsMp5T79ypr6AEqYy NveetLiBTVNFs3Et9GDTQ8uO0pQBNYEKRCWkhofYY+NmGOdEh1eaSOofSjrvgnp7PRAr leSejupK43fsKhSUazl7LH/rXVhc4+X2vFwkO/BXFDbJear5ZpFL3hZE+TmB5bEQK6E5 tZzL/j3GbQQVa5lfvoUty5IJbVn0cC5b9k7RAiJvB2viW3+aYr2Kv4AFTbhySCQpl0Ay d53A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702194775; x=1702799575; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=d19G7faAOh12EkfgpsHVCN230japR+LFoKImdAWS9uc=; b=uVINiYjbic8cToTxNPCAt4eWYMWD3Ot+XV0ic2L9MzIEeGLRreu0xKNIkePEjLk3CT 1KUn1fp4YqHcLOpnYJsTGgiBUI7xsGsdpL5jYHPIBOm4LpSJW3PL+Skjh3Q5prLyTJNo X27kmf2gmvAcJVwV/lnhjxrbk46WA71M8mOIun5AuMsQXiv91d7tDD0f9yuxyTfVuAY5 lK6GED/4+/9kVFfBW2mbXV4Y0GaNP21B7PHS0tytYBh3nBWiAuGekPHGm/wQ+wmXyLF7 M5ZbxGnf0d4SGRCT+78qgYDCHPjE9kVG2K1ZZrISHWuGChg1Huw0ch5SGPDvynntfqXH Gr8Q== X-Gm-Message-State: AOJu0YwYfa+ELGk0tvgEMbAYdKigkn2K9CrbCytjU7aOyUt5Tw6XUyKQ XiRUS0xkqATdkZeXfZOh/WUnvyeS262D7w== X-Google-Smtp-Source: AGHT+IFCo7vLdNQLaaSJHH59cPfLa+1EwPQdwQt64G86qYos2n9C5ZcmbAPoSzfpmWAmZWcmvU8kBQ== X-Received: by 2002:a05:600c:492f:b0:40b:5e21:bdb1 with SMTP id f47-20020a05600c492f00b0040b5e21bdb1mr1201717wmp.64.1702194775228; Sat, 09 Dec 2023 23:52:55 -0800 (PST) Received: from localhost ([188.120.129.233]) by smtp.gmail.com with ESMTPSA id bg32-20020a05600c3ca000b0040b3e7569fcsm11113790wmb.11.2023.12.09.23.52.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Dec 2023 23:52:54 -0800 (PST) From: Efraim Flashner <efraim@flashner.co.il> Date: Sun, 10 Dec 2023 09:52:42 +0200 Message-ID: <7c09a597a23276e1987898022ff7f0e145c9fd8a.1702194739.git.efraim@flashner.co.il> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=efraim.flashner@gmail.com; helo=mail-wm1-x333.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
| Series |
[bug#67742] gnu: ci: Build tuned packages for common baselines.
|
|
Commit Message
Efraim Flashner
Dec. 10, 2023, 7:52 a.m. UTC
* gnu/ci.scm (%x86-64-micro-architectures): Replace specific micro-architectures with generic ones. Change-Id: Iee2f65376a00ad2ee5fb393c2e64c07f866d8116 --- gnu/ci.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 9c30fb27a42bf10a733ef5165df7869588f0b27c
Comments
Hi, Efraim Flashner <efraim@flashner.co.il> skribis: > * gnu/ci.scm (%x86-64-micro-architectures): Replace specific > micro-architectures with generic ones. > > Change-Id: Iee2f65376a00ad2ee5fb393c2e64c07f866d8116 > --- > gnu/ci.scm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gnu/ci.scm b/gnu/ci.scm > index 279dd4d910..5c093ae135 100644 > --- a/gnu/ci.scm > +++ b/gnu/ci.scm > @@ -372,7 +372,7 @@ (define package->job > > (define %x86-64-micro-architectures > ;; Micro-architectures for which we build tuned variants. > - '("westmere" "ivybridge" "haswell" "skylake" "skylake-avx512")) > + '("x86-64-v2" "x86-64-v3" "x86-64-v4")) Right now, on my laptop, I get: --8<---------------cut here---------------start------------->8--- $ guix build gsl -n --tune guix build: tuning gsl@2.7.1 for CPU skylake substitute: updating substitutes from 'http://192.168.1.48:8123'... 100.0% substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0% 1.5 MB would be downloaded: /gnu/store/kx060kry6ka7khzganfcqk98agqp226i-gsl-2.7.1 $ guix describe Generation 284 Dec 10 2023 23:34:41 (current) guix a90bc8b repository URL: https://git.savannah.gnu.org/git/guix.git branch: master commit: a90bc8b6a82e094b10488030532cf4cd690ce57e --8<---------------cut here---------------end--------------->8--- Which is nice! With the proposed change, I’d no longer get substitutes. So perhaps we could keep the common Intel variants in addition to the SysV psABI generic names? Maybe we can drop “westmere” now since it’s relatively old. WDYT? Ludo’.
On Mon, Dec 11, 2023 at 10:37:26PM +0100, Ludovic Courtès wrote: > Hi, > > Efraim Flashner <efraim@flashner.co.il> skribis: > > > * gnu/ci.scm (%x86-64-micro-architectures): Replace specific > > micro-architectures with generic ones. > > > > Change-Id: Iee2f65376a00ad2ee5fb393c2e64c07f866d8116 > > --- > > gnu/ci.scm | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/gnu/ci.scm b/gnu/ci.scm > > index 279dd4d910..5c093ae135 100644 > > --- a/gnu/ci.scm > > +++ b/gnu/ci.scm > > @@ -372,7 +372,7 @@ (define package->job > > > > (define %x86-64-micro-architectures > > ;; Micro-architectures for which we build tuned variants. > > - '("westmere" "ivybridge" "haswell" "skylake" "skylake-avx512")) > > + '("x86-64-v2" "x86-64-v3" "x86-64-v4")) > > Right now, on my laptop, I get: > > --8<---------------cut here---------------start------------->8--- > $ guix build gsl -n --tune > guix build: tuning gsl@2.7.1 for CPU skylake > substitute: updating substitutes from 'http://192.168.1.48:8123'... 100.0% > substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0% > 1.5 MB would be downloaded: > /gnu/store/kx060kry6ka7khzganfcqk98agqp226i-gsl-2.7.1 > $ guix describe > Generation 284 Dec 10 2023 23:34:41 (current) > guix a90bc8b > repository URL: https://git.savannah.gnu.org/git/guix.git > branch: master > commit: a90bc8b6a82e094b10488030532cf4cd690ce57e > --8<---------------cut here---------------end--------------->8--- > > Which is nice! > > With the proposed change, I’d no longer get substitutes. > > So perhaps we could keep the common Intel variants in addition to the > SysV psABI generic names? > > Maybe we can drop “westmere” now since it’s relatively old. I'm not sure how we'd determine what would count as common. I think if we added a '--tune=close-enough' and used cpu->micro-architecture-level or gcc-architecture->micro-architecture-level from (guix cpu) to choose x86_64-v[234] that would count more as common than the list above :P. westmere and ivybridge didn't make the cut in (guix cpu), so they'd never get chosen from '--tune'.
Hello, Efraim Flashner <efraim@flashner.co.il> skribis: > On Mon, Dec 11, 2023 at 10:37:26PM +0100, Ludovic Courtès wrote: [...] >> > (define %x86-64-micro-architectures >> > ;; Micro-architectures for which we build tuned variants. >> > - '("westmere" "ivybridge" "haswell" "skylake" "skylake-avx512")) >> > + '("x86-64-v2" "x86-64-v3" "x86-64-v4")) >> >> Right now, on my laptop, I get: >> >> --8<---------------cut here---------------start------------->8--- >> $ guix build gsl -n --tune >> guix build: tuning gsl@2.7.1 for CPU skylake [...] > I'm not sure how we'd determine what would count as common. I think if > we added a '--tune=close-enough' and used cpu->micro-architecture-level > or gcc-architecture->micro-architecture-level from (guix cpu) to choose > x86_64-v[234] that would count more as common than the list above :P. Sure, but that’s not the case yet: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix build gsl --tune -n guix build: tuning gsl@2.7.1 for CPU skylake 1.5 MB would be downloaded: /gnu/store/kx060kry6ka7khzganfcqk98agqp226i-gsl-2.7.1 --8<---------------cut here---------------end--------------->8--- So my suggestion was something like this: (define %x86-64-micro-architectures ;; Micro-architectures for which we build tuned variants. '("ivybridge" "haswell" "skylake" "skylake-avx512" "x86-64-v2" "x86-64-v3" "x86-64-v4")) … so we don’t lose substitutes for “common” architectures. Alternatively, we can go towards using x86-64-v* only, but in that case we need to adjust the way ‘--tune’ (without arguments) guesses the target architecture. WDYT? Ludo’.
Hi, Bump ... did you'a'll you'a'll decide what to do here? Futurile
diff --git a/gnu/ci.scm b/gnu/ci.scm index 279dd4d910..5c093ae135 100644 --- a/gnu/ci.scm +++ b/gnu/ci.scm @@ -372,7 +372,7 @@ (define package->job (define %x86-64-micro-architectures ;; Micro-architectures for which we build tuned variants. - '("westmere" "ivybridge" "haswell" "skylake" "skylake-avx512")) + '("x86-64-v2" "x86-64-v3" "x86-64-v4")) (define (tuned-package-jobs store package system) "Return a list of jobs for PACKAGE tuned for SYSTEM's micro-architectures."