diff mbox series

[bug#34523] Add tetrinet

Message ID E1gw0Be-0006uJ-6i@rmmprod05.runbox
State Accepted
Headers show
Series [bug#34523] Add tetrinet | expand

Checks

Context Check Description
cbaines/applying patch fail Apply failed

Commit Message

pkill9 Feb. 19, 2019, 7:51 a.m. UTC 
I've attached an updated patch with the modifications suggested so far:

 - Changed license from expat to public-domain
 - Changed "No tests" to lowercase "no tests"
 - Added "no configure file" comment
 - Install Readme files

I indent the package definition in emacs by marking the package definition (CTRL+Space) and running `M-x indent-region`, I'm not sure what indentation was wrong with the original patch I submitted, but I ran indent-region on it again anyway.

On Mon, 18 Feb 2019 15:11:37 +0100, Tobias Geerinckx-Rice <me@tobias.gr> wrote:

> pkill -9, Ricardo,
> 
> Ricardo Wurmus wrote:
> > pkill9@runbox.com writes:
> >> +     `(#:tests? #f ; No tests.
> 
> Only nitpicks:
> 
> +     `(#:tests? #f                      ; no tests
> 
> If you're using emacs, running C-M-q on the whole definition will 
> automatically indent your code.  There's a way to do the same 
> without emacs, but I forget how.
> 
> >> +       #:phases (modify-phases %standard-phases
> >> +                  (delete 'configure)
> 
> +                  (delete 'configure)   ; no configure script
> 
> >> +                  (add-after 'unpack 'fix-install-dir
> >> +                    (lambda* (#:key outputs 
> >> #:allow-other-keys)
> >> +                      (let ((out (assoc-ref outputs "out")))
> >> +                        (mkdir-p (string-append out "/bin"))
> >> +                        (substitute* "Makefile"
> >> +                          (("/usr/games") (string-append out 
> >> "/bin")))))))))
> >
> > Can this patching be avoided by passing a make flag instead?
> 
> Nope, it's hard-coded in the Makefile target :-(
> 
> Considering the lack of a man(ual) page, how about adding 
> something like:
> 
>   (add-after 'install 'install-documentation
>     (lambda* (#:key outputs #:allow-other-keys)
>       (let* ((out (assoc-ref outputs "out"))
>              (doc (string-append out "/share/doc/"
>                                  ,name "-" ,version)))
>         (for-each (lambda (file)
>                     (install-file file doc))
>                   (list "README" "tetrinet.txt"))
>         #t))))))
> 
> Thanks!
> 
> T G-R

Comments

swedebugia Feb. 23, 2019, 6:23 a.m. UTC | #1 
On 2019-02-23 10:26, swedebugia wrote:
> For the sake of making it easy to find when searching synopsies I
> suggest you add "game" to the end of yours.
> -- 
> Sent from my k-9 mail for Android.

having looked it up online I prefer the WP synopsis:
"TetriNET is a console multiplayer online Tetris game for up to six people."

There is a gnome version also. We should state clearly that this is a
console/text-mode client.

As an aside I did not find a working server anywhere and the homepage of
the project is dead. There is a possibility to host your own server with
jetrix though.

There could be trademark issues with the name/game also see
https://en.wikipedia.org/wiki/The_Tetris_Company
swedebugia Feb. 23, 2019, 9:26 a.m. UTC | #2 
For the sake of making it easy to find when searching synopsies I suggest you add "game" to the end of yours.
pkill9 Feb. 26, 2019, 3:20 p.m. UTC | #3 
Hi Swedebugia,

> having looked it up online I prefer the WP synopsis:
> "TetriNET is a console multiplayer online Tetris game for up to six people."
> 
> There is a gnome version also. We should state clearly that this is a
> console/text-mode client.

What does 'WP' mean?

> As an aside I did not find a working server anywhere and the homepage of
> the project is dead. There is a possibility to host your own server with
> jetrix though.

I played Tetrinet with someone over a server, but I can't remember what the address was.

You can't access the homepage of the project? I can access http://tetrinet.or.cz fine. Or do you mean it hasn't been updated in ages?

> There could be trademark issues with the name/game also see
> https://en.wikipedia.org/wiki/The_Tetris_Company

Regarding the potential trademark issues, both FSF-approved distros Parabola and PureOS have Tetrinet in their repositories[1][2], so I think it would be acceptable to add it to Guix. And if a copyright claim is made in the future it can always be removed.

[1] Tetrinet in Parabola - https://www.parabola.nu/packages/?q=tetrinet
[2] Tetrinet in PureOS - https://software.pureos.net/search_pkg?term=tetrinet

Thanks

On Sat, 23 Feb 2019 07:23:43 +0100, swedebugia <swedebugia@riseup.net> wrote:

> On 2019-02-23 10:26, swedebugia wrote:
> > For the sake of making it easy to find when searching synopsies I
> > suggest you add "game" to the end of yours.
> > -- 
> > Sent from my k-9 mail for Android.
> 
> having looked it up online I prefer the WP synopsis:
> "TetriNET is a console multiplayer online Tetris game for up to six people."
> 
> There is a gnome version also. We should state clearly that this is a
> console/text-mode client.
> 
> As an aside I did not find a working server anywhere and the homepage of
> the project is dead. There is a possibility to host your own server with
> jetrix though.
> 
> There could be trademark issues with the name/game also see
> https://en.wikipedia.org/wiki/The_Tetris_Company
> 
> -- 
> Cheers Swedebugia
swedebugia Feb. 26, 2019, 8:45 p.m. UTC | #4 
pkill9@runbox.com skrev: (26 februari 2019 16:20:28 CET)
>Hi Swedebugia,
>
>> having looked it up online I prefer the WP synopsis:
>> "TetriNET is a console multiplayer online Tetris game for up to six
>people."
>> 
>> There is a gnome version also. We should state clearly that this is a
>> console/text-mode client.
>
>What does 'WP' mean?
>
>> As an aside I did not find a working server anywhere and the homepage
>of
>> the project is dead. There is a possibility to host your own server
>with
>> jetrix though.
>
>I played Tetrinet with someone over a server, but I can't remember what
>the address was.
>
>You can't access the homepage of the project? I can access
>http://tetrinet.or.cz fine. Or do you mean it hasn't been updated in
>ages?
>
>> There could be trademark issues with the name/game also see
>> https://en.wikipedia.org/wiki/The_Tetris_Company
>
>Regarding the potential trademark issues, both FSF-approved distros
>Parabola and PureOS have Tetrinet in their repositories[1][2], so I
>think it would be acceptable to add it to Guix. And if a copyright
>claim is made in the future it can always be removed.
>
>[1] Tetrinet in Parabola - https://www.parabola.nu/packages/?q=tetrinet
>[2] Tetrinet in PureOS -
>https://software.pureos.net/search_pkg?term=tetrinet
>
>Thanks
>
>On Sat, 23 Feb 2019 07:23:43 +0100, swedebugia <swedebugia@riseup.net>
>wrote:
>
>> On 2019-02-23 10:26, swedebugia wrote:
>> > For the sake of making it easy to find when searching synopsies I
>> > suggest you add "game" to the end of yours.
>> > -- 
>> > Sent from my k-9 mail for Android.
>> 
>> having looked it up online I prefer the WP synopsis:
>> "TetriNET is a console multiplayer online Tetris game for up to six
>people."
>> 
>> There is a gnome version also. We should state clearly that this is a
>> console/text-mode client.
>> 
>> As an aside I did not find a working server anywhere and the homepage
>of
>> the project is dead. There is a possibility to host your own server
>with
>> jetrix though.
>> 
>> There could be trademark issues with the name/game also see
>> https://en.wikipedia.org/wiki/The_Tetris_Company
>> 
>> -- 
>> Cheers Swedebugia

Hi 
I agree with your remarks
WP = wikipedia 

Given that there is no pgp signed tarball or even a checksum on that page,  have you asked the maintainer about this and verified that you got the code unaltered?
pkill9 Feb. 27, 2019, 7:10 a.m. UTC | #5 
> Given that there is no pgp signed tarball or even a checksum on that page,  have you asked the maintainer about this and verified that you got the code unaltered? 

Ok I emailed the current maintainer according to that page asking to verify that I got the source code unaltered, and to maybe update the page with that info.

On Tue, 26 Feb 2019 21:45:23 +0100, swedebugia <swedebugia@riseup.net> wrote:

> pkill9@runbox.com skrev: (26 februari 2019 16:20:28 CET)
> >Hi Swedebugia,
> >
> >> having looked it up online I prefer the WP synopsis:
> >> "TetriNET is a console multiplayer online Tetris game for up to six
> >people."
> >> 
> >> There is a gnome version also. We should state clearly that this is a
> >> console/text-mode client.
> >
> >What does 'WP' mean?
> >
> >> As an aside I did not find a working server anywhere and the homepage
> >of
> >> the project is dead. There is a possibility to host your own server
> >with
> >> jetrix though.
> >
> >I played Tetrinet with someone over a server, but I can't remember what
> >the address was.
> >
> >You can't access the homepage of the project? I can access
> >http://tetrinet.or.cz fine. Or do you mean it hasn't been updated in
> >ages?
> >
> >> There could be trademark issues with the name/game also see
> >> https://en.wikipedia.org/wiki/The_Tetris_Company
> >
> >Regarding the potential trademark issues, both FSF-approved distros
> >Parabola and PureOS have Tetrinet in their repositories[1][2], so I
> >think it would be acceptable to add it to Guix. And if a copyright
> >claim is made in the future it can always be removed.
> >
> >[1] Tetrinet in Parabola - https://www.parabola.nu/packages/?q=tetrinet
> >[2] Tetrinet in PureOS -
> >https://software.pureos.net/search_pkg?term=tetrinet
> >
> >Thanks
> >
> >On Sat, 23 Feb 2019 07:23:43 +0100, swedebugia <swedebugia@riseup.net>
> >wrote:
> >
> >> On 2019-02-23 10:26, swedebugia wrote:
> >> > For the sake of making it easy to find when searching synopsies I
> >> > suggest you add "game" to the end of yours.
> >> > -- 
> >> > Sent from my k-9 mail for Android.
> >> 
> >> having looked it up online I prefer the WP synopsis:
> >> "TetriNET is a console multiplayer online Tetris game for up to six
> >people."
> >> 
> >> There is a gnome version also. We should state clearly that this is a
> >> console/text-mode client.
> >> 
> >> As an aside I did not find a working server anywhere and the homepage
> >of
> >> the project is dead. There is a possibility to host your own server
> >with
> >> jetrix though.
> >> 
> >> There could be trademark issues with the name/game also see
> >> https://en.wikipedia.org/wiki/The_Tetris_Company
> >> 
> >> -- 
> >> Cheers Swedebugia
> 
> Hi 
> I agree with your remarks
> WP = wikipedia 
> 
> Given that there is no pgp signed tarball or even a checksum on that page,  have you asked the maintainer about this and verified that you got the code unaltered? 
> -- 
> Sent from my k-9 mail for Android.
Maxim Cournoyer Aug. 6, 2021, 3:20 a.m. UTC | #6 
Hello,

<pkill9@runbox.com> writes:

> I've attached an updated patch with the modifications suggested so far:
>
>  - Changed license from expat to public-domain
>  - Changed "No tests" to lowercase "no tests"
>  - Added "no configure file" comment
>  - Install Readme files
>
> I indent the package definition in emacs by marking the package
> definition (CTRL+Space) and running `M-x indent-region`, I'm not sure
> what indentation was wrong with the original patch I submitted, but I
> ran indent-region on it again anyway.

[...]

Applied as commit f8f096d1e8f930ebeecd98125b9c03d97b3c7f65, with some
small adjustments.

Thank you!

Maxim
diff mbox series

Patch

From b82be816ed92afd3988ffdee1206edfe9a19616a Mon Sep 17 00:00:00 2001
From: Pkill -9 <pkill9@runbox.com>
Date: Tue, 19 Feb 2019 07:46:29 +0000
Subject: [PATCH] gnu: Add tetrinet.

* gnu/packages/games.scm (tetrinet): New variable.
---
 gnu/packages/games.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index f82af0e8c..e6f7f7b79 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -36,6 +36,7 @@ 
 ;;; Copyright © 2018 Madalin Ionel-Patrascu <madalinionel.patrascu@mdc-berlin.de>
 ;;; Copyright © 2018 Benjamin Slade <slade@jnanam.net>
 ;;; Copyright © 2018 Alex Vong <alexvong1995@gmail.com>
+;;; Copyright © 2019 Pkill -9 <pkill9@runbox.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -6102,3 +6103,44 @@  to download and install them in @file{$HOME/.stepmania-X.Y/Songs} directory.")
     (home-page "https://www.stepmania.com")
     (license license:expat)))
 
+(define-public tetrinet
+  (package
+    (name "tetrinet")
+    (version "0.11")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://tetrinet.or.cz/download/tetrinet-"
+             version
+             ".tar.bz2"))
+       (sha256
+        (base32
+         "0b4pddqz6is1771qmvcj8qqlr4in2djdbkk13agvp9yhfah2v8x7"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("ncurses" ,ncurses)))
+    (arguments
+     `(#:tests? #f ; no tests.
+       #:make-flags '("CC=gcc")
+       #:phases (modify-phases %standard-phases
+                  (delete 'configure) ; no configure script.
+                  (add-after 'unpack 'fix-install-dir
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let ((out (assoc-ref outputs "out")))
+                        (mkdir-p (string-append out "/bin"))
+                        (substitute* "Makefile"
+                          (("/usr/games") (string-append out "/bin"))))))
+                  (add-after 'install 'install-documentation
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out (assoc-ref outputs "out"))
+                             (doc (string-append out "/share/doc/" ,name "-" ,version)))
+                        (for-each (lambda (file)
+                                    (install-file file doc))
+                                  (list "README" "tetrinet.txt"))
+                        #t))))))
+    (home-page "http://tetrinet.or.cz")
+    (synopsis "Multiplayer tetris")
+    (description "Tetrinet is a multiplayer tetris game with powerups and
+attacks you can use on opponents.")
+    (license license:public-domain)))
-- 
2.20.1