Message ID | 20200902125643.27201-1-maxim.cournoyer@gmail.com |
---|---|
State | New |
Headers | show |
Series | [bug#43160,v2,1/4] gnu: linux-libre: Use Python 3 in make-linux-libre-source. | expand |
Context | Check | Description |
---|---|---|
cbaines/comparison | success | View comparision |
cbaines/git branch | success | View Git branch |
cbaines/applying patch | success | View Laminar job |
Hello Maxim, > Successfully tested with all of the linux-libre versions we carry in Guix: > 4.4.234, 4.9.234, 4.14.195, 4.19.142, 5.4.61 and 5.8.5. This looks fine. Did you check if cross-compilation is also working correctly? Thanks, Mathieu
Hello Mathieu, Mathieu Othacehe <othacehe@gnu.org> writes: > Hello Maxim, > >> Successfully tested with all of the linux-libre versions we carry in Guix: >> 4.4.234, 4.9.234, 4.14.195, 4.19.142, 5.4.61 and 5.8.5. > > This looks fine. Did you check if cross-compilation is also working > correctly? I just tested with guix build --system=linux-armhf --check --source, and it seems to be working correctly. I pushed that single commit to master as f029bca1032c7e032f2920540b0aa1a3733e2cc9. Thank you, Maxim
Hey Maxim, > I just tested with guix build --system=linux-armhf --check --source, and > it seems to be working correctly. I pushed that single commit to master > as f029bca1032c7e032f2920540b0aa1a3733e2cc9. Great. I just had a look to the rest of the patchset. This seems fine to me :). Thanks, Mathieu
Mathieu Othacehe <othacehe@gnu.org> writes: > Great. I just had a look to the rest of the patchset. This seems fine to > me :). > > Thanks, > > Mathieu Hello Mathieu Thanks for looking at this. I have split the patch into 3 commits and emailed as a new series. Mike
Hello! Mathieu Othacehe <othacehe@gnu.org> writes: > Hey Maxim, > >> I just tested with guix build --system=linux-armhf --check --source, and >> it seems to be working correctly. I pushed that single commit to master >> as f029bca1032c7e032f2920540b0aa1a3733e2cc9. > > Great. I just had a look to the rest of the patchset. This seems fine to > me :). Thank you! As you and Mark agreed that the first 3 were good to go, I've now pushed them. The last one is still in discussion with Mark. Thanks, Maxim
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index d3b3f4de9c..8edbe4e7e4 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -296,11 +296,7 @@ corresponding UPSTREAM-SOURCE (an origin), using the given DEBLOB-SCRIPTS." #+(canonical-package bzip2) #+(canonical-package gzip) #+(canonical-package tar) - ;; The comments in the 'deblob-check' script - ;; claim that it supports Python 2 and 3, but - ;; in fact it fails when run in Python 3 as - ;; of version 5.1.3. - #+python-2)) + #+python-wrapper)) (with-directory-excursion "/tmp/bin" @@ -337,7 +333,6 @@ corresponding UPSTREAM-SOURCE (an origin), using the given DEBLOB-SCRIPTS." (error "multiple directories found" dirs))))) (with-directory-excursion dir - (setenv "PYTHON" (which "python")) (format #t "Running deblob script...~%") (force-output) (invoke "/tmp/bin/deblob"))